Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-util] - Add additional configuration options to supportsTracing #20381

Closed
maorleger opened this issue Feb 15, 2022 · 2 comments
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. test-utils Label for the issues related to the @azure/test-utils package

Comments

@maorleger
Copy link
Member

When upgrading eventhubs in this PR I noticed that the existing supportsTracing test helper could use some additional configuration. In the PR I just did those validations using sinon mocks, but ideally we'll be able to pass those into supportsTracing

Some things that I was missing:

  • ignoreDuplicateSpanNames -> Since LROs poll N times we currently make a set of all the span names and compare that, but it doesn't give us a way to ensure that N spans were created, like in the case of message batches in EH. Some config here might either be a true / false, or a list of span names to ignore duplicates for...
  • expectedSpanAttributes -> An object containing span attributes and their values that should be set on a span
  • expectedSpanKind

As I continue to upgrade packages I'll keep adding to this list

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 15, 2022
@maorleger maorleger self-assigned this Feb 15, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'App Configuration:0.09364054,Azure.Core:0.09225228,Cosmos:0.07851388'

@maorleger maorleger added this to the Backlog milestone Feb 15, 2022
@maorleger maorleger added Client This issue points to a problem in the data-plane of the library. test-utils Label for the issues related to the @azure/test-utils package labels Feb 15, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 15, 2022
@xirzec xirzec assigned mpodwysocki and unassigned maorleger Jun 6, 2022
Copy link

Hi @maorleger, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. test-utils Label for the issues related to the @azure/test-utils package
Projects
None yet
Development

No branches or pull requests

4 participants