Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent DOM attributes for local screen share stream #29260

Open
5 tasks
burnhamrobertp opened this issue Apr 10, 2024 · 0 comments
Open
5 tasks

Inconsistent DOM attributes for local screen share stream #29260

burnhamrobertp opened this issue Apr 10, 2024 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Communication - Calling Server Communication customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@burnhamrobertp
Copy link

  • @azure/communication-calling:
  • 1.23.2:
  • Windows:
  • nodejs
    • version:
  • [*] browser
    • All
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
Local screen share stream appended to the DOM via the typical new VideoStreamRenderer and renderer.createView methods does not receive any of the typical attributes that local non-screen share streams or remote streams (whether video or screen share) get. This includes attributes like playsinline or disablepictureinpicture or - most importantly - the style="width: 100%; height: 100%; object-fit: contain;"

To Reproduce
Steps to reproduce the behavior:

  1. Join a room using the @azure/communication-calling but without using the UI library; share your screen.

Expected behavior
a view created via the VideoStreamRenderer has consistent styling and attributes (where appropriate) regardless of whether its local or remote, and regardless of its mediaStreamType.

Screenshots
Local screen share resulting from createView
image

The same screen share in the same session, viewed by another user (which is seeing it as a remote stream)
image

Additional context
Initially observed when accessing the local screen share track via call.localScreenSharingStream and when accessing the remote screen share track via call.remoteScreenSharingStream

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Apr 10, 2024
@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Communication Communication - Calling Server labels Apr 11, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Communication - Calling Server Communication customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

4 participants