[Storage] Cleanup - Post Preview 3

[HarshaNalluru]

• JSDoc comments
  • options or options={} [Storage] Merge upstream/master into feature/storage #5082 (comment)

  • azure-sdk-for-js/sdk/storage/storage-file/src/DirectoryClient.ts

    Line 920 in 27c0336

    * @param {DirectoryListHandlesSegmentOptions} [options={}]

• JSDoc comments - add the @type and @memberof info
  • [Storage] Merge upstream/master into feature/storage #5082 (comment)
• Naming of stringToBuffer2 sounds confusing. - "storage-blob/src/BatchUtils.ts"
  • [Storage] Merge upstream/master into feature/storage #5082 (comment) and
  • Related code - [Storage] Merge upstream/master into feature/storage #5082 (comment)
• toLocaleLowerCase() vs toLowerCase()
  

  azure-sdk-for-js/sdk/storage/storage-blob/src/utils/utils.common.ts

  Lines 364 to 366 in 3a68763

  	export function iEqual(str1: string, str2: string): boolean {
  	return str1.toLocaleLowerCase() === str2.toLocaleLowerCase();
  	}

  • [Storage] Merge upstream/master into feature/storage #5082 (comment)
• accessTier vs tier
  • [Storage] Merge upstream/master into feature/storage #5082 (comment)

[ramya-rao-a]

Are these still applicable?

[HarshaNalluru]

Yes, I've started working on this yesterday.

[ljian3377]

What's the status and who should follow up?

[HarshaNalluru]

Not sure, I believe some of them are done!

[ramya-rao-a]

@ljian3377 I would recommend that you do another review of the tasks above and create a new issue for ones that you see are still applicable.