Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize tsconfig.json for all packages #5276

Closed
23 of 26 tasks
xirzec opened this issue Sep 27, 2019 · 7 comments
Closed
23 of 26 tasks

Standardize tsconfig.json for all packages #5276

xirzec opened this issue Sep 27, 2019 · 7 comments
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated

Comments

@xirzec
Copy link
Member

xirzec commented Sep 27, 2019 •
edited by ramya-rao-a
Loading

Right now packages have different tsconfig.json settings, especially around strictness flags.

We should have all configs inherit from a common config that enforces the right level of strictness checks.

Packages to tackle:

  • sdk/core/abort-controller
  • sdk/core/core-arm
  • sdk/appconfiguration/app-configuration
  • sdk/core/core-amqp
  • sdk/core/core-async-iterator/polyfill
  • sdk/core/core-auth
  • sdk/core/core-http
  • sdk/core/core-paging
  • sdk/core/core-tracing
  • sdk/core/core-lro
  • sdk/core/logger
  • sdk/cosmosdb/cosmos
  • sdk/eventhub/event-hubs
  • sdk/eventhub/eventhubs-checkpointstore-blob
  • sdk/eventhub/event-processor-host
  • sdk/eventhub/testhub
  • sdk/identity/identity
  • sdk/keyvault/keyvault-certificates
  • sdk/keyvault/keyvault-keys
  • sdk/keyvault/keyvault-secrets
  • sdk/servicebus/service-bus
  • sdk/storage/storage-blob
  • sdk/storage/storage-file
  • sdk/storage/storage-queue
  • sdk/template/template
  • sdk/test-utils/recorder
@xirzec xirzec self-assigned this Sep 27, 2019
@loarabia loarabia added the Client This issue points to a problem in the data-plane of the library. label Sep 27, 2019
@xirzec xirzec mentioned this issue Sep 30, 2019
Merged
@xirzec xirzec added this to the [2019] December milestone Nov 18, 2019
@xirzec xirzec mentioned this issue Nov 20, 2019
Merged
@ramya-rao-a ramya-rao-a assigned willmtemple and unassigned xirzec Jan 6, 2020
@willmtemple willmtemple mentioned this issue Feb 21, 2020
Merged
@xirzec xirzec modified the milestones: [2020] February, [2020] April Mar 9, 2020
@ramya-rao-a ramya-rao-a modified the milestones: [2020] April, Backlog Apr 17, 2020
@xirzec xirzec mentioned this issue May 1, 2020
Closed
@sadasant
Copy link
Contributor

sadasant commented May 1, 2020

@xirzec & @ramya-rao-a I tried to do this for cosmosdb/cosmos but the number of errors and API changes is just too much for a quick pass. I will skip it for now.

@sadasant
Copy link
Contributor

sadasant commented May 2, 2020

Marked sdk/core/logger as done since somebody already did it.

@sadasant sadasant self-assigned this May 2, 2020
@sadasant sadasant mentioned this issue May 2, 2020
Merged
14 tasks
@sadasant
Copy link
Contributor

sadasant commented May 6, 2020

Marked sdk/template/template since it seems to already be standardized.

@ramya-rao-a ramya-rao-a added help wanted This issue is tracking work for which community contributions would be welcomed and appreciated and removed Up for grabs labels Sep 15, 2020
@ramya-rao-a
Copy link
Contributor

#8671 has covered most of the packages listed above. thanks to @sadasant!
cosmos and identity packages are pending

@ramya-rao-a ramya-rao-a mentioned this issue Sep 23, 2020
Merged
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, MQ-2020 Nov 19, 2020
@ramya-rao-a
Copy link
Contributor

@deyaaeldeen, Please check what is pending here and lets get this done!

This was referenced Nov 25, 2020
Closed
Closed
Closed
Closed
@southpolesteve
Copy link
Contributor

@deyaaeldeen I don't think a file by file approach will work for Cosmos. We either need to do it all in a single PR or do something like VSCode did where they look at the dependency graph and start at the edges.

This was referenced Nov 30, 2020
Merged
Closed
@ramya-rao-a ramya-rao-a modified the milestones: MQ-2020, Backlog Dec 17, 2020
@jeremymeng jeremymeng added the EngSys This issue is impacting the engineering system. label Sep 17, 2021
@github-actions GitHub Actions
Copy link

Hi @xirzec, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@sadasant @loarabia @southpolesteve @xirzec @willmtemple @deyaaeldeen @jeremymeng @ramya-rao-a