Updating cognitiveservices-luis-authoring SDK #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itiveServicesCredentials
ramya-rao-a
reviewed
Aug 20, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/README.md
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 20, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/lUISAuthoringClient.ts
Show resolved
Hide resolved
ramya-rao-a
suggested changes
Aug 20, 2019
There was a problem hiding this comment.
@ahmedabuamra Some of the comments I made in #4791 applies here as well, so please take a look at those.
Can you update the PR description with list of changes that you had to do manually? Please do the same for the other PR as well
ahmedabuamra
changed the title
|
What I have changed:
|
ChrisHMSFT
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/README.md
Outdated
Show resolved
Hide resolved
ChrisHMSFT
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/README.md
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/README.md
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/package.json
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/operations/apps.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/operations/azureAccounts.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/operations/examples.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/operations/features.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/operations/index.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/operations/model.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/operations/pattern.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/operations/permissions.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/operations/settings.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/operations/train.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 22, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/src/operations/versions.ts
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 23, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/package.json
Outdated
Show resolved
Hide resolved
ramya-rao-a
approved these changes
Aug 23, 2019
ramya-rao-a
suggested changes
Aug 23, 2019
There was a problem hiding this comment.
@kayousef mentioned that we want to auto publish this library. Therefore, please update the package version and enable the autopublish feature by adding back the "autoPublish": true in package.json file
|
@kayousef , @ramya-rao-a |
|
Since we have decided to get an update published with this PR approved, can we also get the browser sample updated? |
ramya-rao-a
approved these changes
Aug 23, 2019
ramya-rao-a
reviewed
Aug 25, 2019
| let authoringKey = process.env["luis-authoring-key"]; | ||
| const creds = new CognitiveServicesCredentials(authoringKey); | ||
| const region = "<your-region>"; | ||
| const client = new LUISAuthoringClient( |
There was a problem hiding this comment.
Suggested change
| const client = new LUISAuthoringClient( | |
| const client = new Azure.CognitiveservicesLuisAuthoring.LUISAuthoringClient( |
There was a problem hiding this comment.
@ahmedabuamra This change is still pending.
There was a problem hiding this comment.
sorry I missed it.
ramya-rao-a
reviewed
Aug 25, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/README.md
Outdated
Show resolved
Hide resolved
ramya-rao-a
reviewed
Aug 25, 2019
sdk/cognitiveservices/cognitiveservices-luis-authoring/README.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All lines of code in this PR are auto-generated except updating the README.md file.