Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure.Search: Clean up JSON parsing #10596

Closed
tg-msft opened this issue Mar 13, 2020 · 0 comments · Fixed by #12610
Closed

Azure.Search: Clean up JSON parsing #10596

tg-msft opened this issue Mar 13, 2020 · 0 comments · Fixed by #12610
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone

Comments

@tg-msft
Copy link
Member

tg-msft commented Mar 13, 2020

Ahson left a lot of super valuable feedback on #10568 about the best patterns for using System.Text.Json including:

  • Avoid allocating so many extra strings for property name checks
  • Don't assert on token types when calling Get* methods
  • Whether or not we can use converters for SearchDocument
  • Encoding our constant values
  • Using a JsonConverter for null arrays
@tg-msft tg-msft added Client This issue points to a problem in the data-plane of the library. Search labels Mar 13, 2020
@tg-msft tg-msft self-assigned this Mar 13, 2020
@tg-msft tg-msft added this to the [2020] April milestone Mar 19, 2020
@tg-msft tg-msft modified the milestones: [2020] April, [2020] May Apr 6, 2020
@tg-msft tg-msft modified the milestones: [2020] May, [2020] June May 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant