Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Support sendX5c in ClientCertificateCredential to allow SubjectName+issuer validation #12130

Closed
ohadschn opened this issue May 17, 2020 · 3 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@ohadschn
Copy link

Library or service name.
Azure.Identity

Is your feature request related to a problem? Please describe.
When requesting a token via AuthenticationContext.AcquireTokenAsync (in the Microsoft.IdentityModel.Clients.ActiveDirectory assembly), there are overloads that accept the sendX5c parameter:

This parameter enables application developers to achieve easy certificates roll-over in Azure AD: setting this parameter to true will send the public certificate to Azure AD along with the token request, so that Azure AD can use it to validate the subject name based on a trusted issuer policy. This saves the application admin from the need to explicitly manage the certificate rollover (either via portal or powershell/CLI operation)

This is critical for auto rotation scenarios, where you have your cert auto-renewed in KeyVault and you want your certs to maintain their access to their AAD apps following such renewals.

There is currently no way that I can tell so specify this parameter in Azure.Identity's ClientCertificateCredential, forcing users to drop to the lower AuthenticationContext level.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 17, 2020
@jsquire jsquire added Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels May 18, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 18, 2020
@schaabs
Copy link
Contributor

schaabs commented May 18, 2020

@ohadschn Thanks for filling this issue. Adding support for SubjectName / Issuer authentication with the ClientCertificateCredential is currently on our backlog. While support for this did not make it into our current round of previews for the Azure.Identity library, I expect this will be one of the first features we work on after we GA what is currently in preview. I hope to have at least a preview of SubjectName / Issuer support ealry this fall. I'll update this issue once we have more information available.

@schaabs schaabs added feature-request This issue requires a new behavior in the product in order be resolved. and removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 18, 2020
@schaabs schaabs added this to the Backlog milestone May 18, 2020
@JackXuCN
Copy link

JackXuCN commented Aug 25, 2020

Use the solution here before Azure.Identity support SendX5c Link

@schaabs
Copy link
Contributor

schaabs commented Oct 8, 2020

This has been implemented in #14636, and is available in 1.3.0-beta.1 or later. The feature is still in preview so if you have any feedback on its usability please open an issue and let us know.

@schaabs schaabs closed this as completed Oct 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

No branches or pull requests

5 participants