Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making MetricsFeedback class abstract #15613

Closed
christothes opened this issue Oct 1, 2020 · 0 comments · Fixed by #18511
Closed

Consider making MetricsFeedback class abstract #15613

christothes opened this issue Oct 1, 2020 · 0 comments · Fixed by #18511
Assignees
@kinelski
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2021] February

Comments

@christothes
Copy link
Member

see #15546 (comment)
@christothes christothes added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Oct 1, 2020
@christothes christothes added this to the [2020] November milestone Oct 1, 2020
@christothes christothes mentioned this issue Oct 1, 2020
Merged
@kinelski kinelski modified the milestones: [2020] November, Backlog Nov 4, 2020
@kinelski kinelski modified the milestones: Backlog, [2021] February Jan 12, 2021
@kinelski kinelski added the blocking-release Blocks release label Jan 13, 2021
@kinelski kinelski changed the title Consider making MetricsFeedback class abstract Consider making MetricsFeedback and NotificationHook classes abstract Feb 5, 2021
@kinelski kinelski changed the title Consider making MetricsFeedback and NotificationHook classes abstract Consider making MetricsFeedback class abstract Feb 5, 2021
@kinelski kinelski mentioned this issue Feb 6, 2021
Merged
@kinelski kinelski self-assigned this Feb 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kinelski kinelski

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2021] February
Development

Successfully merging a pull request may close this issue.

[MetricsAdvisor] Made MetricFeedback class abstract kinelski/azure-sdk-for-net
2 participants
@christothes @kinelski