Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SearchServiceClient into SearchIndexClient and SearchIndexerClient #11507

Closed
heaths opened this issue May 18, 2020 · 3 comments
Closed
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search
Milestone

Comments

@heaths
Copy link
Member

heaths commented May 18, 2020

To avoid too many methods in SearchServiceClient, we will refactor it into two separate clients that group the functionality into index management, and skillsets (enrichments) management. Method names will retain their names they have today, like CreateIndex, DeleteIndex, CreateDataSource, DeleteDataSource, etc. This also means there should be the GetServiceStatistics like we should have no, instead of dropping "Service". This differentiates it with GetIndexStatistics.

  • SearchIndexClient will aggregate:

    • Index operations: CreateIndex, etc.
    • Synonym map operations: CreateSynonymMap, etc.
    • Service operations: GetServiceStatistics
    • Define/retain GetSearchClient that takes a string indexName and returns a SearchClient
  • SearchIndexerClient will aggregate:

    • Indexer operations: CreateIndexer, etc.
    • Data source operations: CreateDataSource, etc.
    • Skillset operations: CreateSkillset, etc.
@heaths heaths added blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search labels May 18, 2020
@heaths heaths added this to the [2020] June milestone May 18, 2020
@bryevdv
Copy link
Contributor

bryevdv commented May 18, 2020

@xiangyan99 Do you have a preference about #11342 ? I have split that PR in to very fine-grained commits it might be simpler for you to cherry pick the ones you want to keep, given this and other new rename changes in the original rename issue. Alternatively we can merge #11342 now as-is if that's easier to start from. What do you think?

@heaths heaths changed the title Refact SearchServiceClient into SearchIndexClient and SearchIndexerClient Refactor SearchServiceClient into SearchIndexClient and SearchIndexerClient May 18, 2020
@xiangyan99
Copy link
Member

Either one works.

@xiangyan99
Copy link
Member

Fixed in #11572

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Development

No branches or pull requests

3 participants