Investigate all skipped Storage tests

[jalauzon-msft]

We have quite a few tests marked with pytest.skip, pytest.mark.skip, or pytest.mark.skipif that have various comments about past Issues or things that need to be "investigated later". Some have GitHub issues mentioned in the comments and some do not. It looks like some were also skipped because they don't run Live/Recorded but we have other mechanisms for that. Ignored tests have a huge potential to let regressions slip through and ideally, we should not have any.

We need to audit all instances of skipped tests and ideally eliminate them. My hunch is that many of them will just work now but those that don't we should fix.

To find tests, search the Storage packages for pytest.skip, pytest.mark.skip, or pytest.mark.skipif.

✔Checkmark = Resolved
☐ No checkmark = Not resolved, comment to the right

pytest.skip

• test_copy_blob_with_blob_tier_specified | Skipped because doesn't work on premium, but test case works fine with standard account (begs the Q: where was premium account implied [and the Err msg is about Block blob not prem. tier]
• test_copy_blob_with_rehydrate_priority | Skipped because doesn't work on premium, but works fine with standard account
• test_list_blobs_include_deletedwithversion_async | Pytest skip comment was already commented out, just removing now
• test_list_blobs_include_deletedwithversion | Pytest skip comment was already commented out, just removing now
• test_list_blobs_with_include_metadata | Pytest skip comment was already commented out, just removing now
• test_list_blobs_include_deletedwithversion | Pytest skip comment was already commented out, just removing now
• test_list_blobs_with_include_multiple | Metadata XML Fix in MSRest, removed skip
• test_unicode_get_messages_unicode_data | Metadata XML Fix in MSRest, removed skip
• test_unicode_update_message_unicode_data | Metadata XML Fix in MSRest, removed skip
• test_no_server_encryption (async) | Resolved, removed AiohttpTestTransport workaround
• test_upload_large_stream_without_network (async) | Continue skipping, changed to decorator
• test_upload_large_stream_without_network | Continue skipping, changed to decorator
• test_rename_file_with_account_sas | Continue to skip, requires further investigation
• test_rename_directory_to_non_empty_directory | Continue to skip, requires further investigation
• test_rename_directory_to_non_empty_directory_async | Continue to skip, requires further investigation
• test_rename_from_a_shorter_directory_to_longer_directory_async | Continue to skip, requires further investigation
• test_rename_from_a_shorter_directory_to_longer_directory | Continue to skip, requires further investigation
• test_rename_file_system_with_file_system_client | Continue to skip, requires further investigation
• test_rename_file_system_with_file_system_client | Continue to skip, requires further investigation
• test_restore_file_system_with_sas | Failing with ResourceExistsError (seems like test was poorly written, I think undelete needs some sleep time)
• test_close_single_handle_async | Continue skipping, changed to decorator
• test_close_all_handle_async | Continue skipping, changed to decorator
• test_list_handles_on_share | Continue skipping, changed to decorator
• test_list_handles_on_share_snapshot | Continue skipping, changed to decorator
• test_list_handles_with_marker | Skipped, requires rigorous manual setup #24498
• test_list_handles_on_directory | Continue skipping, changed to decorator
• test_list_handles_on_file | Continue skipping, changed to decorator
• test_restore_file_system_with_sas (async) | Failing with ResourceExistsError (seems like test was poorly written, I think undelete needs some sleep time)
• test_client_request_id_echo (file_client) | Azure test error with mgmt_settings_real.py
• test_client_request_id_echo (blob_client) | Azure test error with mgmt_settings_real.py
• test_retry_put_block_with_seekable_stream_async | Cryptic HttpResponseError

pytest.mark.skip

• test_set_blob_tags_using_blob_sas | Previously triage'd by me, but resolved now 😄
• test_list_encoded_blobs | Resolved as we are deprecating Python 2.7
• test_create_largest_blob_from_stream_without_network (async) | Does indeed take a long time...
• test_put_block_bytes_largest | Skipped because long runtime. Run ad-hoc if necessary.
• test_put_block_stream_largest | Skipped because long runtime. Run ad-hoc if necessary.
• test_create_largest_blob_from_path | Skipped because long runtime. Run ad-hoc if necessary.
• test_create_largest_blob_from_stream_without_network | Skipped because long runtime. Run ad-hoc if necessary.
• test_put_block_bytes_largest (async) | Skipped because long runtime. Run ad-hoc if necessary.
• test_put_block_stream_largest (async) | Skipped because long runtime. Run ad-hoc if necessary.
• test_create_largest_blob_from_path (async) | Skipped because long runtime. Run ad-hoc if necessary.
• test_premium_tier_set_tier_api_batch | TODO: Retry with premium acc (page blob not block blob)
• test_premium_tier_set_tier_api_batch | TODO: Retry with premium acc (page blob not block blob)
• test_premium_tier_set_tier_api_batch | TODO: Retry with premium acc (page blob not block blob)
• test_token_credential_with_batch_operation | Authority configuration error very confusing and cryptic, see OneNote
• test_filter_blobs_using_account_sas | Previously triage'd by me, still failing assert 2 != 1 😢
• test_rename_container_with_container_client (async) | Skipped citing feature not enabled, seems like still not enabled (InvalidQueryParameterValue)
• test_rename_container_with_container_client | Skipped citing feature not enabled, seems like still not enabled (InvalidQueryParameterValue)
• test_incremental_copy_blob | Failing for different error than cited, new error: TypeError: Session.request() got an unexpected keyword argument 'seal_blob'
• test_incremental_copy_blob (async) | Failing for different error than cited, new error: TypeError: Session.request() got an unexpected keyword argument 'seal_blob'

pytest.mark.skipif

• test_message_bytes_fails | Resolved as we are deprecating Python 2.7
• test_premium_tier_set_tier_api_batch | TODO: Retry with premium acc (page blob not block blob)
• test_token_credential_with_batch_operation | Authority configuration error very confusing and cryptic, see OneNote
• test_list_encoded_blobs | Comment says py2 and py3 recordings differ, but failing in live in Python3 (assert error 'dir1/dir2/file\uffff.blob' != 'dir1')

One-Off Uses

• Inside of test_large_block_blob.py (and async) we have a pytest.skip used if the platform.python_implementation() == 'Pypy'

Remaining skipped Storage tests will be maintained in #24552 as this issue will be marked closed with a PR currently out (#24550)