Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metricsadvisor] update min dependency package #25917

Closed
wonder6845 opened this issue Aug 29, 2022 · 7 comments
Closed

[metricsadvisor] update min dependency package #25917

wonder6845 opened this issue Aug 29, 2022 · 7 comments
Assignees
Labels
Cognitive - Metrics Advisor customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@wonder6845
Copy link
Contributor

wonder6845 commented Aug 29, 2022

ref

#25814
#25731

I find a issue during updating about drop python 3.6 at metricsadvisor (ref ##25814)

I think it's better updating min dependency package autorest.

-autorest-
#25731

please inform me if anything problem found
Thank you.

@ghost ghost added customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 29, 2022
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 29, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Azure.Core:0.38922182,Storage:0.16220847,Event Hubs:0.028365484'

@iscai-msft
Copy link
Contributor

iscai-msft commented Sep 1, 2022

@wonder6845 what is the issue you're running into? If I'm reading your issue your correctly it seems you're saying MetricsAdvisor and autorest both still include Python3.6 in their packages, but that is not the case. Can you re-explain what you're running into? Thanks

@iscai-msft iscai-msft self-assigned this Sep 1, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 1, 2022
@iscai-msft iscai-msft added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 1, 2022
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 1, 2022
@iscai-msft iscai-msft added question The issue doesn't require a change to the product in order to be resolved. Most issues start as that and removed bug This issue requires a change to an existing behavior in the product in order to be resolved. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Sep 1, 2022
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 1, 2022
@wonder6845
Copy link
Contributor Author

wonder6845 commented Sep 2, 2022

@iscai-msft Hello, first of all i want to apologize to post a rather unfriendly and not detailed issue.
I want to add the latest dependency package with reference to https://github.com/Azure/autorest.
I pull requested drop python 3.6 (#25814) and I found and It has been found that the Autorest package is not the latest version.
ex) sdk/metricsadvisor/azure-ai-metricsadvisor/setup.py
before

install_requires=[
"azure-core<2.0.0,>=1.23.0",
"msrest>=0.6.21",

after

install_requires=[
"azure-core<2.0.0,>=1.24.0",
"msrest>=0.7.1",

So, if there is no problem, I would like to update the autorest on the metrics advisor, Is it okay?

Thanks.

Hong

@iscai-msft
Copy link
Contributor

No worries @wonder6845 , thanks for the clarification!

The setup.py that metrics advisor has actually isn't generated by AutoRest. There are some specific dependencies that we've added, so the SDK author currently has full control of the setup.py, and AutoRest generation won't change anything about the setup.py.

That being said, I'm not opposed to an AutoRest regeneration PR, it has been a while since we've regenerated, and the generated code will change a decent amount. The setup.py will remain the same though with generation, so if you do regenerate please take care to update the setup.py mindep. This isn't high priority though, thanks for asking!

@xiangyan99
Copy link
Member

Is this still valid?

@xiangyan99 xiangyan99 added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Apr 14, 2023
@github-actions github-actions bot removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Apr 14, 2023
@github-actions
Copy link

Hi @wonder6845. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

@github-actions
Copy link

Hi @wonder6845, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Apr 21, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Cognitive - Metrics Advisor customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants