Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Azure HPC Cache name is limited to 31 characters instead of 80 #2759

Closed
jsmartt opened this issue Feb 19, 2020 · 8 comments
Closed

Azure HPC Cache name is limited to 31 characters instead of 80 #2759

jsmartt opened this issue Feb 19, 2020 · 8 comments
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Attention This issue is responsible by Azure service team. Storage

Comments

@jsmartt
Copy link
Contributor

jsmartt commented Feb 19, 2020

Many places in this file, there is a regex, validating the name matches the pattern ^[-0-9a-zA-Z_]{1,31}$. It will prevent any action (including get or create) with a name longer than 31 characters by raising the following error:

ArgumentError: 'cache_name' should satisfy the constraint - 'Pattern': '^[-0-9a-zA-Z_]{1,31}$'

However, the Azure console shows the following validation:

Screen Shot 2020-02-19 at 4 01 21 PM

The API validation allows 80 characters, so I'm guessing this SDK needs updated.

@mmyyrroonn mmyyrroonn added Service Attention This issue is responsible by Azure service team. triage labels Feb 20, 2020
@ghost
Copy link

ghost commented Feb 20, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage

@mmyyrroonn
Copy link
Contributor

@jsmartt Hello. Our SDK is auto-generated. The root cause is that service team set this limitation in their swagger spec. We have to fix it in the swagger spec first. I add service attention to invite correct team.
https://github.com/Azure/azure-rest-api-specs/blob/62b1b41dd4637c3667943aa5b845f08e81671437/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2019-11-01/storagecache.json#L269

But it's better to open a PR in this repo https://github.com/Azure/azure-rest-api-specs/

@jsmartt
Copy link
Contributor Author

jsmartt commented Mar 5, 2020

Thanks @myronfanqiu. I did open a PR on that repo, but it looks like it needs some help from some MSFT folks to fix build/validation issues and enable SDK automation.

@mmyyrroonn
Copy link
Contributor

Could you give me the PR link?

@jsmartt
Copy link
Contributor Author

jsmartt commented Mar 6, 2020

It's linked just above my comment too, but it's Azure/azure-rest-api-specs#8606

@romahamu
Copy link

Hi @jsmartt thanks for pointing it out.

@myronfanqiu There is a new version coming, which has this fix. https://github.com/Azure/azure-rest-api-specs/pull/8403/files

@mmyyrroonn
Copy link
Contributor

@romahamu good to know. Once it's merged, you can request a sdk release through https://portal.azure-devex-tools.com/

@azure-sdk azure-sdk added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 24, 2020
@lilyjma
Copy link

lilyjma commented Jan 8, 2021

Hi, this issue appears to be resolved, so I'm closing it now. Thanks!

@lilyjma lilyjma closed this as completed Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Service Attention This issue is responsible by Azure service team. Storage
Projects
None yet
Development

No branches or pull requests

5 participants