Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET: Add support for SyncAsyncEventHandlerExtensions.RaiseAsync to async analyzer #1357

Open
tg-msft opened this issue Jan 29, 2021 · 0 comments
Open

.NET: Add support for SyncAsyncEventHandlerExtensions.RaiseAsync to async analyzer #1357

tg-msft opened this issue Jan 29, 2021 · 0 comments
Labels
API Analyzer Client This issue points to a problem in the data-plane of the library.

Comments

@tg-msft
Copy link
Member

tg-msft commented Jan 29, 2021

See Azure/azure-sdk-for-net#18170 until SyncAsyncEventHandler is merged into Azure.Core.

SyncAsyncEventHandlerExtensions.RaiseAsync doesn't take bool async and CancellationToken cancellationToken parameters because they're already being passed in the SyncAsyncEventArgs. We should update the analyzer to verify this as part of the pattern. This is a lower priority because we will not have very many SyncAsyncEventHandlers.
@tg-msft tg-msft added API Analyzer Client This issue points to a problem in the data-plane of the library. labels Jan 29, 2021
This was referenced Jan 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Analyzer Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tg-msft