Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stress testing] Use local stress-test-addons reference in dev environment #3135

Closed
benbp opened this issue Apr 12, 2022 · 0 comments · Fixed by #3481
Closed

[stress testing] Use local stress-test-addons reference in dev environment #3135

benbp opened this issue Apr 12, 2022 · 0 comments · Fixed by #3481
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Stress This issue is related to stress testing, part of our reliability pillar.

Comments

@benbp
Copy link
Member

benbp commented Apr 12, 2022

When using dev environments for stress testing, the environment values get added to stress-test-addons values.yaml. Any charts with a dependency on addons that lookup values from the env will fail by default because they will try to download the upstream stress-test-addons dependency. For local testing, we should detect a dev environment (more specifically, an environment that is not test or prod), and update the Chart.yaml dependency to reference a file path.

For example this:

dependencies:
- name: stress-test-addons
  version: 0.1.12
  repository: https://stresstestcharts.blob.core.windows.net/helm/

Becomes:

dependencies:
- name: stress-test-addons
  version: 0.1.12
  repository: file:///Git/azure-sdk-tools/tools/stress-cluster/cluster/kubernetes/stress-test-addons

This behavior should also be opt-out in case we need to test non-local chart versions of addons in a dev environment. The parameter needs to work for both provision and deploy stress tests.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 12, 2022
@ckairen ckairen self-assigned this Apr 12, 2022
@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Apr 25, 2022
@benbp benbp added the Stress This issue is related to stress testing, part of our reliability pillar. label May 12, 2022
@benbp benbp assigned benbp and unassigned ckairen Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Stress This issue is related to stress testing, part of our reliability pillar.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants