Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avocado check fails for changes that don't update swagger files #4505

Closed
weshaggard opened this issue Oct 25, 2022 · 3 comments
Closed

Avocado check fails for changes that don't update swagger files #4505

weshaggard opened this issue Oct 25, 2022 · 3 comments
Assignees
Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@weshaggard
Copy link
Member

In a case of a PR like Azure/azure-rest-api-specs#20893 which only changes MD documentation Avocado fails the pipeline.

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1942898&view=logs&j=22cb5f76-5058-5a9d-2377-d04e5451a5f2&t=75f8d99b-764d-5b43-90d5-e9f774389f08

./node_modules/.bin/avocado -f pipe.log --excludePaths "/common-types/" ".github" ".azure-pipelines" "documentation/" "arm-compute/" "profile/" "profiles/" "/scenarios/" "/package.json" "/package-lock.json" "/cadl/examples/"
========================== Starting Command Output ===========================
/usr/bin/bash --noprofile --norc /mnt/vss/_work/_temp/98c4c88b-7035-4351-8300-34ddd9025622.sh
{"level":"Error","code":"MISSING_README","message":"Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.","path":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/documentation","folderUrl":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/documentation"}
errors: 1
##[error]Bash exited with code '1'.
@weshaggard weshaggard added the Spec PR Tools Tooling that runs in azure-rest-api-specs repo. label Oct 25, 2022
@weshaggard
Copy link
Member Author

@tianxchen-ms @ruowan do you expect this is fixed by https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/pullrequest/431575

@raych1
Copy link
Member

raych1 commented Nov 1, 2022

@weshaggard , this will be fixed in sprint of Nov.

@raych1
Copy link
Member

raych1 commented Nov 2, 2022

@tianxchen-ms @ruowan do you expect this is fixed by https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/pullrequest/431575

@weshaggard , this issue wasn't fixed in above PR and we will consider making the list of exclusion files as config in next change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Status: 🎊 Closed
Development

No branches or pull requests

3 participants