Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more specific selector than control-plane: controller-manager #4277

Open
matthchr opened this issue Sep 17, 2024 · 1 comment
Open
Assignees
Milestone

Comments

@matthchr
Copy link
Member

Describe the current behavior
We use the kubebuilder default selector control-plane: controller-manager, which many other projects may also use. We should be good citizens and at least in theory support being installed into the same namespace, but if we're using the same labels as other deployments webhooks and other selectors may get confused.

See #4274 as an example.

Describe the improvement
Use a label unique to ASO.

@matthchr
Copy link
Member Author

matthchr commented Oct 4, 2024

The challenge here is that we have to delete the deployment in order to change this field.

We can do this with a Helm hook, but given it's a bit involved I'm going to kick this out to 2.11 for now.
See: https://github.com/giantswarm/azure-scheduled-events/pull/20/files for a simple example of what I'm talking about

@matthchr matthchr modified the milestones: v2.10.0, v2.11.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants