Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: management-group has no option for diagnostic logs #3362

Open
1 task done
awood86 opened this issue Sep 25, 2024 · 5 comments
Open
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Status: Help Wanted 🆘 Extra attention is needed Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@awood86
Copy link

awood86 commented Sep 25, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/management/management-group

(Optional) Module Version

0.1.2

Description

Would you be able to add Diagnostics onto this module. A bit like below:

targetScope = 'managementGroup'

param parDiagnosticSettingsName string = 'toLa'

param parLogAnalyticsWorkspaceResourceId string

resource resMgDiagSet 'Microsoft.Insights/diagnosticSettings@2021-05-01-preview' = {
  name: parDiagnosticSettingsName
  properties: {
    workspaceId: parLogAnalyticsWorkspaceResourceId
    logs: [
      {
        category: 'Administrative'
        enabled: true
      }
      {
        category: 'Policy'
        enabled: true
      }
    ]
  }
}

(Optional) Correlation Id

No response

@awood86 awood86 added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Sep 25, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Sep 25, 2024
Copy link

@awood86, thanks for submitting this issue for the avm/res/management/management-group module!

Important

A member of the @Azure/avm-res-management-managementgroup-module-owners-bicep or @Azure/avm-res-management-managementgroup-module-contributors-bicep team will review it soon!

@fblix
Copy link
Contributor

fblix commented Sep 25, 2024

Since I am currently quite busy, I would appreciate any help on this topic!

@fblix fblix added the Status: Help Wanted 🆘 Extra attention is needed label Sep 25, 2024

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Oct 1, 2024
@AlexanderSehr
Copy link
Contributor

I'll be damned. It seems like there is an API even though I cannot seem to find it in the Portal. In any case, that means nothing should speak against implementing it. The only challenge I see is that it's a bit difficult to identify which metrics/logs can be configurated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Status: Help Wanted 🆘 Extra attention is needed Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Status: Needs: Triage
Development

No branches or pull requests

3 participants