Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spread is spread (parameters) #1043

Closed
7 of 8 tasks
iscai-msft opened this issue Jun 19, 2024 · 2 comments
Closed
7 of 8 tasks

Spread is spread (parameters) #1043

iscai-msft opened this issue Jun 19, 2024 · 2 comments
Assignees
Labels
design:accepted Proposal for design has been discussed and accepted. epic lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@iscai-msft
Copy link
Contributor

iscai-msft commented Jun 19, 2024

Clear and concise description of the problem

We no longer want to recover a model from spread by default. The current behavior creates a complicated story for spreading, and leads to confusing emitter logic. The following needs to be done in this order

  1. Decorate brownfield services with @bodyRoot
  2. Update emitter logic
  3. Add overrideClientMethod decorator
  4. Move vendored BodyParameter to core

The final step is not required for the story to be complete, I'm only linking it in this issue as a reference.

Down the line, we also want to look into clearing up the logic in responses too. We will wait for a traits redesign first.

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For feature request in the typespec language or core libraries file it in the TypeSpec repo
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@weidongxu-microsoft
Copy link
Member

typespec-java 0.18.0 released with this logic

@iscai-msft
Copy link
Contributor Author

Closing because all of the tcgc work has been completed with the introduction of the @override decorator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design:accepted Proposal for design has been discussed and accepted. epic lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

No branches or pull requests

2 participants