We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Which version of Microsoft.IdentityModel are you using? latest
Where is the issue?
Repro
In doing a allocation profile of validating a token 1,000 times, one area that stuck out was using string.Replace in a few places:
One case that can be fixed is:
azure-activedirectory-identitymodel-extensions-for-dotnet/src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs
Lines 386 to 393 in a1530a0
We should be able to do that comparison allocation free.
Similarly this check:
azure-activedirectory-identitymodel-extensions-for-dotnet/src/Microsoft.IdentityModel.Validators/AadTokenValidationParametersExtension.cs
Lines 76 to 97 in a1530a0
Should be able to be done without the 2 string allocations that is happening.
The text was updated successfully, but these errors were encountered:
kellyyangsong
Successfully merging a pull request may close this issue.
Which version of Microsoft.IdentityModel are you using?
latest
Where is the issue?
Repro
In doing a allocation profile of validating a token 1,000 times, one area that stuck out was using string.Replace in a few places:
One case that can be fixed is:
azure-activedirectory-identitymodel-extensions-for-dotnet/src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs
Lines 386 to 393 in a1530a0
We should be able to do that comparison allocation free.
Similarly this check:
azure-activedirectory-identitymodel-extensions-for-dotnet/src/Microsoft.IdentityModel.Validators/AadTokenValidationParametersExtension.cs
Lines 76 to 97 in a1530a0
Should be able to be done without the 2 string allocations that is happening.
The text was updated successfully, but these errors were encountered: