Remove @style/AppTheme from manifest

[madhusudankapoor]

AndroidManifest.xml:16:9-42
is also present at [:adal-1.1.3:] AndroidManifest.xml:13:9-40 value=(@style/AppTheme)

[weijjia]

Why do you want this to be removed?

[madhusudankapoor]

In the AndroidManifest.xml of the lib currently you have android:theme="@style/AppTheme" ;

it should not present in lib project. so see if you can remove android:theme="@style/AppTheme" from below tag

OR

If you like to keep, then add tools:replace="android:theme" in <application ... > and xmlns:tools="http://schemas.android.com/tools" in manifest

<manifest xmlns:tools="http://schemas.android.com/tools" ...

[madhusudankapoor]

Any update?

[madhusudankapoor]

Any update?

[weijjia]

Done. Already released in the latest version.

[max-bb]

This has reappeared in 1.15.0; the com.microsoft.identity library is now defining an appTheme when it should not.

[iambmelt]

@max-bb I suspect that this is due to ADAL adding a dependency on common which, until recently, did erroneously include an appTheme.

Related issues can be found below:

• MSAL should not export an "AppTheme" style. microsoft-authentication-library-for-android#440
• Removes unused styles, colors xml + grammatical fix for German text microsoft-authentication-library-common-for-android#301

This should be fixed in an upcoming release (>1.16.1) but I don't have a specific date for when these changes will be available yet.

[iambmelt]

Reopening.

[bannus]

ADAL's values-v14/styles.xml can override my app's values/styles.xml if I use the name AppTheme or AppBaseTheme.

The styles.xml files in ADAL are unused AFAIK and have been present since the initial commit. Seems like they should just be removed.

[iambmelt]

Cannot change this due to backcompat breaks - closing