Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

Need to relax the authority format check on trailing slash #156

Closed
rayluo opened this issue Jun 1, 2018 · 2 comments
Closed

Need to relax the authority format check on trailing slash #156

rayluo opened this issue Jun 1, 2018 · 2 comments
Assignees

Comments

@rayluo
Copy link
Collaborator

rayluo commented Jun 1, 2018

In ADAL Python 0.7.0 and 1.0.0 we introduced a format check to ensure the authority input has the form of https://some.host.name/tenant. It successfully addresses #126, but it accidentally breaks existing customers who is using https://some.host.name/tenant/ (i.e. with a trailing slash), such as this one.

@stcheng
Copy link

stcheng commented Jun 1, 2018

thanks for logging this issue!

This was referenced Jun 5, 2018
@AzureAD AzureAD deleted a comment from stcheng Jun 13, 2018
@rayluo
Copy link
Collaborator Author

rayluo commented Jun 13, 2018

This issue has been addressed in the aforementioned PR and its subsequent release. Closing now.

PS: This issue was supposed to be auto-closed by PR #157 but we did not correctly cast the spell (pun intended). :-)

@rayluo rayluo closed this as completed Jun 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants