Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

Update sample with api_version=None #90

Closed
lmazuel opened this issue Jun 5, 2017 · 1 comment
Closed

Update sample with api_version=None #90

lmazuel opened this issue Jun 5, 2017 · 1 comment

Comments

@lmazuel
Copy link
Contributor

lmazuel commented Jun 5, 2017

To avoid warning when we follow meticulously the sample:

D:\VSProjects\azure-sdk-for-python\env3.5\lib\site-packages\adal\authentication_context.py:88: DeprecationWarning: The default behavior of including api-version=1.0 on the wire
                is now deprecated.
                Future version of ADAL will change the default value to None.

                To ensure a smooth transition, you are recommended to explicitly
                set it to None in your code now, and test out the new behavior.

                    context = AuthenticationContext(..., api_version=None)

  """, DeprecationWarning)
@rayluo
Copy link
Collaborator

rayluo commented Jun 5, 2017

Thanks for your suggestion @lmazuel ! We chose to NOT modify samples when we introduced that DeprecationWarning in PR #57, because we considered the explicit api_version=None flag as a temporary solution and it would not be necessary once we adopt the api_version=None behavior by default in next major release.

That being said, it becomes clear that we don't have any other breaking changes in the backlog, so the next major release won't be available anytime soon. I will go ahead and modify all current samples as you suggested. Stay tuned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants