diff --git a/eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml b/eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml index 760c78b2703f5..d0a77f3a4f042 100755 --- a/eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml +++ b/eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml @@ -45,7 +45,7 @@ - + @@ -53,25 +53,25 @@ UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD, NM_FIELD_NAMING_CONVENTION"/> - + - + - + - + @@ -1215,28 +1215,28 @@ - + - + - + - + @@ -2010,7 +2010,7 @@ - + @@ -2022,14 +2022,14 @@ RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE"/> - - + + - + diff --git a/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsynReadWithMultipleClients.java b/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsynReadWithMultipleClients.java index b8afa8291bf0e..584bd8a16d550 100644 --- a/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsynReadWithMultipleClients.java +++ b/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsynReadWithMultipleClients.java @@ -9,7 +9,7 @@ import com.azure.cosmos.CosmosAsyncContainer; import com.azure.cosmos.CosmosAsyncDatabase; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.DirectConnectionConfig; import com.azure.cosmos.GatewayConnectionConfig; import com.azure.cosmos.implementation.HttpConstants; @@ -243,7 +243,7 @@ private void createClients() { boolean databaseCreated = false; try { cosmosAsyncDatabase = asyncClient.getDatabase(this.configuration.getDatabaseId()).read().block().getDatabase(); - } catch (CosmosClientException e) { + } catch (CosmosException e) { if (e.getStatusCode() == HttpConstants.StatusCodes.NOTFOUND) { cosmosAsyncDatabase = asyncClient.createDatabase(this.configuration.getDatabaseId()).block().getDatabase(); logger.info("Database {} is created for this test on host {}", this.configuration.getDatabaseId(), endpoint); @@ -256,7 +256,7 @@ private void createClients() { try { cosmosAsyncContainer = cosmosAsyncDatabase.getContainer(this.configuration.getCollectionId()).read().block().getContainer(); - } catch (CosmosClientException e) { + } catch (CosmosException e) { if (e.getStatusCode() == HttpConstants.StatusCodes.NOTFOUND) { cosmosAsyncContainer = cosmosAsyncDatabase.createContainer(this.configuration.getCollectionId(), Configuration.DEFAULT_PARTITION_KEY_PATH, this.configuration.getThroughput()).block().getContainer(); diff --git a/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsyncBenchmark.java b/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsyncBenchmark.java index 1d134618162b3..61829e49a1bd3 100644 --- a/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsyncBenchmark.java +++ b/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsyncBenchmark.java @@ -9,7 +9,7 @@ import com.azure.cosmos.CosmosAsyncContainer; import com.azure.cosmos.CosmosAsyncDatabase; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.DirectConnectionConfig; import com.azure.cosmos.GatewayConnectionConfig; import com.azure.cosmos.implementation.HttpConstants; @@ -87,7 +87,7 @@ abstract class AsyncBenchmark { ).read().doOnError(error -> logger.error("Database {} creation failed due to ", this.configuration.getDatabaseId(), error) ).block().getDatabase(); - } catch (CosmosClientException e) { + } catch (CosmosException e) { if (e.getStatusCode() == HttpConstants.StatusCodes.NOTFOUND) { cosmosAsyncDatabase = cosmosClient.createDatabase(cfg.getDatabaseId()).block().getDatabase(); logger.info("Database {} is created for this test", this.configuration.getDatabaseId()); @@ -103,7 +103,7 @@ abstract class AsyncBenchmark { ).read().doOnError(error -> logger.error("Database {} creation failed due to ", this.configuration.getDatabaseId(), error) ).block().getContainer(); - } catch (CosmosClientException e) { + } catch (CosmosException e) { if (e.getStatusCode() == HttpConstants.StatusCodes.NOTFOUND) { cosmosAsyncContainer = cosmosAsyncDatabase.createContainer( this.configuration.getCollectionId(), diff --git a/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/SyncBenchmark.java b/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/SyncBenchmark.java index cebeb28fdc298..b117b215017b4 100644 --- a/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/SyncBenchmark.java +++ b/sdk/cosmos/azure-cosmos-benchmark/src/main/java/com/azure/cosmos/benchmark/SyncBenchmark.java @@ -7,7 +7,7 @@ import com.azure.cosmos.ConnectionMode; import com.azure.cosmos.CosmosClient; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.CosmosContainer; import com.azure.cosmos.CosmosDatabase; import com.azure.cosmos.DirectConnectionConfig; @@ -120,7 +120,7 @@ public T apply(T o, Throwable throwable) { try { cosmosDatabase = cosmosClient.getDatabase(this.configuration.getDatabaseId()).read().getDatabase(); logger.info("Database {} is created for this test", this.configuration.getDatabaseId()); - } catch (CosmosClientException e) { + } catch (CosmosException e) { if (e.getStatusCode() == HttpConstants.StatusCodes.NOTFOUND) { cosmosDatabase = cosmosClient.createDatabase(cfg.getDatabaseId()).getDatabase(); databaseCreated = true; @@ -131,7 +131,7 @@ public T apply(T o, Throwable throwable) { try { cosmosContainer = cosmosDatabase.getContainer(this.configuration.getCollectionId()).read().getContainer(); - } catch (CosmosClientException e) { + } catch (CosmosException e) { if (e.getStatusCode() == HttpConstants.StatusCodes.NOTFOUND) { cosmosContainer = cosmosDatabase.createContainer(this.configuration.getCollectionId(), Configuration.DEFAULT_PARTITION_KEY_PATH, this.configuration.getThroughput()).getContainer(); logger.info("Collection {} is created for this test", this.configuration.getCollectionId()); diff --git a/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/examples/BasicDemo.java b/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/examples/BasicDemo.java index eb5901f2b55f1..8075d2f299f76 100644 --- a/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/examples/BasicDemo.java +++ b/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/examples/BasicDemo.java @@ -7,7 +7,7 @@ import com.azure.cosmos.CosmosAsyncDatabase; import com.azure.cosmos.models.CosmosAsyncItemResponse; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.CosmosContainerProperties; import com.azure.cosmos.util.CosmosPagedFlux; import com.azure.cosmos.models.FeedOptions; @@ -146,8 +146,8 @@ private void log(Object object) { } private void log(String msg, Throwable throwable) { - if (throwable instanceof CosmosClientException) { - log(msg + ": " + ((CosmosClientException) throwable).getStatusCode()); + if (throwable instanceof CosmosException) { + log(msg + ": " + ((CosmosException) throwable).getStatusCode()); } } diff --git a/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/examples/ChangeFeed/SampleChangeFeedProcessor.java b/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/examples/ChangeFeed/SampleChangeFeedProcessor.java index b8ecca22057d7..a06e2630c45f3 100644 --- a/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/examples/ChangeFeed/SampleChangeFeedProcessor.java +++ b/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/examples/ChangeFeed/SampleChangeFeedProcessor.java @@ -9,7 +9,7 @@ import com.azure.cosmos.models.CosmosAsyncContainerResponse; import com.azure.cosmos.CosmosAsyncDatabase; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.CosmosContainerProperties; import com.azure.cosmos.models.CosmosContainerRequestOptions; import com.azure.cosmos.implementation.CosmosItemProperties; @@ -145,10 +145,10 @@ public static CosmosAsyncContainer createNewCollection(CosmosAsyncClient client, throw new IllegalArgumentException(String.format("Collection %s already exists in database %s.", collectionName, databaseName)); } } catch (RuntimeException ex) { - if (ex instanceof CosmosClientException) { - CosmosClientException cosmosClientException = (CosmosClientException) ex; + if (ex instanceof CosmosException) { + CosmosException cosmosException = (CosmosException) ex; - if (cosmosClientException.getStatusCode() != 404) { + if (cosmosException.getStatusCode() != 404) { throw ex; } } else { @@ -187,10 +187,10 @@ public static CosmosAsyncContainer createNewLeaseCollection(CosmosAsyncClient cl } } } catch (RuntimeException ex) { - if (ex instanceof CosmosClientException) { - CosmosClientException cosmosClientException = (CosmosClientException) ex; + if (ex instanceof CosmosException) { + CosmosException cosmosException = (CosmosException) ex; - if (cosmosClientException.getStatusCode() != 404) { + if (cosmosException.getStatusCode() != 404) { throw ex; } } else { diff --git a/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/Helpers.java b/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/Helpers.java index 0f7748aac4be9..aac1a3b4a456e 100644 --- a/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/Helpers.java +++ b/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/Helpers.java @@ -4,11 +4,10 @@ package com.azure.cosmos.rx.examples.multimaster; import com.azure.cosmos.implementation.AsyncDocumentClient; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.Database; import com.azure.cosmos.implementation.DocumentCollection; import com.azure.cosmos.implementation.ResourceResponse; -import reactor.core.publisher.Flux; import reactor.core.publisher.Mono; public class Helpers { @@ -26,8 +25,8 @@ static public Mono createDatabaseIfNotExists(AsyncDocumentClient clien return client.readDatabase("/dbs/" + databaseName, null) .onErrorResume( e -> { - if (e instanceof CosmosClientException) { - CosmosClientException dce = (CosmosClientException) e; + if (e instanceof CosmosException) { + CosmosException dce = (CosmosException) e; if (dce.getStatusCode() == 404) { // if doesn't exist create it @@ -47,8 +46,8 @@ static public Mono createCollectionIfNotExists(AsyncDocument return client.readCollection(createDocumentCollectionUri(databaseName, collectionName), null) .onErrorResume( e -> { - if (e instanceof CosmosClientException) { - CosmosClientException dce = (CosmosClientException) e; + if (e instanceof CosmosException) { + CosmosException dce = (CosmosException) e; if (dce.getStatusCode() == 404) { // if doesn't exist create it @@ -68,8 +67,8 @@ static public Mono createCollectionIfNotExists(AsyncDocument return client.readCollection(createDocumentCollectionUri(databaseName, collection.getId()), null) .onErrorResume( e -> { - if (e instanceof CosmosClientException) { - CosmosClientException dce = (CosmosClientException) e; + if (e instanceof CosmosException) { + CosmosException dce = (CosmosException) e; if (dce.getStatusCode() == 404) { // if doesn't exist create it diff --git a/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/samples/ConflictWorker.java b/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/samples/ConflictWorker.java index 8f708ec9e3a14..7a896476392fd 100644 --- a/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/samples/ConflictWorker.java +++ b/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/samples/ConflictWorker.java @@ -5,7 +5,7 @@ import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.models.ConflictResolutionPolicy; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.FeedResponse; import com.azure.cosmos.implementation.Resource; import com.azure.cosmos.implementation.AsyncDocumentClient; @@ -491,8 +491,8 @@ private Mono tryInsertDocument(AsyncDocumentClient client, String coll } private boolean hasDocumentClientException(Throwable e, int statusCode) { - if (e instanceof CosmosClientException) { - CosmosClientException dce = (CosmosClientException) e; + if (e instanceof CosmosException) { + CosmosException dce = (CosmosException) e; return dce.getStatusCode() == statusCode; } @@ -501,7 +501,7 @@ private boolean hasDocumentClientException(Throwable e, int statusCode) { private boolean hasDocumentClientExceptionCause(Throwable e) { while (e != null) { - if (e instanceof CosmosClientException) { + if (e instanceof CosmosException) { return true; } @@ -512,8 +512,8 @@ private boolean hasDocumentClientExceptionCause(Throwable e) { private boolean hasDocumentClientExceptionCause(Throwable e, int statusCode) { while (e != null) { - if (e instanceof CosmosClientException) { - CosmosClientException dce = (CosmosClientException) e; + if (e instanceof CosmosException) { + CosmosException dce = (CosmosException) e; return dce.getStatusCode() == statusCode; } diff --git a/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/samples/Worker.java b/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/samples/Worker.java index aaecb81717b14..0b97eed015878 100644 --- a/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/samples/Worker.java +++ b/sdk/cosmos/azure-cosmos-examples/src/main/java/com/azure/cosmos/rx/examples/multimaster/samples/Worker.java @@ -5,7 +5,7 @@ import com.azure.cosmos.implementation.AsyncDocumentClient; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.Document; import com.azure.cosmos.models.FeedOptions; import com.azure.cosmos.models.FeedResponse; @@ -136,7 +136,7 @@ void deleteAll() { this.client.deleteDocument(document.getSelfLink(), null) .subscribeOn(schedulerForBlockingWork).single().block(); } catch (RuntimeException exEx) { - CosmosClientException dce = getDocumentClientExceptionCause(exEx); + CosmosException dce = getDocumentClientExceptionCause(exEx); if (dce.getStatusCode() != 404) { logger.info("Error occurred while deleting {} from {}", dce, client.getWriteEndpoint()); @@ -147,11 +147,11 @@ void deleteAll() { logger.info("Deleted all documents from region {}", this.client.getWriteEndpoint()); } - private CosmosClientException getDocumentClientExceptionCause(Throwable e) { + private CosmosException getDocumentClientExceptionCause(Throwable e) { while (e != null) { - if (e instanceof CosmosClientException) { - return (CosmosClientException) e; + if (e instanceof CosmosException) { + return (CosmosException) e; } e = e.getCause(); diff --git a/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/CollectionCRUDAsyncAPITest.java b/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/CollectionCRUDAsyncAPITest.java index 817c3e927a5ef..1d40f78629d62 100644 --- a/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/CollectionCRUDAsyncAPITest.java +++ b/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/CollectionCRUDAsyncAPITest.java @@ -2,19 +2,16 @@ // Licensed under the MIT License. package com.azure.cosmos.rx.examples; -import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.ConnectionMode; import com.azure.cosmos.DirectConnectionConfig; import com.azure.cosmos.implementation.ConnectionPolicy; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.DataType; import com.azure.cosmos.DocumentClientTest; import com.azure.cosmos.models.FeedResponse; import com.azure.cosmos.models.IncludedPath; import com.azure.cosmos.models.Index; import com.azure.cosmos.models.IndexingPolicy; -import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.models.PartitionKeyDefinition; import com.azure.cosmos.implementation.AsyncDocumentClient; import com.azure.cosmos.implementation.Database; @@ -30,7 +27,6 @@ import reactor.core.publisher.Mono; import java.util.ArrayList; -import java.util.Collection; import java.util.List; import java.util.UUID; import java.util.concurrent.CompletableFuture; @@ -236,7 +232,7 @@ public void createCollection_toBlocking_CollectionAlreadyExists_Fails() { collectionForTestObservable.single() // Gets the single result .block(); // Blocks assertThat("Should not reach here", false); - } catch (CosmosClientException e) { + } catch (CosmosException e) { assertThat("Collection already exists.", e.getStatusCode(), equalTo(409)); } diff --git a/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/DatabaseCRUDAsyncAPITest.java b/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/DatabaseCRUDAsyncAPITest.java index f8a4304d705af..4a76984148ab8 100644 --- a/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/DatabaseCRUDAsyncAPITest.java +++ b/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/DatabaseCRUDAsyncAPITest.java @@ -2,11 +2,10 @@ // Licensed under the MIT License. package com.azure.cosmos.rx.examples; -import com.azure.cosmos.ConnectionMode; import com.azure.cosmos.DirectConnectionConfig; import com.azure.cosmos.implementation.ConnectionPolicy; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.DocumentClientTest; import com.azure.cosmos.models.FeedResponse; import com.azure.cosmos.implementation.AsyncDocumentClient; @@ -183,7 +182,7 @@ public void createDatabase_toBlocking_DatabaseAlreadyExists_Fails() { databaseForTestObservable.single() // Single .block(); // Blocks to get the result assertThat("Should not reach here", false); - } catch (CosmosClientException e) { + } catch (CosmosException e) { assertThat("Database already exists.", e.getStatusCode(), equalTo(409)); } diff --git a/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/DocumentCRUDAsyncAPITest.java b/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/DocumentCRUDAsyncAPITest.java index 527556feddc37..1c18a98a17151 100644 --- a/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/DocumentCRUDAsyncAPITest.java +++ b/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/DocumentCRUDAsyncAPITest.java @@ -3,11 +3,10 @@ package com.azure.cosmos.rx.examples; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.ConnectionMode; import com.azure.cosmos.DirectConnectionConfig; import com.azure.cosmos.implementation.ConnectionPolicy; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.DocumentClientTest; import com.azure.cosmos.models.FeedOptions; import com.azure.cosmos.models.FeedResponse; @@ -294,7 +293,7 @@ public void createDocument_toBlocking_DocumentAlreadyExists_Fails() { createDocumentObservable.single() // Converts the observable to a single observable .block(); // Blocks and gets the result Assert.fail("Document Already Exists. Document Creation must fail"); - } catch (CosmosClientException e) { + } catch (CosmosException e) { assertThat("Document already exists.", e.getStatusCode(), equalTo(409)); } @@ -327,8 +326,8 @@ public void createDocument_Async_DocumentAlreadyExists_Fails() throws Exception waitForConditionOrTimeout(() -> errorList.size() == 1); assertThat(errorList, hasSize(1)); - assertThat(errorList.get(0), is(instanceOf(CosmosClientException.class))); - assertThat(((CosmosClientException) errorList.get(0)).getStatusCode(), equalTo(409)); + assertThat(errorList.get(0), is(instanceOf(CosmosException.class))); + assertThat(((CosmosException) errorList.get(0)).getStatusCode(), equalTo(409)); } /** diff --git a/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/UniqueIndexAsyncAPITest.java b/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/UniqueIndexAsyncAPITest.java index 27e80bdc21990..6f739115bb1e3 100644 --- a/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/UniqueIndexAsyncAPITest.java +++ b/sdk/cosmos/azure-cosmos-examples/src/test/java/com/azure/cosmos/rx/examples/UniqueIndexAsyncAPITest.java @@ -2,11 +2,10 @@ // Licensed under the MIT License. package com.azure.cosmos.rx.examples; -import com.azure.cosmos.ConnectionMode; import com.azure.cosmos.DirectConnectionConfig; import com.azure.cosmos.implementation.ConnectionPolicy; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.DocumentClientTest; import com.azure.cosmos.models.PartitionKeyDefinition; import com.azure.cosmos.models.UniqueKey; @@ -76,11 +75,11 @@ public void uniqueIndex() { docCreation.subscribe(subscriber); subscriber.awaitTerminalEvent(); - subscriber.assertError(CosmosClientException.class); + subscriber.assertError(CosmosException.class); assertThat(subscriber.errorCount(), Matchers.equalTo(1)); // error code for failure is conflict - assertThat(((CosmosClientException) subscriber.getEvents().get(1).get(0)).getStatusCode(), equalTo(409)); + assertThat(((CosmosException) subscriber.getEvents().get(1).get(0)).getStatusCode(), equalTo(409)); } @BeforeClass(groups = "samples", timeOut = TIMEOUT) diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/BridgeInternal.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/BridgeInternal.java index 01a2975d0feb7..27dc71a185c73 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/BridgeInternal.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/BridgeInternal.java @@ -27,7 +27,7 @@ import com.azure.cosmos.implementation.query.metrics.ClientSideMetrics; import com.azure.cosmos.implementation.routing.PartitionKeyInternal; import com.azure.cosmos.models.CosmosAsyncItemResponse; -import com.azure.cosmos.models.CosmosError; +import com.azure.cosmos.implementation.CosmosError; import com.azure.cosmos.models.CosmosItemResponse; import com.azure.cosmos.models.CosmosStoredProcedureProperties; import com.azure.cosmos.models.FeedResponse; @@ -125,34 +125,34 @@ public static CosmosDiagnostics createCosmosDiagnostics(Map E setResourceAddress(E e, String resourceAddress) { + public static E setResourceAddress(E e, String resourceAddress) { e.setResourceAddress(resourceAddress); return e; } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static long getLSN(E e) { + public static long getLSN(E e) { return e.lsn; } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static String getPartitionKeyRangeId(E e) { + public static String getPartitionKeyRangeId(E e) { return e.partitionKeyRangeId; } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static String getResourceAddress(E e) { + public static String getResourceAddress(E e) { return e.getResourceAddress(); } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static E setLSN(E e, long lsn) { + public static E setLSN(E e, long lsn) { e.lsn = lsn; return e; } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static E setPartitionKeyRangeId(E e, String partitionKeyRangeId) { + public static E setPartitionKeyRangeId(E e, String partitionKeyRangeId) { e.partitionKeyRangeId = partitionKeyRangeId; return e; } @@ -163,20 +163,20 @@ public static boolean isEnableMultipleWriteLocations(DatabaseAccount account) { } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static Uri getRequestUri(CosmosClientException cosmosClientException) { - return cosmosClientException.requestUri; + public static Uri getRequestUri(CosmosException cosmosException) { + return cosmosException.requestUri; } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static void setRequestHeaders(CosmosClientException cosmosClientException, - Map requestHeaders) { - cosmosClientException.requestHeaders = requestHeaders; + public static void setRequestHeaders(CosmosException cosmosException, + Map requestHeaders) { + cosmosException.requestHeaders = requestHeaders; } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static Map getRequestHeaders( - CosmosClientException cosmosClientException) { - return cosmosClientException.requestHeaders; + public static Map getRequestHeaders( + CosmosException cosmosException) { + return cosmosException.requestHeaders; } @Warning(value = INTERNAL_USE_ONLY_WARNING) @@ -218,11 +218,11 @@ public static ClientSideMetrics getClientSideMetrics(QueryMetrics queryMetrics) } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static String getInnerErrorMessage(CosmosClientException cosmosClientException) { - if (cosmosClientException == null) { + public static String getInnerErrorMessage(CosmosException cosmosException) { + if (cosmosException == null) { return null; } - return cosmosClientException.innerErrorMessage(); + return cosmosException.innerErrorMessage(); } @Warning(value = INTERNAL_USE_ONLY_WARNING) @@ -256,59 +256,63 @@ public static Object getValue(JsonNode value) { } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static CosmosClientException setCosmosDiagnostics( - CosmosClientException cosmosClientException, + public static CosmosException setCosmosDiagnostics( + CosmosException cosmosException, CosmosDiagnostics cosmosDiagnostics) { - return cosmosClientException.setDiagnostics(cosmosDiagnostics); + return cosmosException.setDiagnostics(cosmosDiagnostics); } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static CosmosClientException createCosmosClientException(int statusCode) { - return new CosmosClientException(statusCode, null, null, null); + public static CosmosException createCosmosException(int statusCode) { + return new CosmosException(statusCode, null, null, null); } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static CosmosClientException createCosmosClientException(int statusCode, String errorMessage) { - CosmosClientException cosmosClientException = new CosmosClientException(statusCode, errorMessage, null, null); - cosmosClientException.setError(new CosmosError()); - ModelBridgeInternal.setProperty( - ModelBridgeInternal.getJsonSerializable(cosmosClientException.getError()), Constants.Properties.MESSAGE, errorMessage); - return cosmosClientException; + public static CosmosException createCosmosException(int statusCode, String errorMessage) { + CosmosException cosmosException = new CosmosException(statusCode, errorMessage, null, null); + cosmosException.setError(new CosmosError()); + ModelBridgeInternal.setProperty(cosmosException.getError(), Constants.Properties.MESSAGE, errorMessage); + return cosmosException; } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static CosmosClientException createCosmosClientException(int statusCode, Exception innerException) { - return new CosmosClientException(statusCode, null, null, innerException); + public static CosmosException createCosmosException(int statusCode, Exception innerException) { + return new CosmosException(statusCode, null, null, innerException); } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static CosmosClientException createCosmosClientException(int statusCode, CosmosError cosmosErrorResource, - Map responseHeaders) { - return new CosmosClientException(/* resourceAddress */ null, statusCode, cosmosErrorResource, responseHeaders); + public static CosmosException createCosmosException(int statusCode, CosmosError cosmosErrorResource, + Map responseHeaders) { + return new CosmosException(/* resourceAddress */ null, statusCode, cosmosErrorResource, responseHeaders); } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static CosmosClientException createCosmosClientException(String resourceAddress, - int statusCode, - CosmosError cosmosErrorResource, - Map responseHeaders) { - CosmosClientException cosmosClientException = new CosmosClientException(statusCode, + public static CosmosException createCosmosException(String resourceAddress, + int statusCode, + CosmosError cosmosErrorResource, + Map responseHeaders) { + CosmosException cosmosException = new CosmosException(statusCode, cosmosErrorResource == null ? null : cosmosErrorResource.getMessage(), responseHeaders, null); - cosmosClientException.setResourceAddress(resourceAddress); - cosmosClientException.setError(cosmosErrorResource); - return cosmosClientException; + cosmosException.setResourceAddress(resourceAddress); + cosmosException.setError(cosmosErrorResource); + return cosmosException; } @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static CosmosClientException createCosmosClientException(String message, - Exception exception, - Map responseHeaders, - int statusCode, - String resourceAddress) { - CosmosClientException cosmosClientException = new CosmosClientException(statusCode, message, responseHeaders, + public static CosmosError getCosmosError(CosmosException cosmosException) { + return cosmosException == null ? null : cosmosException.getError(); + } + + @Warning(value = INTERNAL_USE_ONLY_WARNING) + public static CosmosException createCosmosException(String message, + Exception exception, + Map responseHeaders, + int statusCode, + String resourceAddress) { + CosmosException cosmosException = new CosmosException(statusCode, message, responseHeaders, exception); - cosmosClientException.setResourceAddress(resourceAddress); - return cosmosClientException; + cosmosException.setResourceAddress(resourceAddress); + return cosmosException; } @Warning(value = INTERNAL_USE_ONLY_WARNING) @@ -386,7 +390,7 @@ public static SerializationDiagnosticsContext getSerializationDiagnosticsContext public static void recordGatewayResponse(CosmosDiagnostics cosmosDiagnostics, RxDocumentServiceRequest rxDocumentServiceRequest, StoreResponse storeResponse, - CosmosClientException exception) { + CosmosException exception) { cosmosDiagnostics.clientSideRequestStatistics().recordGatewayResponse(rxDocumentServiceRequest, storeResponse, exception); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/ClientSideRequestStatistics.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/ClientSideRequestStatistics.java index 91c4552020f23..7ccd1c51c72a4 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/ClientSideRequestStatistics.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/ClientSideRequestStatistics.java @@ -120,7 +120,7 @@ void recordResponse(RxDocumentServiceRequest request, StoreResult storeResult) { void recordGatewayResponse( RxDocumentServiceRequest rxDocumentServiceRequest, StoreResponse storeResponse, - CosmosClientException exception) { + CosmosException exception) { ZonedDateTime responseTime = ZonedDateTime.now(ZoneOffset.UTC); connectionMode = ConnectionMode.GATEWAY; synchronized (this) { diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncClient.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncClient.java index 3b1fbdc89b8d3..42808d6a210b5 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncClient.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncClient.java @@ -214,9 +214,9 @@ public Mono createDatabaseIfNotExists(String id) { private Mono createDatabaseIfNotExistsInternal(CosmosAsyncDatabase database) { return database.read().onErrorResume(exception -> { final Throwable unwrappedException = Exceptions.unwrap(exception); - if (unwrappedException instanceof CosmosClientException) { - final CosmosClientException cosmosClientException = (CosmosClientException) unwrappedException; - if (cosmosClientException.getStatusCode() == HttpConstants.StatusCodes.NOTFOUND) { + if (unwrappedException instanceof CosmosException) { + final CosmosException cosmosException = (CosmosException) unwrappedException; + if (cosmosException.getStatusCode() == HttpConstants.StatusCodes.NOTFOUND) { return createDatabase(new CosmosDatabaseProperties(database.getId()), new CosmosDatabaseRequestOptions()); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncContainer.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncContainer.java index edcedc2a96b07..04dc1beebe502 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncContainer.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncContainer.java @@ -625,7 +625,7 @@ public Mono readProvisionedThroughput() { .flatMap(offerFeedResponse -> { if (offerFeedResponse.getResults().isEmpty()) { return Mono.error( - BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.BADREQUEST, + BridgeInternal.createCosmosException(HttpConstants.StatusCodes.BADREQUEST, "No offers found for the resource")); } return database.getDocClientWrapper() @@ -653,7 +653,7 @@ public Mono replaceProvisionedThroughput(int requestUnitsPerSecond) { .flatMap(offerFeedResponse -> { if (offerFeedResponse.getResults().isEmpty()) { return Mono.error( - BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.BADREQUEST, + BridgeInternal.createCosmosException(HttpConstants.StatusCodes.BADREQUEST, "No offers found for the resource")); } Offer offer = offerFeedResponse.getResults().get(0); @@ -678,7 +678,7 @@ public Mono replaceThroughput(ThroughputProperties throughpu .flatMap(offerFeedResponse -> { if (offerFeedResponse.getResults().isEmpty()) { return Mono.error(BridgeInternal - .createCosmosClientException( + .createCosmosException( HttpConstants.StatusCodes.BADREQUEST, "No offers found for the " + "resource " + this.getId())); @@ -709,7 +709,7 @@ public Mono readThroughput() { .flatMap(offerFeedResponse -> { if (offerFeedResponse.getResults().isEmpty()) { return Mono.error(BridgeInternal - .createCosmosClientException( + .createCosmosException( HttpConstants.StatusCodes.BADREQUEST, "No offers found for the resource " + this.getId())); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncDatabase.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncDatabase.java index 02fe794ec9dd5..d58196c99a18a 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncDatabase.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncDatabase.java @@ -350,9 +350,9 @@ private Mono createContainerIfNotExistsInternal( CosmosContainerRequestOptions options) { return container.read(options).onErrorResume(exception -> { final Throwable unwrappedException = Exceptions.unwrap(exception); - if (unwrappedException instanceof CosmosClientException) { - final CosmosClientException cosmosClientException = (CosmosClientException) unwrappedException; - if (cosmosClientException.getStatusCode() == HttpConstants.StatusCodes.NOTFOUND) { + if (unwrappedException instanceof CosmosException) { + final CosmosException cosmosException = (CosmosException) unwrappedException; + if (cosmosException.getStatusCode() == HttpConstants.StatusCodes.NOTFOUND) { return createContainer(containerProperties, options); } } @@ -636,7 +636,7 @@ public Mono readProvisionedThroughput() { .flatMap(offerFeedResponse -> { if (offerFeedResponse.getResults().isEmpty()) { return Mono.error(BridgeInternal - .createCosmosClientException( + .createCosmosException( HttpConstants.StatusCodes.BADREQUEST, "No offers found for the resource")); } @@ -669,7 +669,7 @@ public Mono replaceProvisionedThroughput(int requestUnitsPerSecond) { .flatMap(offerFeedResponse -> { if (offerFeedResponse.getResults().isEmpty()) { return Mono.error(BridgeInternal - .createCosmosClientException( + .createCosmosException( HttpConstants.StatusCodes.BADREQUEST, "No offers found for the resource")); } @@ -698,7 +698,7 @@ public Mono replaceThroughput(ThroughputProperties throughpu .flatMap(offerFeedResponse -> { if (offerFeedResponse.getResults().isEmpty()) { return Mono.error(BridgeInternal - .createCosmosClientException( + .createCosmosException( HttpConstants.StatusCodes.BADREQUEST, "No offers found for the " + "resource " + this.getId())); @@ -730,7 +730,7 @@ public Mono readThroughput() { .flatMap(offerFeedResponse -> { if (offerFeedResponse.getResults().isEmpty()) { return Mono.error(BridgeInternal - .createCosmosClientException( + .createCosmosException( HttpConstants.StatusCodes.BADREQUEST, "No offers found for the " + "resource " + this.getId())); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClient.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClient.java index 5c31c5db9c43e..55fc2d4364ed5 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClient.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClient.java @@ -36,10 +36,8 @@ public final class CosmosClient implements Closeable { * * @param databaseProperties {@link CosmosDatabaseProperties} the database properties * @return the {@link CosmosDatabaseResponse} with the created database. - * @throws CosmosClientException the cosmos client exception. */ - public CosmosDatabaseResponse createDatabaseIfNotExists(CosmosDatabaseProperties databaseProperties) throws - CosmosClientException { + public CosmosDatabaseResponse createDatabaseIfNotExists(CosmosDatabaseProperties databaseProperties) { return mapDatabaseResponseAndBlock(asyncClientWrapper.createDatabaseIfNotExists(databaseProperties)); } @@ -48,9 +46,8 @@ public CosmosDatabaseResponse createDatabaseIfNotExists(CosmosDatabaseProperties * * @param id the id of the database * @return the {@link CosmosDatabaseResponse} with the created database. - * @throws CosmosClientException the cosmos client exception. */ - public CosmosDatabaseResponse createDatabaseIfNotExists(String id) throws CosmosClientException { + public CosmosDatabaseResponse createDatabaseIfNotExists(String id) { return mapDatabaseResponseAndBlock(asyncClientWrapper.createDatabaseIfNotExists(id)); } @@ -61,10 +58,9 @@ public CosmosDatabaseResponse createDatabaseIfNotExists(String id) throws Cosmos * @param databaseProperties {@link CosmosDatabaseProperties} the database properties. * @param options the request options. * @return the {@link CosmosDatabaseResponse} with the created database. - * @throws CosmosClientException the cosmos client exception. */ public CosmosDatabaseResponse createDatabase(CosmosDatabaseProperties databaseProperties, - CosmosDatabaseRequestOptions options) throws CosmosClientException { + CosmosDatabaseRequestOptions options) { return mapDatabaseResponseAndBlock(asyncClientWrapper.createDatabase(databaseProperties, options)); } @@ -73,10 +69,8 @@ public CosmosDatabaseResponse createDatabase(CosmosDatabaseProperties databasePr * * @param databaseProperties {@link CosmosDatabaseProperties} the database properties. * @return the {@link CosmosDatabaseResponse} with the created database. - * @throws CosmosClientException the cosmos client exception. */ - public CosmosDatabaseResponse createDatabase(CosmosDatabaseProperties databaseProperties) throws - CosmosClientException { + public CosmosDatabaseResponse createDatabase(CosmosDatabaseProperties databaseProperties) { return mapDatabaseResponseAndBlock(asyncClientWrapper.createDatabase(databaseProperties)); } @@ -85,9 +79,8 @@ public CosmosDatabaseResponse createDatabase(CosmosDatabaseProperties databasePr * * @param id the id of the database * @return the {@link CosmosDatabaseResponse} with the created database. - * @throws CosmosClientException the cosmos client exception. */ - public CosmosDatabaseResponse createDatabase(String id) throws CosmosClientException { + public CosmosDatabaseResponse createDatabase(String id) { return mapDatabaseResponseAndBlock(asyncClientWrapper.createDatabase(id)); } @@ -99,11 +92,10 @@ public CosmosDatabaseResponse createDatabase(String id) throws CosmosClientExcep * @param throughput the throughput * @param options {@link CosmosDatabaseRequestOptions} the request options * @return the {@link CosmosDatabaseResponse} with the created database. - * @throws CosmosClientException the cosmos client exception */ public CosmosDatabaseResponse createDatabase(CosmosDatabaseProperties databaseProperties, int throughput, - CosmosDatabaseRequestOptions options) throws CosmosClientException { + CosmosDatabaseRequestOptions options) { return mapDatabaseResponseAndBlock(asyncClientWrapper.createDatabase(databaseProperties, throughput, options)); } @@ -113,10 +105,9 @@ public CosmosDatabaseResponse createDatabase(CosmosDatabaseProperties databasePr * @param databaseProperties {@link CosmosDatabaseProperties} the database properties. * @param throughput the throughput * @return the {@link CosmosDatabaseResponse} with the created database. - * @throws CosmosClientException the cosmos client exception */ public CosmosDatabaseResponse createDatabase(CosmosDatabaseProperties databaseProperties, - int throughput) throws CosmosClientException { + int throughput) { return mapDatabaseResponseAndBlock(asyncClientWrapper.createDatabase(databaseProperties, throughput)); } @@ -127,22 +118,20 @@ public CosmosDatabaseResponse createDatabase(CosmosDatabaseProperties databasePr * @param id the id of the database * @param throughput the throughput * @return the {@link CosmosDatabaseResponse} with the created database. - * @throws CosmosClientException the cosmos client exception */ - public CosmosDatabaseResponse createDatabase(String id, int throughput) throws CosmosClientException { + public CosmosDatabaseResponse createDatabase(String id, int throughput) { return mapDatabaseResponseAndBlock(asyncClientWrapper.createDatabase(id, throughput)); } - CosmosDatabaseResponse mapDatabaseResponseAndBlock(Mono databaseMono) throws - CosmosClientException { + CosmosDatabaseResponse mapDatabaseResponseAndBlock(Mono databaseMono) { try { return databaseMono .map(this::convertResponse) .block(); } catch (Exception ex) { final Throwable throwable = Exceptions.unwrap(ex); - if (throwable instanceof CosmosClientException) { - throw (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + throw (CosmosException) throwable; } else { throw Exceptions.propagate(ex); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosContainer.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosContainer.java index 06002438b3371..0a76b9027dbaf 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosContainer.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosContainer.java @@ -58,9 +58,8 @@ public String getId() { * Read cosmos sync container response. * * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ - public CosmosContainerResponse read() throws CosmosClientException { + public CosmosContainerResponse read() { return database.mapContainerResponseAndBlock(this.asyncContainer.read()); } @@ -69,9 +68,8 @@ public CosmosContainerResponse read() throws CosmosClientException { * * @param options the options * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ - public CosmosContainerResponse read(CosmosContainerRequestOptions options) throws CosmosClientException { + public CosmosContainerResponse read(CosmosContainerRequestOptions options) { return database.mapContainerResponseAndBlock(this.asyncContainer.read(options)); } @@ -80,9 +78,8 @@ public CosmosContainerResponse read(CosmosContainerRequestOptions options) throw * * @param options the options * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ - public CosmosContainerResponse delete(CosmosContainerRequestOptions options) throws CosmosClientException { + public CosmosContainerResponse delete(CosmosContainerRequestOptions options) { return database.mapContainerResponseAndBlock(this.asyncContainer.delete(options)); } @@ -90,9 +87,8 @@ public CosmosContainerResponse delete(CosmosContainerRequestOptions options) thr * Delete cosmos sync container response. * * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ - public CosmosContainerResponse delete() throws CosmosClientException { + public CosmosContainerResponse delete() { return database.mapContainerResponseAndBlock(this.asyncContainer.delete()); } @@ -101,9 +97,8 @@ public CosmosContainerResponse delete() throws CosmosClientException { * * @param containerProperties the container properties * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ - public CosmosContainerResponse replace(CosmosContainerProperties containerProperties) throws CosmosClientException { + public CosmosContainerResponse replace(CosmosContainerProperties containerProperties) { return database.mapContainerResponseAndBlock(this.asyncContainer.replace(containerProperties)); } @@ -113,10 +108,9 @@ public CosmosContainerResponse replace(CosmosContainerProperties containerProper * @param containerProperties the container properties * @param options the options * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ public CosmosContainerResponse replace(CosmosContainerProperties containerProperties, - CosmosContainerRequestOptions options) throws CosmosClientException { + CosmosContainerRequestOptions options) { return database.mapContainerResponseAndBlock(this.asyncContainer.replace(containerProperties, options)); } @@ -124,9 +118,8 @@ public CosmosContainerResponse replace(CosmosContainerProperties containerProper * Read provisioned throughput integer. * * @return the integer. null response indicates database doesn't have any provisioned RUs - * @throws CosmosClientException the cosmos client exception */ - public Integer readProvisionedThroughput() throws CosmosClientException { + public Integer readProvisionedThroughput() { return database.throughputResponseToBlock(this.asyncContainer.readProvisionedThroughput()); } @@ -135,9 +128,8 @@ public Integer readProvisionedThroughput() throws CosmosClientException { * * @param requestUnitsPerSecond the request units per second * @return the integer - * @throws CosmosClientException the cosmos client exception */ - public Integer replaceProvisionedThroughput(int requestUnitsPerSecond) throws CosmosClientException { + public Integer replaceProvisionedThroughput(int requestUnitsPerSecond) { return database.throughputResponseToBlock(this.asyncContainer .replaceProvisionedThroughput(requestUnitsPerSecond)); } @@ -169,9 +161,8 @@ public ThroughputResponse readThroughput() { * @param the type parameter * @param item the item * @return the cosmos sync item response - * @throws CosmosClientException the cosmos client exception */ - public CosmosItemResponse createItem(T item) throws CosmosClientException { + public CosmosItemResponse createItem(T item) { return this.mapItemResponseAndBlock(this.asyncContainer.createItem(item)); } @@ -183,11 +174,10 @@ public CosmosItemResponse createItem(T item) throws CosmosClientException * @param partitionKey the partition key * @param options the options * @return the cosmos sync item response - * @throws CosmosClientException the cosmos client exception */ public CosmosItemResponse createItem(T item, PartitionKey partitionKey, - CosmosItemRequestOptions options) throws CosmosClientException { + CosmosItemRequestOptions options) { return this.mapItemResponseAndBlock(this.asyncContainer.createItem(item, partitionKey, options)); } @@ -198,10 +188,9 @@ public CosmosItemResponse createItem(T item, * @param item the item * @param options the options * @return the cosmos item response - * @throws CosmosClientException the cosmos client exception */ - public CosmosItemResponse createItem(T item, CosmosItemRequestOptions options) throws CosmosClientException { + public CosmosItemResponse createItem(T item, CosmosItemRequestOptions options) { return this.mapItemResponseAndBlock(this.asyncContainer.createItem(item, options)); } @@ -211,9 +200,8 @@ public CosmosItemResponse createItem(T item, CosmosItemRequestOptions opt * @param the type parameter * @param item the item * @return the cosmos sync item response - * @throws CosmosClientException the cosmos client exception */ - public CosmosItemResponse upsertItem(T item) throws CosmosClientException { + public CosmosItemResponse upsertItem(T item) { return this.mapItemResponseAndBlock(this.asyncContainer.upsertItem(item)); } @@ -224,12 +212,10 @@ public CosmosItemResponse upsertItem(T item) throws CosmosClientException * @param item the item * @param options the options * @return the cosmos sync item response - * @throws CosmosClientException the cosmos client exception */ @SuppressWarnings("unchecked") // Note: @kushagraThapar and @moderakh to ensure this casting is valid - public CosmosItemResponse upsertItem(Object item, CosmosItemRequestOptions options) throws - CosmosClientException { + public CosmosItemResponse upsertItem(Object item, CosmosItemRequestOptions options) { return (CosmosItemResponse) this.mapItemResponseAndBlock(this.asyncContainer.upsertItem(item, options)); } @@ -238,34 +224,31 @@ public CosmosItemResponse upsertItem(Object item, CosmosItemRequestOption * * @param itemMono the item mono * @return the cosmos sync item response - * @throws CosmosClientException the cosmos client exception */ - CosmosItemResponse mapItemResponseAndBlock(Mono> itemMono) throws - CosmosClientException { + CosmosItemResponse mapItemResponseAndBlock(Mono> itemMono) { try { return itemMono .map(this::convertResponse) .block(); } catch (Exception ex) { final Throwable throwable = Exceptions.unwrap(ex); - if (throwable instanceof CosmosClientException) { - throw (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + throw (CosmosException) throwable; } else { throw ex; } } } - private CosmosItemResponse mapDeleteItemResponseAndBlock(Mono> deleteItemMono) - throws CosmosClientException { + private CosmosItemResponse mapDeleteItemResponseAndBlock(Mono> deleteItemMono) { try { return deleteItemMono .map(this::convertResponse) .block(); } catch (Exception ex) { final Throwable throwable = Exceptions.unwrap(ex); - if (throwable instanceof CosmosClientException) { - throw (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + throw (CosmosException) throwable; } else { throw ex; } @@ -318,10 +301,8 @@ public CosmosPagedIterable queryItems(SqlQuerySpec querySpec, FeedOptions * @param partitionKey the partition key * @param itemType the class type of item * @return the cosmos sync item response - * @throws CosmosClientException the cosmos client exception */ - public CosmosItemResponse readItem(String itemId, PartitionKey partitionKey, Class itemType) throws - CosmosClientException { + public CosmosItemResponse readItem(String itemId, PartitionKey partitionKey, Class itemType) { return this.mapItemResponseAndBlock(asyncContainer.readItem(itemId, partitionKey, new CosmosItemRequestOptions(), @@ -337,11 +318,10 @@ public CosmosItemResponse readItem(String itemId, PartitionKey partitionK * @param options the options * @param itemType the class type of item * @return the cosmos sync item response - * @throws CosmosClientException the cosmos client exception */ public CosmosItemResponse readItem( String itemId, PartitionKey partitionKey, - CosmosItemRequestOptions options, Class itemType) throws CosmosClientException { + CosmosItemRequestOptions options, Class itemType) { return this.mapItemResponseAndBlock(asyncContainer.readItem(itemId, partitionKey, options, itemType)); } @@ -354,12 +334,11 @@ public CosmosItemResponse readItem( * @param partitionKey the partition key * @param options the options * @return the cosmos sync item response - * @throws CosmosClientException the cosmos client exception */ public CosmosItemResponse replaceItem(T item, String itemId, PartitionKey partitionKey, - CosmosItemRequestOptions options) throws CosmosClientException { + CosmosItemRequestOptions options) { return this.mapItemResponseAndBlock(asyncContainer.replaceItem(item, itemId, partitionKey, options)); } @@ -370,10 +349,9 @@ public CosmosItemResponse replaceItem(T item, * @param partitionKey the partition key * @param options the options * @return the cosmos sync item response - * @throws CosmosClientException the cosmos client exception */ public CosmosItemResponse deleteItem(String itemId, PartitionKey partitionKey, - CosmosItemRequestOptions options) throws CosmosClientException { + CosmosItemRequestOptions options) { return this.mapDeleteItemResponseAndBlock(asyncContainer.deleteItem(itemId, partitionKey, options)); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosDatabase.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosDatabase.java index cf9fd465ed70c..08dd1f6af8c89 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosDatabase.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosDatabase.java @@ -59,9 +59,8 @@ public String getId() { * Reads a database * * @return the {@link CosmosDatabaseResponse} - * @throws CosmosClientException the cosmos client exception */ - public CosmosDatabaseResponse read() throws CosmosClientException { + public CosmosDatabaseResponse read() { return client.mapDatabaseResponseAndBlock((databaseWrapper.read())); } @@ -70,9 +69,8 @@ public CosmosDatabaseResponse read() throws CosmosClientException { * * @param options the {@link CosmosDatabaseRequestOptions} request options. * @return the {@link CosmosDatabaseResponse} - * @throws CosmosClientException the cosmos client exception */ - public CosmosDatabaseResponse read(CosmosDatabaseRequestOptions options) throws CosmosClientException { + public CosmosDatabaseResponse read(CosmosDatabaseRequestOptions options) { return client.mapDatabaseResponseAndBlock(databaseWrapper.read(options)); } @@ -80,9 +78,8 @@ public CosmosDatabaseResponse read(CosmosDatabaseRequestOptions options) throws * Delete a database. * * @return the {@link CosmosDatabaseResponse} - * @throws CosmosClientException the cosmos client exception */ - public CosmosDatabaseResponse delete() throws CosmosClientException { + public CosmosDatabaseResponse delete() { return client.mapDatabaseResponseAndBlock(databaseWrapper.delete()); } @@ -91,9 +88,8 @@ public CosmosDatabaseResponse delete() throws CosmosClientException { * * @param options the {@link CosmosDatabaseRequestOptions} request options. * @return the {@link CosmosDatabaseResponse} - * @throws CosmosClientException the cosmos client exception */ - public CosmosDatabaseResponse delete(CosmosDatabaseRequestOptions options) throws CosmosClientException { + public CosmosDatabaseResponse delete(CosmosDatabaseRequestOptions options) { return client.mapDatabaseResponseAndBlock(databaseWrapper.delete(options)); } @@ -104,10 +100,8 @@ public CosmosDatabaseResponse delete(CosmosDatabaseRequestOptions options) throw * * @param containerProperties the {@link CosmosContainerProperties} * @return the {@link CosmosContainerResponse} with the created container. - * @throws CosmosClientException the cosmos client exception */ - public CosmosContainerResponse createContainer(CosmosContainerProperties containerProperties) throws - CosmosClientException { + public CosmosContainerResponse createContainer(CosmosContainerProperties containerProperties) { return this.mapContainerResponseAndBlock(databaseWrapper.createContainer(containerProperties)); } @@ -117,11 +111,10 @@ public CosmosContainerResponse createContainer(CosmosContainerProperties contain * @param containerProperties the {@link CosmosContainerProperties} * @param throughput the throughput * @return the {@link CosmosContainerResponse} with the created container. - * @throws CosmosClientException the cosmos client exception */ public CosmosContainerResponse createContainer( CosmosContainerProperties containerProperties, - int throughput) throws CosmosClientException { + int throughput) { return this.mapContainerResponseAndBlock(databaseWrapper.createContainer(containerProperties, throughput)); } @@ -131,11 +124,10 @@ public CosmosContainerResponse createContainer( * @param containerProperties the {@link CosmosContainerProperties} * @param options the {@link CosmosContainerProperties} * @return the {@link CosmosContainerResponse} with the created container. - * @throws CosmosClientException the cosmos client exception */ public CosmosContainerResponse createContainer( CosmosContainerProperties containerProperties, - CosmosContainerRequestOptions options) throws CosmosClientException { + CosmosContainerRequestOptions options) { return this.mapContainerResponseAndBlock(databaseWrapper.createContainer(containerProperties, options)); } @@ -146,12 +138,11 @@ public CosmosContainerResponse createContainer( * @param throughput the throughput * @param options the {@link CosmosContainerProperties} * @return the {@link CosmosContainerResponse} with the created container. - * @throws CosmosClientException the cosmos client exception */ public CosmosContainerResponse createContainer( CosmosContainerProperties containerProperties, int throughput, - CosmosContainerRequestOptions options) throws CosmosClientException { + CosmosContainerRequestOptions options) { return this.mapContainerResponseAndBlock(databaseWrapper.createContainer(containerProperties, throughput, options)); @@ -164,12 +155,11 @@ public CosmosContainerResponse createContainer( * @param throughputProperties the throughput properties * @param options the options * @return the cosmos container response - * @throws CosmosClientException the cosmos client exception */ public CosmosContainerResponse createContainer( CosmosContainerProperties containerProperties, ThroughputProperties throughputProperties, - CosmosContainerRequestOptions options) throws CosmosClientException { + CosmosContainerRequestOptions options) { return this.mapContainerResponseAndBlock(databaseWrapper.createContainer(containerProperties, throughputProperties, options)); @@ -181,9 +171,8 @@ public CosmosContainerResponse createContainer( * @param id the id * @param partitionKeyPath the partition key path * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ - public CosmosContainerResponse createContainer(String id, String partitionKeyPath) throws CosmosClientException { + public CosmosContainerResponse createContainer(String id, String partitionKeyPath) { return this.mapContainerResponseAndBlock(databaseWrapper.createContainer(id, partitionKeyPath)); } @@ -194,10 +183,8 @@ public CosmosContainerResponse createContainer(String id, String partitionKeyPat * @param partitionKeyPath the partition key path * @param throughput the throughput * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ - public CosmosContainerResponse createContainer(String id, String partitionKeyPath, int throughput) throws - CosmosClientException { + public CosmosContainerResponse createContainer(String id, String partitionKeyPath, int throughput) { return this.mapContainerResponseAndBlock(databaseWrapper.createContainer(id, partitionKeyPath, throughput)); } @@ -206,10 +193,8 @@ public CosmosContainerResponse createContainer(String id, String partitionKeyPat * * @param containerProperties the container properties * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ - public CosmosContainerResponse createContainerIfNotExists(CosmosContainerProperties containerProperties) throws - CosmosClientException { + public CosmosContainerResponse createContainerIfNotExists(CosmosContainerProperties containerProperties) { return this.mapContainerResponseAndBlock(databaseWrapper.createContainerIfNotExists(containerProperties)); } @@ -219,11 +204,10 @@ public CosmosContainerResponse createContainerIfNotExists(CosmosContainerPropert * @param containerProperties the container properties * @param throughput the throughput * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ public CosmosContainerResponse createContainerIfNotExists( CosmosContainerProperties containerProperties, - int throughput) throws CosmosClientException { + int throughput) { return this.mapContainerResponseAndBlock(databaseWrapper.createContainerIfNotExists(containerProperties, throughput)); } @@ -234,11 +218,10 @@ public CosmosContainerResponse createContainerIfNotExists( * @param id the id * @param partitionKeyPath the partition key path * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ public CosmosContainerResponse createContainerIfNotExists( String id, - String partitionKeyPath) throws CosmosClientException { + String partitionKeyPath) { return this.mapContainerResponseAndBlock(databaseWrapper.createContainerIfNotExists(id, partitionKeyPath)); } @@ -249,11 +232,10 @@ public CosmosContainerResponse createContainerIfNotExists( * @param partitionKeyPath the partition key path * @param throughput the throughput * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ public CosmosContainerResponse createContainerIfNotExists( String id, String partitionKeyPath, - int throughput) throws CosmosClientException { + int throughput) { return this.mapContainerResponseAndBlock(databaseWrapper.createContainerIfNotExists(id, partitionKeyPath, throughput)); @@ -264,18 +246,16 @@ public CosmosContainerResponse createContainerIfNotExists( * * @param containerMono the container mono * @return the cosmos sync container response - * @throws CosmosClientException the cosmos client exception */ - CosmosContainerResponse mapContainerResponseAndBlock(Mono containerMono) throws - CosmosClientException { + CosmosContainerResponse mapContainerResponseAndBlock(Mono containerMono) { try { return containerMono .map(this::convertResponse) .block(); } catch (Exception ex) { final Throwable throwable = Exceptions.unwrap(ex); - if (throwable instanceof CosmosClientException) { - throw (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + throw (CosmosException) throwable; } else { throw Exceptions.propagate(ex); } @@ -372,9 +352,8 @@ CosmosContainerResponse convertResponse(CosmosAsyncContainerResponse response) { * * @param userProperties the settings * @return the cosmos sync user response - * @throws CosmosClientException the cosmos client exception */ - public CosmosUserResponse createUser(CosmosUserProperties userProperties) throws CosmosClientException { + public CosmosUserResponse createUser(CosmosUserProperties userProperties) { return mapUserResponseAndBlock(databaseWrapper.createUser(userProperties)); } @@ -383,9 +362,8 @@ public CosmosUserResponse createUser(CosmosUserProperties userProperties) throws * * @param userProperties the settings * @return the cosmos sync user response - * @throws CosmosClientException the cosmos client exception */ - public CosmosUserResponse upsertUser(CosmosUserProperties userProperties) throws CosmosClientException { + public CosmosUserResponse upsertUser(CosmosUserProperties userProperties) { return mapUserResponseAndBlock(databaseWrapper.upsertUser(userProperties)); } @@ -460,14 +438,13 @@ public CosmosUser getUser(String id) { return new CosmosUser(databaseWrapper.getUser(id), this, id); } - CosmosUserResponse mapUserResponseAndBlock(Mono containerMono) throws - CosmosClientException { + CosmosUserResponse mapUserResponseAndBlock(Mono containerMono) { try { return containerMono.map(this::convertUserResponse).block(); } catch (Exception ex) { final Throwable throwable = Exceptions.unwrap(ex); - if (throwable instanceof CosmosClientException) { - throw (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + throw (CosmosException) throwable; } else { throw Exceptions.propagate(ex); } @@ -482,9 +459,8 @@ private CosmosUserResponse convertUserResponse(CosmosAsyncUserResponse response) * Read provisioned throughput integer. * * @return the integer. null response indicates database doesn't have any provisioned RUs - * @throws CosmosClientException the cosmos client exception */ - public Integer readProvisionedThroughput() throws CosmosClientException { + public Integer readProvisionedThroughput() { return throughputResponseToBlock(databaseWrapper.readProvisionedThroughput()); } @@ -493,9 +469,8 @@ public Integer readProvisionedThroughput() throws CosmosClientException { * * @param requestUnitsPerSecond the request units per second * @return the integer - * @throws CosmosClientException the cosmos client exception */ - public Integer replaceProvisionedThroughput(int requestUnitsPerSecond) throws CosmosClientException { + public Integer replaceProvisionedThroughput(int requestUnitsPerSecond) { return throughputResponseToBlock(databaseWrapper.replaceProvisionedThroughput(requestUnitsPerSecond)); } @@ -518,13 +493,13 @@ public ThroughputResponse readThroughput() { return throughputResponseToBlock(databaseWrapper.readThroughput()); } - T throughputResponseToBlock(Mono throughputResponse) throws CosmosClientException { + T throughputResponseToBlock(Mono throughputResponse) { try { return throughputResponse.block(); } catch (Exception ex) { final Throwable throwable = Exceptions.unwrap(ex); - if (throwable instanceof CosmosClientException) { - throw (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + throw (CosmosException) throwable; } else { throw Exceptions.propagate(ex); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosException.java similarity index 81% rename from sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientException.java rename to sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosException.java index aa7d6ac543e5a..8f103fc03953a 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosException.java @@ -8,7 +8,7 @@ import com.azure.cosmos.implementation.HttpConstants; import com.azure.cosmos.implementation.RequestTimeline; import com.azure.cosmos.implementation.directconnectivity.Uri; -import com.azure.cosmos.models.CosmosError; +import com.azure.cosmos.implementation.CosmosError; import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.implementation.apachecommons.lang.StringUtils; @@ -21,20 +21,20 @@ /** * This class defines a custom exception type for all operations on * CosmosClient in the Azure Cosmos DB database service. Applications are - * expected to catch CosmosClientException and handle errors as appropriate when + * expected to catch CosmosException and handle errors as appropriate when * calling methods on CosmosClient. *

* Errors coming from the service during normal execution are converted to - * CosmosClientException before returning to the application with the following + * CosmosException before returning to the application with the following * exception: *

* When a BE error is encountered during a QueryIterable<T> iteration, an - * IllegalStateException is thrown instead of CosmosClientException. + * IllegalStateException is thrown instead of CosmosException. *

* When a transport level error happens that request is not able to reach the - * service, an IllegalStateException is thrown instead of CosmosClientException. + * service, an IllegalStateException is thrown instead of CosmosException. */ -public class CosmosClientException extends AzureException { +public class CosmosException extends AzureException { private static final long serialVersionUID = 1L; private final int statusCode; @@ -50,7 +50,7 @@ public class CosmosClientException extends AzureException { Uri requestUri; String resourceAddress; - protected CosmosClientException(int statusCode, String message, Map responseHeaders, Throwable cause) { + protected CosmosException(int statusCode, String message, Map responseHeaders, Throwable cause) { super(message, cause); this.statusCode = statusCode; this.requestTimeline = RequestTimeline.empty(); @@ -58,49 +58,49 @@ protected CosmosClientException(int statusCode, String message, Map responseHeaders) { + protected CosmosException(int statusCode, CosmosError cosmosErrorResource, Map responseHeaders) { this(/* resourceAddress */ null, statusCode, cosmosErrorResource, responseHeaders); } /** - * Creates a new instance of the CosmosClientException class. + * Creates a new instance of the CosmosException class. * * @param resourceAddress the address of the resource the request is associated with. * @param statusCode the http status code of the response. @@ -108,17 +108,17 @@ protected CosmosClientException(int statusCode, CosmosError cosmosErrorResource, * @param responseHeaders the response headers. */ - protected CosmosClientException(String resourceAddress, - int statusCode, - CosmosError cosmosErrorResource, - Map responseHeaders) { + protected CosmosException(String resourceAddress, + int statusCode, + CosmosError cosmosErrorResource, + Map responseHeaders) { this(statusCode, cosmosErrorResource == null ? null : cosmosErrorResource.getMessage(), responseHeaders, null); this.resourceAddress = resourceAddress; this.cosmosError = cosmosErrorResource; } /** - * Creates a new instance of the CosmosClientException class. + * Creates a new instance of the CosmosException class. * * @param message the string message. * @param statusCode the http status code of the response. @@ -126,8 +126,8 @@ protected CosmosClientException(String resourceAddress, * @param responseHeaders the response headers. * @param resourceAddress the address of the resource the request is associated with. */ - protected CosmosClientException(String message, Exception exception, Map responseHeaders, int statusCode, - String resourceAddress) { + protected CosmosException(String message, Exception exception, Map responseHeaders, int statusCode, + String resourceAddress) { this(statusCode, message, responseHeaders, exception); this.resourceAddress = resourceAddress; } @@ -188,7 +188,7 @@ public int getSubStatusCode() { * * @return the error. */ - public CosmosError getError() { + CosmosError getError() { return this.cosmosError; } @@ -251,7 +251,7 @@ public CosmosDiagnostics getDiagnostics() { return cosmosDiagnostics; } - CosmosClientException setDiagnostics(CosmosDiagnostics cosmosDiagnostics) { + CosmosException setDiagnostics(CosmosDiagnostics cosmosDiagnostics) { this.cosmosDiagnostics = cosmosDiagnostics; return this; } @@ -270,7 +270,7 @@ String innerErrorMessage() { innerErrorMessage = cosmosError.getMessage(); if (innerErrorMessage == null) { innerErrorMessage = String.valueOf( - ModelBridgeInternal.getObjectFromJsonSerializable(ModelBridgeInternal.getJsonSerializable(cosmosError), "Errors")); + ModelBridgeInternal.getObjectFromJsonSerializable(cosmosError, "Errors")); } } return innerErrorMessage; diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosScripts.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosScripts.java index b3eb7a8d45532..14ad8b8371b63 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosScripts.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosScripts.java @@ -46,10 +46,8 @@ public class CosmosScripts { * * @param properties the properties * @return the cosmos sync stored procedure response - * @throws CosmosClientException the cosmos client exception */ - public CosmosStoredProcedureResponse createStoredProcedure(CosmosStoredProcedureProperties properties) throws - CosmosClientException { + public CosmosStoredProcedureResponse createStoredProcedure(CosmosStoredProcedureProperties properties) { return mapStoredProcedureResponseAndBlock( asyncScripts.createStoredProcedure(properties, new CosmosStoredProcedureRequestOptions()) ); @@ -61,11 +59,10 @@ public CosmosStoredProcedureResponse createStoredProcedure(CosmosStoredProcedure * @param properties the properties * @param options the options * @return the cosmos sync stored procedure response - * @throws CosmosClientException the cosmos client exception */ public CosmosStoredProcedureResponse createStoredProcedure( CosmosStoredProcedureProperties properties, - CosmosStoredProcedureRequestOptions options) throws CosmosClientException { + CosmosStoredProcedureRequestOptions options) { return mapStoredProcedureResponseAndBlock(asyncScripts.createStoredProcedure(properties, options)); } @@ -127,10 +124,8 @@ public CosmosStoredProcedure getStoredProcedure(String id) { * * @param properties the properties * @return the cosmos sync user defined function response - * @throws CosmosClientException the cosmos client exception */ - public CosmosUserDefinedFunctionResponse createUserDefinedFunction(CosmosUserDefinedFunctionProperties properties) - throws CosmosClientException { + public CosmosUserDefinedFunctionResponse createUserDefinedFunction(CosmosUserDefinedFunctionProperties properties) { return mapUDFResponseAndBlock(asyncScripts.createUserDefinedFunction(properties)); } @@ -190,9 +185,8 @@ public CosmosUserDefinedFunction getUserDefinedFunction(String id) { * * @param properties the properties * @return the cosmos sync trigger response - * @throws CosmosClientException the cosmos client exception */ - public CosmosTriggerResponse createTrigger(CosmosTriggerProperties properties) throws CosmosClientException { + public CosmosTriggerResponse createTrigger(CosmosTriggerProperties properties) { return mapTriggerResponseAndBlock(asyncScripts.createTrigger(properties)); } @@ -247,18 +241,17 @@ public CosmosTrigger getTrigger(String id) { * * @param storedProcedureResponseMono the stored procedure response mono * @return the cosmos sync stored procedure response - * @throws CosmosClientException the cosmos client exception */ CosmosStoredProcedureResponse mapStoredProcedureResponseAndBlock( - Mono storedProcedureResponseMono) throws CosmosClientException { + Mono storedProcedureResponseMono) { try { return storedProcedureResponseMono .map(this::convertResponse) .block(); } catch (Exception ex) { final Throwable throwable = Exceptions.unwrap(ex); - if (throwable instanceof CosmosClientException) { - throw (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + throw (CosmosException) throwable; } else { throw ex; } @@ -284,18 +277,17 @@ CosmosStoredProcedureResponse convertResponse(CosmosAsyncStoredProcedureResponse * * @param responseMono the response mono * @return the cosmos sync user defined function response - * @throws CosmosClientException the cosmos client exception */ CosmosUserDefinedFunctionResponse mapUDFResponseAndBlock( - Mono responseMono) throws CosmosClientException { + Mono responseMono) { try { return responseMono .map(this::convertResponse) .block(); } catch (Exception ex) { final Throwable throwable = Exceptions.unwrap(ex); - if (throwable instanceof CosmosClientException) { - throw (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + throw (CosmosException) throwable; } else { throw Exceptions.propagate(ex); } @@ -325,18 +317,16 @@ CosmosUserDefinedFunctionResponse convertResponse(CosmosAsyncUserDefinedFunction * * @param responseMono the response mono * @return the cosmos sync trigger response - * @throws CosmosClientException the cosmos client exception */ - CosmosTriggerResponse mapTriggerResponseAndBlock(Mono responseMono) throws - CosmosClientException { + CosmosTriggerResponse mapTriggerResponseAndBlock(Mono responseMono) { try { return responseMono .map(this::convertResponse) .block(); } catch (Exception ex) { final Throwable throwable = Exceptions.unwrap(ex); - if (throwable instanceof CosmosClientException) { - throw (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + throw (CosmosException) throwable; } else { throw Exceptions.propagate(ex); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosStoredProcedure.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosStoredProcedure.java index 0307f25a7614c..7869978cca101 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosStoredProcedure.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosStoredProcedure.java @@ -44,9 +44,8 @@ public String getId() { * Read cosmos sync stored procedure. * * @return the cosmos sync stored procedure response - * @throws CosmosClientException the cosmos client exception */ - public CosmosStoredProcedureResponse read() throws CosmosClientException { + public CosmosStoredProcedureResponse read() { return container.getScripts() .mapStoredProcedureResponseAndBlock(storedProcedure.read()); } @@ -56,10 +55,8 @@ public CosmosStoredProcedureResponse read() throws CosmosClientException { * * @param options the options * @return the cosmos sync stored procedure response - * @throws CosmosClientException the cosmos client exception */ - public CosmosStoredProcedureResponse read(CosmosStoredProcedureRequestOptions options) throws - CosmosClientException { + public CosmosStoredProcedureResponse read(CosmosStoredProcedureRequestOptions options) { return container.getScripts() .mapStoredProcedureResponseAndBlock(storedProcedure.read(options)); } @@ -68,9 +65,8 @@ public CosmosStoredProcedureResponse read(CosmosStoredProcedureRequestOptions op * Delete cosmos stored procedure. * * @return the cosmos sync response - * @throws CosmosClientException the cosmos client exception */ - public CosmosStoredProcedureResponse delete() throws CosmosClientException { + public CosmosStoredProcedureResponse delete() { return container.getScripts() .mapStoredProcedureResponseAndBlock(storedProcedure.delete()); } @@ -80,9 +76,8 @@ public CosmosStoredProcedureResponse delete() throws CosmosClientException { * * @param options the options * @return the cosmos sync response - * @throws CosmosClientException the cosmos client exception */ - CosmosStoredProcedureResponse delete(CosmosStoredProcedureRequestOptions options) throws CosmosClientException { + CosmosStoredProcedureResponse delete(CosmosStoredProcedureRequestOptions options) { return container.getScripts() .mapStoredProcedureResponseAndBlock(storedProcedure.delete(options)); } @@ -93,11 +88,10 @@ CosmosStoredProcedureResponse delete(CosmosStoredProcedureRequestOptions options * @param procedureParams the procedure params * @param options the options * @return the cosmos sync stored procedure response - * @throws CosmosClientException the cosmos client exception */ public CosmosStoredProcedureResponse execute( List procedureParams, - CosmosStoredProcedureRequestOptions options) throws CosmosClientException { + CosmosStoredProcedureRequestOptions options) { return container.getScripts() .mapStoredProcedureResponseAndBlock(storedProcedure.execute(procedureParams, options)); } @@ -107,10 +101,8 @@ public CosmosStoredProcedureResponse execute( * * @param storedProcedureSettings the stored procedure settings * @return the cosmos sync stored procedure response - * @throws CosmosClientException the cosmos client exception */ - public CosmosStoredProcedureResponse replace(CosmosStoredProcedureProperties storedProcedureSettings) throws - CosmosClientException { + public CosmosStoredProcedureResponse replace(CosmosStoredProcedureProperties storedProcedureSettings) { return container.getScripts() .mapStoredProcedureResponseAndBlock(storedProcedure.replace(storedProcedureSettings)); } @@ -121,11 +113,10 @@ public CosmosStoredProcedureResponse replace(CosmosStoredProcedureProperties sto * @param storedProcedureSettings the stored procedure settings * @param options the options * @return the cosmos sync stored procedure response - * @throws CosmosClientException the cosmos client exception */ public CosmosStoredProcedureResponse replace( CosmosStoredProcedureProperties storedProcedureSettings, - CosmosStoredProcedureRequestOptions options) throws CosmosClientException { + CosmosStoredProcedureRequestOptions options) { return container.getScripts() .mapStoredProcedureResponseAndBlock(storedProcedure.replace(storedProcedureSettings, options)); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosTrigger.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosTrigger.java index 3adb50dd31e1e..11df5a262ea7f 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosTrigger.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosTrigger.java @@ -40,9 +40,8 @@ public String getId() { * Read cosmos trigger. * * @return the cosmos sync trigger response - * @throws CosmosClientException the cosmos client exception */ - public CosmosTriggerResponse read() throws CosmosClientException { + public CosmosTriggerResponse read() { return container.getScripts().mapTriggerResponseAndBlock(trigger.read()); } @@ -51,9 +50,8 @@ public CosmosTriggerResponse read() throws CosmosClientException { * * @param triggerSettings the trigger settings * @return the cosmos sync trigger response - * @throws CosmosClientException the cosmos client exception */ - public CosmosTriggerResponse replace(CosmosTriggerProperties triggerSettings) throws CosmosClientException { + public CosmosTriggerResponse replace(CosmosTriggerProperties triggerSettings) { return container.getScripts().mapTriggerResponseAndBlock(trigger.replace(triggerSettings)); } @@ -61,9 +59,8 @@ public CosmosTriggerResponse replace(CosmosTriggerProperties triggerSettings) th * Delete cosmos trigger. * * @return the cosmos sync response - * @throws CosmosClientException the cosmos client exception */ - public CosmosTriggerResponse delete() throws CosmosClientException { + public CosmosTriggerResponse delete() { return container.getScripts().mapTriggerResponseAndBlock(trigger.delete()); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosUser.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosUser.java index 3f4c20db64cd8..3ee3d09218228 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosUser.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosUser.java @@ -40,9 +40,8 @@ public String getId() { * Read cosmos user * * @return the cosmos sync user response - * @throws CosmosClientException the cosmos client exception */ - public CosmosUserResponse read() throws CosmosClientException { + public CosmosUserResponse read() { return database.mapUserResponseAndBlock(asyncUser.read()); } @@ -51,9 +50,8 @@ public CosmosUserResponse read() throws CosmosClientException { * * @param userProperties the user properties * @return the cosmos sync user response - * @throws CosmosClientException the cosmos client exception */ - public CosmosUserResponse replace(CosmosUserProperties userProperties) throws CosmosClientException { + public CosmosUserResponse replace(CosmosUserProperties userProperties) { return database.mapUserResponseAndBlock(asyncUser.replace(userProperties)); } @@ -61,9 +59,8 @@ public CosmosUserResponse replace(CosmosUserProperties userProperties) throws Co * Delete cosmos user. * * @return the cosmos sync user response - * @throws CosmosClientException the cosmos client exception */ - public CosmosUserResponse delete() throws CosmosClientException { + public CosmosUserResponse delete() { return database.mapUserResponseAndBlock(asyncUser.delete()); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosUserDefinedFunction.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosUserDefinedFunction.java index 4df723c8292c7..d7496f4dc70ba 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosUserDefinedFunction.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosUserDefinedFunction.java @@ -42,9 +42,8 @@ public String getId() { * Read cosmos user defined function. * * @return the cosmos sync user defined function response - * @throws CosmosClientException the cosmos client exception */ - public CosmosUserDefinedFunctionResponse read() throws CosmosClientException { + public CosmosUserDefinedFunctionResponse read() { return container.getScripts().mapUDFResponseAndBlock(userDefinedFunction.read()); } @@ -53,10 +52,8 @@ public CosmosUserDefinedFunctionResponse read() throws CosmosClientException { * * @param udfSettings the udf settings * @return the cosmos sync user defined function response - * @throws CosmosClientException the cosmos client exception */ - public CosmosUserDefinedFunctionResponse replace(CosmosUserDefinedFunctionProperties udfSettings) throws - CosmosClientException { + public CosmosUserDefinedFunctionResponse replace(CosmosUserDefinedFunctionProperties udfSettings) { return container.getScripts().mapUDFResponseAndBlock(userDefinedFunction.replace(udfSettings)); } @@ -64,9 +61,8 @@ public CosmosUserDefinedFunctionResponse replace(CosmosUserDefinedFunctionProper * Delete cosmos user defined function. * * @return the cosmos sync response - * @throws CosmosClientException the cosmos client exception */ - public CosmosUserDefinedFunctionResponse delete() throws CosmosClientException { + public CosmosUserDefinedFunctionResponse delete() { return container.getScripts().mapUDFResponseAndBlock(userDefinedFunction.delete()); } } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/BadRequestException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/BadRequestException.java index 0bc34d9796209..cfa1116011b92 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/BadRequestException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/BadRequestException.java @@ -3,12 +3,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.net.URI; import java.util.HashMap; @@ -18,7 +15,7 @@ * While this class is public, but it is not part of our published public APIs. * This is meant to be internally used only by our sdk. */ -public class BadRequestException extends CosmosClientException { +public class BadRequestException extends CosmosException { private static final long serialVersionUID = 1L; /** diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClearingSessionContainerClientRetryPolicy.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClearingSessionContainerClientRetryPolicy.java index 34c1f5be63c59..1704243102ca5 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClearingSessionContainerClientRetryPolicy.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClearingSessionContainerClientRetryPolicy.java @@ -2,7 +2,7 @@ // Licensed under the MIT License. package com.azure.cosmos.implementation; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import reactor.core.publisher.Mono; @@ -44,7 +44,7 @@ public Mono shouldRetry(Exception e) { if (!shouldRetryResult.shouldRetry && !this.hasTriggered) { - CosmosClientException clientException = Utils.as(e, CosmosClientException.class); + CosmosException clientException = Utils.as(e, CosmosException.class); if (this.request == null) { // someone didn't call OnBeforeSendRequest - nothing we can do diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientRetryPolicy.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientRetryPolicy.java index 5ce81fc4a07a9..3f2030ea2f70c 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientRetryPolicy.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientRetryPolicy.java @@ -5,7 +5,7 @@ import com.azure.cosmos.implementation.apachecommons.collections.list.UnmodifiableList; import com.azure.cosmos.implementation.directconnectivity.WebExceptionUtility; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.CosmosDiagnostics; import com.azure.cosmos.ThrottlingRetryOptions; import org.slf4j.Logger; @@ -73,7 +73,7 @@ public Mono shouldRetry(Exception e) { this.retryContext = null; // Received 403.3 on write region, initiate the endpoint re-discovery - CosmosClientException clientException = Utils.as(e, CosmosClientException.class); + CosmosException clientException = Utils.as(e, CosmosException.class); if (clientException != null && clientException.getDiagnostics() != null) { this.cosmosDiagnostics = clientException.getDiagnostics(); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ConflictException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ConflictException.java index 7f536f761c5a9..0f73b7f7d0ac0 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ConflictException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ConflictException.java @@ -3,12 +3,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.util.Map; @@ -16,7 +13,7 @@ * While this class is public, but it is not part of our published public APIs. * This is meant to be internally used only by our sdk. */ -public class ConflictException extends CosmosClientException { +public class ConflictException extends CosmosException { private static final long serialVersionUID = 1L; diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosError.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/CosmosError.java similarity index 65% rename from sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosError.java rename to sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/CosmosError.java index 7d4dfa8aff56d..b9d3913912a2d 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosError.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/CosmosError.java @@ -1,23 +1,20 @@ // Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. -package com.azure.cosmos.models; +package com.azure.cosmos.implementation; -import com.azure.cosmos.implementation.Constants; -import com.azure.cosmos.implementation.JsonSerializable; import com.fasterxml.jackson.databind.node.ObjectNode; /** * Encapsulates error related details in the Azure Cosmos DB database service. */ -public final class CosmosError { - private JsonSerializable jsonSerializable; +public final class CosmosError extends JsonSerializable { /** * Initialize a new instance of the Error object. */ public CosmosError() { - this.jsonSerializable = new JsonSerializable(); + super(); } /** @@ -25,8 +22,8 @@ public CosmosError() { * * @param objectNode the {@link ObjectNode} that represents the error. */ - CosmosError(ObjectNode objectNode) { - this.jsonSerializable = new JsonSerializable(objectNode); + public CosmosError(ObjectNode objectNode) { + super(objectNode); } /** @@ -34,8 +31,8 @@ public CosmosError() { * * @param jsonString the jsonString that represents the error. */ - CosmosError(String jsonString) { - this.jsonSerializable = new JsonSerializable(jsonString); + public CosmosError(String jsonString) { + super(jsonString); } /** @@ -56,7 +53,7 @@ public CosmosError(String errorCode, String message) { * @param additionalErrorInfo additional error info. */ public CosmosError(String errorCode, String message, String additionalErrorInfo) { - this.jsonSerializable = new JsonSerializable(); + super(); this.setCode(errorCode); this.setMessage(message); this.setAdditionalErrorInfo(additionalErrorInfo); @@ -68,7 +65,7 @@ public CosmosError(String errorCode, String message, String additionalErrorInfo) * @return the error code. */ public String getCode() { - return this.jsonSerializable.getString(Constants.Properties.CODE); + return super.getString(Constants.Properties.CODE); } /** @@ -77,7 +74,7 @@ public String getCode() { * @param code the error code. */ private void setCode(String code) { - this.jsonSerializable.set(Constants.Properties.CODE, code); + super.set(Constants.Properties.CODE, code); } /** @@ -86,7 +83,7 @@ private void setCode(String code) { * @return the error message. */ public String getMessage() { - return this.jsonSerializable.getString(Constants.Properties.MESSAGE); + return super.getString(Constants.Properties.MESSAGE); } /** @@ -95,7 +92,7 @@ public String getMessage() { * @param message the error message. */ private void setMessage(String message) { - this.jsonSerializable.set(Constants.Properties.MESSAGE, message); + super.set(Constants.Properties.MESSAGE, message); } /** @@ -104,7 +101,7 @@ private void setMessage(String message) { * @return the error details. */ public String getErrorDetails() { - return this.jsonSerializable.getString(Constants.Properties.ERROR_DETAILS); + return super.getString(Constants.Properties.ERROR_DETAILS); } /** @@ -113,7 +110,7 @@ public String getErrorDetails() { * @param additionalErrorInfo the partitioned query execution info. */ private void setAdditionalErrorInfo(String additionalErrorInfo) { - this.jsonSerializable.set(Constants.Properties.ADDITIONAL_ERROR_INFO, additionalErrorInfo); + super.set(Constants.Properties.ADDITIONAL_ERROR_INFO, additionalErrorInfo); } /** @@ -122,12 +119,6 @@ private void setAdditionalErrorInfo(String additionalErrorInfo) { * @return the partitioned query execution info. */ public String getPartitionedQueryExecutionInfo() { - return this.jsonSerializable.getString(Constants.Properties.ADDITIONAL_ERROR_INFO); + return super.getString(Constants.Properties.ADDITIONAL_ERROR_INFO); } - - void populatePropertyBag() { - this.jsonSerializable.populatePropertyBag(); - } - - JsonSerializable getJsonSerializable() { return this.jsonSerializable; } } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Exceptions.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Exceptions.java index 0d050bd350081..b3d05aa1c94eb 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Exceptions.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Exceptions.java @@ -2,7 +2,7 @@ // Licensed under the MIT License. package com.azure.cosmos.implementation; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; /** * While this class is public, but it is not part of our published public APIs. @@ -10,20 +10,20 @@ */ public class Exceptions { - public static boolean isStatusCode(CosmosClientException e, int status) { + public static boolean isStatusCode(CosmosException e, int status) { return status == e.getStatusCode(); } - public static boolean isSubStatusCode(CosmosClientException e, int subStatus) { + public static boolean isSubStatusCode(CosmosException e, int subStatus) { return subStatus == e.getSubStatusCode(); } - public static boolean isPartitionSplit(CosmosClientException e) { + public static boolean isPartitionSplit(CosmosException e) { return isStatusCode(e, HttpConstants.StatusCodes.GONE) && isSubStatusCode(e, HttpConstants.SubStatusCodes.PARTITION_KEY_RANGE_GONE); } - public static boolean isNameCacheStale(CosmosClientException e) { + public static boolean isNameCacheStale(CosmosException e) { return isStatusCode(e, HttpConstants.StatusCodes.GONE) && isSubStatusCode(e, HttpConstants.SubStatusCodes.NAME_CACHE_IS_STALE); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ForbiddenException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ForbiddenException.java index 18ed1aa57e26a..cda06ca20df54 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ForbiddenException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ForbiddenException.java @@ -4,12 +4,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.net.URI; import java.util.Map; @@ -17,7 +14,7 @@ /** * Forbidden exception */ -public class ForbiddenException extends CosmosClientException { +public class ForbiddenException extends CosmosException { ForbiddenException() { this(RMResources.Forbidden); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GoneException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GoneException.java index dd69cfffcf941..4f210ec3139d2 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GoneException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GoneException.java @@ -4,13 +4,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; -import com.azure.cosmos.implementation.Strings; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.net.URI; import java.util.HashMap; @@ -19,7 +15,7 @@ /** * The type Gone exception. */ -public class GoneException extends CosmosClientException { +public class GoneException extends CosmosException { /** * Instantiates a new Gone exception. @@ -106,7 +102,7 @@ public GoneException(String message, innerException, HttpUtils.asMap(headers), HttpConstants.StatusCodes.GONE, - requestUrl != null + requestUrl != null ? requestUrl.toString() : null); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ISessionToken.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ISessionToken.java index ca9a49b556e5b..2c0a2c74bb601 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ISessionToken.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ISessionToken.java @@ -3,8 +3,6 @@ package com.azure.cosmos.implementation; -import com.azure.cosmos.CosmosClientException; - /** * Models session token. * @@ -24,7 +22,7 @@ public interface ISessionToken { * @return true if this instance of session token is valid with respect to other session token; * false otherwise */ - boolean isValid(ISessionToken other) throws CosmosClientException; + boolean isValid(ISessionToken other); /** * Returns a new instance of session token obtained by merging this session token with @@ -35,7 +33,7 @@ public interface ISessionToken { * @param other Other session token to merge * @return Instance of merged session token */ - ISessionToken merge(ISessionToken other) throws CosmosClientException; + ISessionToken merge(ISessionToken other); long getLSN(); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InternalServerErrorException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InternalServerErrorException.java index e6f6f9c03ab44..9a6efca84f147 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InternalServerErrorException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InternalServerErrorException.java @@ -4,12 +4,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.net.URI; import java.util.Map; @@ -21,7 +18,7 @@ * No retries should be made in this case, as either split or merge might have happened and query/readfeed * must take appropriate actions. */ -public class InternalServerErrorException extends CosmosClientException { +public class InternalServerErrorException extends CosmosException { InternalServerErrorException() { this(RMResources.InternalServerError); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InvalidPartitionException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InvalidPartitionException.java index 6b024c576c4d9..c1538cf776797 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InvalidPartitionException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InvalidPartitionException.java @@ -3,13 +3,10 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.directconnectivity.WFConstants; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.util.Map; @@ -17,7 +14,7 @@ * While this class is public, but it is not part of our published public APIs. * This is meant to be internally used only by our sdk. */ -public class InvalidPartitionException extends CosmosClientException { +public class InvalidPartitionException extends CosmosException { private static final long serialVersionUID = 1L; diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InvalidPartitionExceptionRetryPolicy.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InvalidPartitionExceptionRetryPolicy.java index 89d9827026f18..653ab64acf172 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InvalidPartitionExceptionRetryPolicy.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/InvalidPartitionExceptionRetryPolicy.java @@ -4,7 +4,7 @@ import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.implementation.caches.RxCollectionCache; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.FeedOptions; import reactor.core.publisher.Mono; @@ -45,7 +45,7 @@ public void onBeforeSendRequest(RxDocumentServiceRequest request) { @Override public Mono shouldRetry(Exception e) { - CosmosClientException clientException = Utils.as(e, CosmosClientException.class); + CosmosException clientException = Utils.as(e, CosmosException.class); if (clientException != null && Exceptions.isStatusCode(clientException, HttpConstants.StatusCodes.GONE) && Exceptions.isSubStatusCode(clientException, HttpConstants.SubStatusCodes.NAME_CACHE_IS_STALE)) { diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/JsonSerializable.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/JsonSerializable.java index 98eda9509534f..05ffb876013fd 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/JsonSerializable.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/JsonSerializable.java @@ -5,7 +5,6 @@ import com.azure.cosmos.models.CompositePath; import com.azure.cosmos.models.ConflictResolutionPolicy; -import com.azure.cosmos.models.CosmosError; import com.azure.cosmos.models.DatabaseAccountLocation; import com.azure.cosmos.models.ExcludedPath; import com.azure.cosmos.models.IncludedPath; @@ -697,7 +696,6 @@ boolean containsJsonSerializable(Class c) { || SqlQuerySpec.class.equals(c) || UniqueKey.class.equals(c) || UniqueKeyPolicy.class.equals(c) - || Index.class.isAssignableFrom(c) - || CosmosError.class.equals(c); + || Index.class.isAssignableFrom(c); } } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/LockedException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/LockedException.java index 926009127f8f9..13abb9a7ad31c 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/LockedException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/LockedException.java @@ -3,12 +3,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.util.Map; @@ -16,7 +13,7 @@ * While this class is public, but it is not part of our published public APIs. * This is meant to be internally used only by our sdk. */ -public class LockedException extends CosmosClientException { +public class LockedException extends CosmosException { private static final long serialVersionUID = 1L; LockedException() { diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/MethodNotAllowedException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/MethodNotAllowedException.java index c1d708a21f1ad..16b3142800e4c 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/MethodNotAllowedException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/MethodNotAllowedException.java @@ -4,12 +4,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.net.URI; import java.util.Map; @@ -17,7 +14,7 @@ /** * The type Method not allowed exception. */ -public class MethodNotAllowedException extends CosmosClientException { +public class MethodNotAllowedException extends CosmosException { MethodNotAllowedException() { this(RMResources.MethodNotAllowed); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/NotFoundException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/NotFoundException.java index e7ae65242a2fd..9eac55b92d6ac 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/NotFoundException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/NotFoundException.java @@ -3,22 +3,18 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.net.URI; -import java.util.HashMap; import java.util.Map; /** * While this class is public, but it is not part of our published public APIs. * This is meant to be internally used only by our sdk. */ -public class NotFoundException extends CosmosClientException { +public class NotFoundException extends CosmosException { private static final long serialVersionUID = 1L; diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionIsMigratingException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionIsMigratingException.java index 4d11907e25403..9f539119648f9 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionIsMigratingException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionIsMigratingException.java @@ -3,13 +3,10 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.directconnectivity.WFConstants; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.util.Map; @@ -17,7 +14,7 @@ * While this class is public, but it is not part of our published public APIs. * This is meant to be internally used only by our sdk. */ -public class PartitionIsMigratingException extends CosmosClientException { +public class PartitionIsMigratingException extends CosmosException { private static final long serialVersionUID = 1L; diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyMismatchRetryPolicy.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyMismatchRetryPolicy.java index 75ece98455ebd..cd87c6b0408ab 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyMismatchRetryPolicy.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyMismatchRetryPolicy.java @@ -4,7 +4,7 @@ import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.implementation.caches.RxClientCollectionCache; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import reactor.core.publisher.Mono; import java.time.Duration; @@ -54,7 +54,7 @@ public PartitionKeyMismatchRetryPolicy( /// /// True indicates caller should retry, False otherwise public Mono shouldRetry(Exception exception) { - CosmosClientException clientException = Utils.as(exception, CosmosClientException.class) ; + CosmosException clientException = Utils.as(exception, CosmosException.class) ; if (clientException != null && Exceptions.isStatusCode(clientException, HttpConstants.StatusCodes.BADREQUEST) && diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeGoneException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeGoneException.java index 763abeb0099fd..fc181f14bbf2f 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeGoneException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeGoneException.java @@ -4,13 +4,10 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.directconnectivity.WFConstants; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.util.Map; @@ -21,7 +18,7 @@ * No retries should be made in this case, as either split or merge might have happened and query/readfeed * must take appropriate actions. */ -public class PartitionKeyRangeGoneException extends CosmosClientException { +public class PartitionKeyRangeGoneException extends CosmosException { /** * Instantiates a new Partition key range gone exception. diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeGoneRetryPolicy.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeGoneRetryPolicy.java index 310313f26fd89..8e65591c33aeb 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeGoneRetryPolicy.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeGoneRetryPolicy.java @@ -6,7 +6,7 @@ import com.azure.cosmos.implementation.caches.IPartitionKeyRangeCache; import com.azure.cosmos.implementation.caches.RxCollectionCache; import com.azure.cosmos.implementation.routing.CollectionRoutingMap; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.FeedOptions; import reactor.core.publisher.Mono; @@ -48,7 +48,7 @@ public PartitionKeyRangeGoneRetryPolicy( /// /// True indicates caller should retry, False otherwise public Mono shouldRetry(Exception exception) { - CosmosClientException clientException = Utils.as(exception, CosmosClientException.class); + CosmosException clientException = Utils.as(exception, CosmosException.class); if (clientException != null && Exceptions.isStatusCode(clientException, HttpConstants.StatusCodes.GONE) && Exceptions.isSubStatusCode(clientException, HttpConstants.SubStatusCodes.PARTITION_KEY_RANGE_GONE)) { diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeIsSplittingException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeIsSplittingException.java index 6e2d81ed1d204..efc7b3dd50254 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeIsSplittingException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PartitionKeyRangeIsSplittingException.java @@ -3,13 +3,10 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.directconnectivity.WFConstants; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.util.Map; @@ -17,7 +14,7 @@ * While this class is public, but it is not part of our published public APIs. * This is meant to be internally used only by our sdk. */ -public class PartitionKeyRangeIsSplittingException extends CosmosClientException { +public class PartitionKeyRangeIsSplittingException extends CosmosException { private static final long serialVersionUID = 1L; diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PreconditionFailedException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PreconditionFailedException.java index ccf89b843d71f..a8427604635f0 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PreconditionFailedException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/PreconditionFailedException.java @@ -3,12 +3,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.util.Map; @@ -16,7 +13,7 @@ * While this class is public, but it is not part of our published public APIs. * This is meant to be internally used only by our sdk. */ -public class PreconditionFailedException extends CosmosClientException { +public class PreconditionFailedException extends CosmosException { private static final long serialVersionUID = 1L; diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RenameCollectionAwareClientRetryPolicy.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RenameCollectionAwareClientRetryPolicy.java index ede5d14fd3aaa..708857fbfb555 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RenameCollectionAwareClientRetryPolicy.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RenameCollectionAwareClientRetryPolicy.java @@ -3,7 +3,7 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.apachecommons.lang.StringUtils; import com.azure.cosmos.implementation.caches.RxClientCollectionCache; import org.slf4j.Logger; @@ -39,7 +39,7 @@ public void onBeforeSendRequest(RxDocumentServiceRequest request) { public Mono shouldRetry(Exception e) { return this.retryPolicy.shouldRetry(e).flatMap(shouldRetryResult -> { if (!shouldRetryResult.shouldRetry && !this.hasTriggered) { - CosmosClientException clientException = Utils.as(e, CosmosClientException.class); + CosmosException clientException = Utils.as(e, CosmosException.class); if (this.request == null) { // someone didn't call OnBeforeSendRequest - nothing we can do diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestEntityTooLargeException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestEntityTooLargeException.java index 7cb3c1ee3c64e..335e36eaee2c2 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestEntityTooLargeException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestEntityTooLargeException.java @@ -3,12 +3,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.util.Map; @@ -16,7 +13,7 @@ * While this class is public, but it is not part of our published public APIs. * This is meant to be internally used only by our sdk. */ -public class RequestEntityTooLargeException extends CosmosClientException { +public class RequestEntityTooLargeException extends CosmosException { private static final long serialVersionUID = 1L; RequestEntityTooLargeException() { diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestRateTooLargeException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestRateTooLargeException.java index 5c8e8f213e856..e252823da4a14 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestRateTooLargeException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestRateTooLargeException.java @@ -4,12 +4,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.net.URI; import java.util.Map; @@ -17,7 +14,7 @@ /** * The type Request rate too large exception. */ -public class RequestRateTooLargeException extends CosmosClientException { +public class RequestRateTooLargeException extends CosmosException { /** * Instantiates a new Request rate too large exception. diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestTimeoutException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestTimeoutException.java index 8a8d611356f1b..1af290b9ca9ba 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestTimeoutException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RequestTimeoutException.java @@ -4,13 +4,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; -import com.azure.cosmos.implementation.Strings; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.net.URI; import java.util.Map; @@ -18,7 +14,7 @@ /** * The type Request timeout exception. */ -public class RequestTimeoutException extends CosmosClientException { +public class RequestTimeoutException extends CosmosException { /** * Instantiates a new Request timeout exception. @@ -71,7 +67,7 @@ public RequestTimeoutException(String message, URI requestUri) { * @param requestUrl the request url */ public RequestTimeoutException(String message, HttpHeaders headers, URI requestUrl) { - super(message, + super(message, null, HttpUtils.asMap(headers), HttpConstants.StatusCodes.REQUEST_TIMEOUT, diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ResourceThrottleRetryPolicy.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ResourceThrottleRetryPolicy.java index 9fcc876113460..1242d8f8ed59c 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ResourceThrottleRetryPolicy.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ResourceThrottleRetryPolicy.java @@ -2,7 +2,7 @@ // Licensed under the MIT License. package com.azure.cosmos.implementation; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import reactor.core.publisher.Mono; @@ -55,7 +55,7 @@ public Mono shouldRetry(Exception exception) { this.currentAttemptCount++; logger.warn( "Operation will be retried after {} milliseconds. Current attempt {}, Cumulative delay {}", - retryDelay.toMillis(), + retryDelay.toMillis(), this.currentAttemptCount, this.cumulativeRetryDelay, exception); @@ -63,7 +63,7 @@ public Mono shouldRetry(Exception exception) { } else { logger.debug( "Operation will NOT be retried. Current attempt {}", - this.currentAttemptCount, + this.currentAttemptCount, exception); return Mono.just(ShouldRetryResult.noRetry()); } @@ -84,7 +84,7 @@ public void onBeforeSendRequest(RxDocumentServiceRequest request) { private Duration checkIfRetryNeeded(Exception exception) { Duration retryDelay = Duration.ZERO; - CosmosClientException dce = Utils.as(exception, CosmosClientException.class); + CosmosException dce = Utils.as(exception, CosmosException.class); if (dce != null){ diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RetryUtils.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RetryUtils.java index 432a93a9eeba7..7a891bcffbca5 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RetryUtils.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RetryUtils.java @@ -2,7 +2,7 @@ // Licensed under the MIT License. package com.azure.cosmos.implementation; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.apachecommons.lang.time.StopWatch; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -28,7 +28,7 @@ static Function, Flux> toRetryWhenFunc(IRetryPolicy policy policy.captureStartTimeIfNotSet(); Flux shouldRetryResultFlux = policy.shouldRetry(e).flux(); return shouldRetryResultFlux.flatMap(s -> { - CosmosClientException clientException = Utils.as(e, CosmosClientException.class); + CosmosException clientException = Utils.as(e, CosmosException.class); if(clientException != null) { policy.addStatusAndSubStatusCode(null, clientException.getStatusCode(), clientException.getSubStatusCode()); } @@ -75,7 +75,7 @@ public static Function> toRetryWithAlternateFunc(Function retryPolicy.captureStartTimeIfNotSet(); Flux shouldRetryResultFlux = retryPolicy.shouldRetry(e).flux(); return shouldRetryResultFlux.flatMap(shouldRetryResult -> { - CosmosClientException clientException = Utils.as(e, CosmosClientException.class); + CosmosException clientException = Utils.as(e, CosmosException.class); if(clientException != null) { retryPolicy.addStatusAndSubStatusCode(null, clientException.getStatusCode(), clientException.getSubStatusCode()); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RetryWithException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RetryWithException.java index 811853e95f931..30e04668b1fdf 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RetryWithException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RetryWithException.java @@ -4,11 +4,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.net.URI; import java.util.Map; @@ -16,7 +14,7 @@ /** * The type Retry with exception. */ -public class RetryWithException extends CosmosClientException { +public class RetryWithException extends CosmosException { /** * Instantiates a new Retry with exception. diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxGatewayStoreModel.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxGatewayStoreModel.java index 8c0771f67925f..5460d32de0ce6 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxGatewayStoreModel.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxGatewayStoreModel.java @@ -4,9 +4,8 @@ import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.apachecommons.lang.StringUtils; -import com.azure.cosmos.models.CosmosError; import com.azure.cosmos.implementation.directconnectivity.DirectBridgeInternal; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.directconnectivity.StoreResponse; @@ -15,7 +14,6 @@ import com.azure.cosmos.implementation.http.HttpRequest; import com.azure.cosmos.implementation.http.HttpResponse; import com.azure.cosmos.implementation.http.ReactorNettyRequestRecord; -import com.azure.cosmos.models.ModelBridgeInternal; import io.netty.buffer.ByteBuf; import io.netty.handler.codec.http.HttpMethod; import io.netty.handler.codec.http.HttpResponseStatus; @@ -297,17 +295,17 @@ private Mono toDocumentServiceResponse(Mono toDocumentServiceResponse(Mono processMessage(RxDocumentServiceRequest r return responseObs.onErrorResume( e -> { - CosmosClientException dce = Utils.as(e, CosmosClientException.class); + CosmosException dce = Utils.as(e, CosmosException.class); if (dce == null) { logger.error("unexpected failure {}", e.getMessage(), e); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ServiceUnavailableException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ServiceUnavailableException.java index 250276cbc26ac..562ec24705d4d 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ServiceUnavailableException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ServiceUnavailableException.java @@ -4,12 +4,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.net.URI; import java.util.Map; @@ -17,7 +14,7 @@ /** * The type Service unavailable exception. */ -public class ServiceUnavailableException extends CosmosClientException { +public class ServiceUnavailableException extends CosmosException { ServiceUnavailableException() { this(RMResources.ServiceUnavailable); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/SessionContainer.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/SessionContainer.java index c79e5cc84725d..b329bec6200a5 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/SessionContainer.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/SessionContainer.java @@ -3,7 +3,7 @@ package com.azure.cosmos.implementation; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.apachecommons.lang.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -242,7 +242,7 @@ private void updateExistingTokensInternal(ConcurrentHashMap parsedSe } } - public static void validateAndRemoveSessionToken(RxDocumentServiceRequest request) throws CosmosClientException { + public static void validateAndRemoveSessionToken(RxDocumentServiceRequest request) { String sessionToken = request.getHeaders().get(HttpConstants.HttpHeaders.SESSION_TOKEN); if (!Strings.isNullOrEmpty(sessionToken)) { getLocalSessionToken(request, sessionToken, StringUtils.EMPTY); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/UnauthorizedException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/UnauthorizedException.java index 91b2e01e2c7b8..ffa07abb4d7fe 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/UnauthorizedException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/UnauthorizedException.java @@ -4,12 +4,9 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.HttpConstants; -import com.azure.cosmos.implementation.RMResources; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.HttpUtils; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; import java.net.URI; import java.util.Map; @@ -17,7 +14,7 @@ /** * The type Unauthorized exception. */ -public class UnauthorizedException extends CosmosClientException { +public class UnauthorizedException extends CosmosException { UnauthorizedException() { this(RMResources.Unauthorized); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/VectorSessionToken.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/VectorSessionToken.java index e4f7c28bdfde4..363082e0a5804 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/VectorSessionToken.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/VectorSessionToken.java @@ -4,7 +4,6 @@ package com.azure.cosmos.implementation; -import com.azure.cosmos.CosmosClientException; import com.azure.cosmos.implementation.apachecommons.collections.map.UnmodifiableMap; import com.azure.cosmos.implementation.apachecommons.lang.ObjectUtils; import com.azure.cosmos.implementation.apachecommons.lang.StringUtils; @@ -120,7 +119,7 @@ public int hashCode() { return super.hashCode(); } - public boolean isValid(ISessionToken otherSessionToken) throws CosmosClientException { + public boolean isValid(ISessionToken otherSessionToken) { VectorSessionToken other = Utils.as(otherSessionToken, VectorSessionToken.class); if (other == null) { @@ -163,7 +162,7 @@ public boolean isValid(ISessionToken otherSessionToken) throws CosmosClientExcep } // Merge is commutative operation, so a.Merge(b).Equals(b.Merge(a)) - public ISessionToken merge(ISessionToken obj) throws CosmosClientException { + public ISessionToken merge(ISessionToken obj) { VectorSessionToken other = Utils.as(obj, VectorSessionToken.class); if (other == null) { diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java index 4a9b17e35929d..30f09c477084c 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java @@ -8,7 +8,7 @@ import com.azure.cosmos.implementation.routing.InMemoryCollectionRoutingMap; import com.azure.cosmos.implementation.routing.Range; import com.azure.cosmos.implementation.AsyncDocumentClient; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.DocumentCollection; import com.azure.cosmos.models.FeedOptions; import com.azure.cosmos.implementation.NotFoundException; @@ -64,7 +64,7 @@ public Mono> tryLookupAsync(MetadataDiag .map(Utils.ValueHolder::new) .onErrorResume(err -> { logger.debug("tryLookupAsync on collectionRid {} encountered failure", collectionRid, err); - CosmosClientException dce = Utils.as(err, CosmosClientException.class); + CosmosException dce = Utils.as(err, CosmosException.class); if (dce != null && Exceptions.isStatusCode(dce, HttpConstants.StatusCodes.NOTFOUND)) { return Mono.just(new Utils.ValueHolder<>(null)); } @@ -153,7 +153,7 @@ public Mono> tryGetRangeByPartitionKeyRange return routingMapObs.map(routingMapValueHolder -> new Utils.ValueHolder<>(routingMapValueHolder.v.getRangeByPartitionKeyRangeId(partitionKeyRangeId))) .onErrorResume(err -> { - CosmosClientException dce = Utils.as(err, CosmosClientException.class); + CosmosException dce = Utils.as(err, CosmosException.class); logger.debug("tryGetRangeByPartitionKeyRangeId on collectionRid {} and partitionKeyRangeId {} encountered failure", collectionRid, partitionKeyRangeId, err); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/DocumentServiceLeaseStore.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/DocumentServiceLeaseStore.java index 73f6b264bf05b..e042aafcc65bb 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/DocumentServiceLeaseStore.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/DocumentServiceLeaseStore.java @@ -3,7 +3,7 @@ package com.azure.cosmos.implementation.changefeed.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.CosmosItemProperties; import com.azure.cosmos.models.CosmosItemRequestOptions; import com.azure.cosmos.models.PartitionKey; @@ -56,8 +56,8 @@ public Mono isInitialized() { return this.client.readItem(markerDocId, new PartitionKey(markerDocId), requestOptions, CosmosItemProperties.class) .flatMap(documentResourceResponse -> Mono.just(BridgeInternal.getProperties(documentResourceResponse) != null)) .onErrorResume(throwable -> { - if (throwable instanceof CosmosClientException) { - CosmosClientException e = (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + CosmosException e = (CosmosException) throwable; if (e.getStatusCode() == ChangeFeedHelper.HTTP_STATUS_CODE_NOT_FOUND) { logger.info("Lease synchronization document not found"); return Mono.just(false); @@ -77,8 +77,8 @@ public Mono markInitialized() { return this.client.createItem(this.leaseCollectionLink, containerDocument, new CosmosItemRequestOptions(), false) .map( item -> true) .onErrorResume(throwable -> { - if (throwable instanceof CosmosClientException) { - CosmosClientException e = (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + CosmosException e = (CosmosException) throwable; if (e.getStatusCode() == ChangeFeedHelper.HTTP_STATUS_CODE_CONFLICT) { logger.info("Lease synchronization document was created by a different instance"); return Mono.just(true); @@ -106,8 +106,8 @@ public Mono acquireInitializationLock(Duration lockExpirationTime) { } }) .onErrorResume(throwable -> { - if (throwable instanceof CosmosClientException) { - CosmosClientException e = (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + CosmosException e = (CosmosException) throwable; if (e.getStatusCode() == ChangeFeedHelper.HTTP_STATUS_CODE_CONFLICT) { logger.info("Lease synchronization document was acquired by a different instance"); return Mono.just(false); @@ -143,8 +143,8 @@ public Mono releaseInitializationLock() { } }) .onErrorResume(throwable -> { - if (throwable instanceof CosmosClientException) { - CosmosClientException e = (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + CosmosException e = (CosmosException) throwable; if (e.getStatusCode() == ChangeFeedHelper.HTTP_STATUS_CODE_CONFLICT) { logger.info("Lease synchronization document was acquired by a different instance"); return Mono.just(false); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/DocumentServiceLeaseUpdaterImpl.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/DocumentServiceLeaseUpdaterImpl.java index e510a0ee1d313..e7ab2765acb81 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/DocumentServiceLeaseUpdaterImpl.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/DocumentServiceLeaseUpdaterImpl.java @@ -3,7 +3,7 @@ package com.azure.cosmos.implementation.changefeed.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.CosmosItemProperties; import com.azure.cosmos.models.CosmosItemRequestOptions; import com.azure.cosmos.models.PartitionKey; @@ -69,8 +69,8 @@ public Mono updateLease(final Lease cachedLease, String itemId, Partition // Partition lease update conflict. Reading the current version of lease. return this.client.readItem(itemId, partitionKey, requestOptions, CosmosItemProperties.class) .onErrorResume(throwable -> { - if (throwable instanceof CosmosClientException) { - CosmosClientException ex = (CosmosClientException) throwable; + if (throwable instanceof CosmosException) { + CosmosException ex = (CosmosException) throwable; if (ex.getStatusCode() == HTTP_STATUS_CODE_NOT_FOUND) { // Partition lease no longer exists throw new LeaseLostException(cachedLease); @@ -125,8 +125,8 @@ private Mono tryReplaceLease(Lease lease, String itemId, P return this.client.replaceItem(itemId, partitionKey, lease, this.getCreateIfMatchOptions(lease)) .map(cosmosItemResponse -> BridgeInternal.getProperties(cosmosItemResponse)) .onErrorResume(re -> { - if (re instanceof CosmosClientException) { - CosmosClientException ex = (CosmosClientException) re; + if (re instanceof CosmosException) { + CosmosException ex = (CosmosException) re; switch (ex.getStatusCode()) { case HTTP_STATUS_CODE_PRECONDITION_FAILED: { return Mono.empty(); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/ExceptionClassifier.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/ExceptionClassifier.java index 70ca36f7917c5..965796ee83609 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/ExceptionClassifier.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/ExceptionClassifier.java @@ -2,7 +2,7 @@ // Licensed under the MIT License. package com.azure.cosmos.implementation.changefeed.implementation; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; /** * Classifies exceptions based on the status codes. @@ -20,7 +20,7 @@ class ExceptionClassifier { public static final int SubStatusCode_ReadSessionNotAvailable = 1002; - public static StatusCodeErrorType classifyClientException(CosmosClientException clientException) { + public static StatusCodeErrorType classifyClientException(CosmosException clientException) { Integer subStatusCode = clientException.getSubStatusCode(); if (clientException.getStatusCode() == ChangeFeedHelper.HTTP_STATUS_CODE_NOT_FOUND && subStatusCode != SubStatusCode_ReadSessionNotAvailable) { diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/HealthMonitoringPartitionControllerDecorator.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/HealthMonitoringPartitionControllerDecorator.java index bc00aaf829ddd..c95cc0a65bfff 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/HealthMonitoringPartitionControllerDecorator.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/HealthMonitoringPartitionControllerDecorator.java @@ -2,7 +2,7 @@ // Licensed under the MIT License. package com.azure.cosmos.implementation.changefeed.implementation; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.changefeed.HealthMonitor; import com.azure.cosmos.implementation.changefeed.HealthMonitoringRecord; import com.azure.cosmos.implementation.changefeed.Lease; @@ -33,7 +33,7 @@ public HealthMonitoringPartitionControllerDecorator(PartitionController inner, H public Mono addOrUpdateLease(Lease lease) { return this.inner.addOrUpdateLease(lease) .onErrorResume(throwable -> { - if (throwable instanceof CosmosClientException) { + if (throwable instanceof CosmosException) { // do nothing. } else { monitor.inspect(new HealthMonitoringRecord( diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/LeaseStoreManagerImpl.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/LeaseStoreManagerImpl.java index ee54978c685ab..b0b8b71f4bb22 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/LeaseStoreManagerImpl.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/LeaseStoreManagerImpl.java @@ -4,7 +4,7 @@ import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.CosmosAsyncContainer; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.CosmosItemProperties; import com.azure.cosmos.models.FeedResponse; import com.azure.cosmos.models.ModelBridgeInternal; @@ -166,8 +166,8 @@ public Mono createLeaseIfNotExist(String leaseToken, String continuationT return this.leaseDocumentClient.createItem(this.settings.getLeaseCollectionLink(), documentServiceLease, null, false) .onErrorResume( ex -> { - if (ex instanceof CosmosClientException) { - CosmosClientException e = (CosmosClientException) ex; + if (ex instanceof CosmosException) { + CosmosException e = (CosmosException) ex; if (e.getStatusCode() == ChangeFeedHelper.HTTP_STATUS_CODE_CONFLICT) { logger.info("Some other host created lease for {}.", leaseToken); return Mono.empty(); @@ -202,8 +202,8 @@ public Mono delete(Lease lease) { .deleteItem(lease.getId(), new PartitionKey(lease.getId()), this.requestOptionsFactory.createRequestOptions(lease)) .onErrorResume( ex -> { - if (ex instanceof CosmosClientException) { - CosmosClientException e = (CosmosClientException) ex; + if (ex instanceof CosmosException) { + CosmosException e = (CosmosException) ex; if (e.getStatusCode() == ChangeFeedHelper.HTTP_STATUS_CODE_NOT_FOUND) { // Ignore - document was already deleted. return Mono.empty(); @@ -253,8 +253,8 @@ public Mono release(Lease lease) { this.requestOptionsFactory.createRequestOptions(lease), CosmosItemProperties.class) .onErrorResume( ex -> { - if (ex instanceof CosmosClientException) { - CosmosClientException e = (CosmosClientException) ex; + if (ex instanceof CosmosException) { + CosmosException e = (CosmosException) ex; if (e.getStatusCode() == ChangeFeedHelper.HTTP_STATUS_CODE_NOT_FOUND) { logger.info("Partition {} failed to renew lease. The lease is gone already.", lease.getLeaseToken()); throw new LeaseLostException(lease); @@ -299,8 +299,8 @@ public Mono renew(Lease lease) { this.requestOptionsFactory.createRequestOptions(lease), CosmosItemProperties.class) .onErrorResume( ex -> { - if (ex instanceof CosmosClientException) { - CosmosClientException e = (CosmosClientException) ex; + if (ex instanceof CosmosException) { + CosmosException e = (CosmosException) ex; if (e.getStatusCode() == ChangeFeedHelper.HTTP_STATUS_CODE_NOT_FOUND) { logger.info("Partition {} failed to renew lease. The lease is gone already.", lease.getLeaseToken()); throw new LeaseLostException(lease); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/PartitionProcessorImpl.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/PartitionProcessorImpl.java index 54570e6ede79a..567fc6d436e0b 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/PartitionProcessorImpl.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/changefeed/implementation/PartitionProcessorImpl.java @@ -2,9 +2,8 @@ // Licensed under the MIT License. package com.azure.cosmos.implementation.changefeed.implementation; -import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.implementation.ChangeFeedOptions; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.FeedResponse; import com.azure.cosmos.implementation.changefeed.CancellationToken; import com.azure.cosmos.implementation.changefeed.ChangeFeedContextClient; @@ -121,10 +120,10 @@ public Mono run(CancellationToken cancellationToken) { } }) .onErrorResume(throwable -> { - if (throwable instanceof CosmosClientException) { + if (throwable instanceof CosmosException) { - CosmosClientException clientException = (CosmosClientException) throwable; - logger.warn("CosmosClientException: partition {} from thread {}", + CosmosException clientException = (CosmosException) throwable; + logger.warn("CosmosException: partition {} from thread {}", this.settings.getPartitionKeyRangeId(), Thread.currentThread().getId(), clientException); StatusCodeErrorType docDbError = ExceptionClassifier.classifyClientException(clientException); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/AddressResolver.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/AddressResolver.java index 483653434b4fd..c3029c1d6a235 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/AddressResolver.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/AddressResolver.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation.directconnectivity; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.BadRequestException; import com.azure.cosmos.implementation.DocumentCollection; import com.azure.cosmos.implementation.HttpConstants; @@ -134,7 +134,7 @@ private static boolean isSameCollection(PartitionKeyRange initiallyResolved, Par * @param request Request in progress * @param targetRange Target partition key range determined by address resolver * @*/ - private void throwIfTargetChanged(RxDocumentServiceRequest request, PartitionKeyRange targetRange) throws CosmosClientException { + private void throwIfTargetChanged(RxDocumentServiceRequest request, PartitionKeyRange targetRange) { // If new range is child of previous range, we don't need to throw any exceptions // as LSNs are continued on child ranges. if (request.requestContext.resolvedPartitionKeyRange != null && @@ -155,7 +155,7 @@ private void throwIfTargetChanged(RxDocumentServiceRequest request, PartitionKey private static void ensureRoutingMapPresent( RxDocumentServiceRequest request, CollectionRoutingMap routingMap, - DocumentCollection collection) throws CosmosClientException { + DocumentCollection collection) { if (routingMap == null && request.getIsNameBased() && request.getPartitionKeyRangeIdentity() != null && request.getPartitionKeyRangeIdentity().getCollectionRid() != null) { // By design, if partitionkeyrangeid header is present and it contains collectionrid for collection @@ -266,7 +266,7 @@ private Mono> tryResolveServerPartitionAsync private PartitionKeyRange tryResolveSinglePartitionCollection( RxDocumentServiceRequest request, CollectionRoutingMap routingMap, - boolean collectionCacheIsUptoDate) throws CosmosClientException { + boolean collectionCacheIsUptoDate) { // Neither partitionkey nor partitionkeyrangeid is specified. // Three options here: // * This is non-partitioned collection and old client SDK which doesn't send partition key. In @@ -552,7 +552,7 @@ private ResolutionResult handleRangeAddressResolutionFailure( RxDocumentServiceRequest request, boolean collectionCacheIsUpToDate, boolean routingMapCacheIsUpToDate, - CollectionRoutingMap routingMap) throws CosmosClientException { + CollectionRoutingMap routingMap) { // Optimization to not refresh routing map unnecessary. As we keep track of parent child relationships, // we can determine that a range is gone just by looking up in the routing map. if (collectionCacheIsUpToDate && routingMapCacheIsUpToDate || @@ -603,7 +603,7 @@ private Mono> tryResolveServerPartitionByPar } try { return Mono.just(new Utils.ValueHolder<>(this.handleRangeAddressResolutionFailure(request, collectionCacheIsUpToDate, routingMapCacheIsUpToDate, routingMap))); - } catch (CosmosClientException e) { + } catch (CosmosException e) { return Mono.error(e); } } @@ -616,7 +616,7 @@ private PartitionKeyRange tryResolveServerPartitionByPartitionKey( PartitionKeyInternal partitionKey, boolean collectionCacheUptoDate, DocumentCollection collection, - CollectionRoutingMap routingMap) throws CosmosClientException { + CollectionRoutingMap routingMap) { if (request == null) { throw new NullPointerException("request"); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyReader.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyReader.java index 7d4315380f2c5..e09b659886078 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyReader.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyReader.java @@ -5,7 +5,7 @@ import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.GoneException; import com.azure.cosmos.implementation.ISessionContainer; import com.azure.cosmos.implementation.NotFoundException; @@ -200,7 +200,7 @@ public Mono readAsync(RxDocumentServiceRequest entity, ReadMode desiredReadMode; try { desiredReadMode = this.deduceReadMode(entity, targetConsistencyLevel, useSessionToken); - } catch (CosmosClientException e) { + } catch (CosmosException e) { return Mono.error(e); } int maxReplicaCount = this.getMaxReplicaSetSize(entity); @@ -251,7 +251,7 @@ private Mono readPrimaryAsync(RxDocumentServiceRequest entity, return responseObs.flatMap(response -> { try { return Mono.just(response.toResponse()); - } catch (CosmosClientException e) { + } catch (CosmosException e) { return Mono.error(e); } }); @@ -275,7 +275,7 @@ private Mono readAnyAsync(RxDocumentServiceRequest entity, try { return Mono.just(responses.get(0).toResponse()); - } catch (CosmosClientException e) { + } catch (CosmosException e) { return Mono.error(e); } } @@ -313,10 +313,10 @@ private Mono readSessionAsync(RxDocumentServiceRequest entity, notFoundException.getResponseHeaders().put(WFConstants.BackendHeaders.SUB_STATUS, Integer.toString(HttpConstants.SubStatusCodes.READ_SESSION_NOT_AVAILABLE)); } return Mono.error(notFoundException); - } catch (CosmosClientException e) { + } catch (CosmosException e) { return Mono.error(e); } - } catch (CosmosClientException dce) { + } catch (CosmosException dce) { return Mono.error(dce); } @@ -333,7 +333,7 @@ private Mono readSessionAsync(RxDocumentServiceRequest entity, ReadMode deduceReadMode(RxDocumentServiceRequest request, ValueHolder targetConsistencyLevel, - ValueHolder useSessionToken) throws CosmosClientException { + ValueHolder useSessionToken) { targetConsistencyLevel.v = RequestHelper.getConsistencyLevelToUse(this.serviceConfigReader, request); useSessionToken.v = (targetConsistencyLevel.v == ConsistencyLevel.SESSION); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyWriter.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyWriter.java index f0ab2fe4c02b2..192b77af6f046 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyWriter.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyWriter.java @@ -5,7 +5,7 @@ import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.GoneException; import com.azure.cosmos.implementation.HttpConstants; import com.azure.cosmos.implementation.IAuthorizationTokenProvider; @@ -166,7 +166,7 @@ Mono writePrivateAsync( t -> { try { Throwable unwrappedException = Exceptions.unwrap(t); - CosmosClientException ex = Utils.as(unwrappedException, CosmosClientException.class); + CosmosException ex = Utils.as(unwrappedException, CosmosException.class); try { BridgeInternal.recordResponse(request.requestContext.cosmosDiagnostics, request, storeReader.createStoreResult(null, ex, false, false, primaryUri)); @@ -279,7 +279,7 @@ Mono barrierForGlobalStrong(RxDocumentServiceRequest request, Sto return Mono.just(response); } - } catch (CosmosClientException e) { + } catch (CosmosException e) { // RxJava1 doesn't allow throwing checked exception from Observable operators return Mono.error(e); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/GatewayAddressCache.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/GatewayAddressCache.java index 7e6094382861f..c5b508ae94174 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/GatewayAddressCache.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/GatewayAddressCache.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation.directconnectivity; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.AuthorizationTokenType; import com.azure.cosmos.implementation.Constants; import com.azure.cosmos.implementation.DocumentCollection; @@ -219,7 +219,7 @@ public Mono> tryGetAddresses(RxDocumentS return addressesValueHolder; }).onErrorResume(ex -> { Throwable unwrappedException = reactor.core.Exceptions.unwrap(ex); - CosmosClientException dce = Utils.as(unwrappedException, CosmosClientException.class); + CosmosException dce = Utils.as(unwrappedException, CosmosException.class); if (dce == null) { logger.error("unexpected failure", ex); if (forceRefreshPartitionAddressesModified) { diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/GoneAndRetryWithRetryPolicy.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/GoneAndRetryWithRetryPolicy.java index 49fd02786ad61..d202b9261ae2c 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/GoneAndRetryWithRetryPolicy.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/GoneAndRetryWithRetryPolicy.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation.directconnectivity; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.GoneException; import com.azure.cosmos.implementation.HttpConstants; import com.azure.cosmos.implementation.InvalidPartitionException; @@ -53,7 +53,7 @@ public GoneAndRetryWithRetryPolicy(RxDocumentServiceRequest request, Integer wai @Override public Mono shouldRetry(Exception exception) { - CosmosClientException exceptionToThrow = null; + CosmosException exceptionToThrow = null; Duration backoffTime = Duration.ofSeconds(0); Duration timeout = Duration.ofSeconds(0); boolean forceRefreshAddressCache = false; @@ -85,7 +85,7 @@ public Mono shouldRetry(Exception exception) { } else { logger.warn("Received gone exception after backoff/retry. Will fail the request. {}", exception.toString()); - exceptionToThrow = BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.SERVICE_UNAVAILABLE, + exceptionToThrow = BridgeInternal.createCosmosException(HttpConstants.StatusCodes.SERVICE_UNAVAILABLE, exception); } @@ -100,7 +100,7 @@ public Mono shouldRetry(Exception exception) { logger.warn( "Received partition key range gone exception after backoff/retry. Will fail the request. {}", exception.toString()); - exceptionToThrow = BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.SERVICE_UNAVAILABLE, + exceptionToThrow = BridgeInternal.createCosmosException(HttpConstants.StatusCodes.SERVICE_UNAVAILABLE, exception); } } else if (exception instanceof InvalidPartitionException) { @@ -113,7 +113,7 @@ public Mono shouldRetry(Exception exception) { logger.warn( "Received invalid collection partition exception after backoff/retry. Will fail the request. {}", exception.toString()); - exceptionToThrow = BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.SERVICE_UNAVAILABLE, + exceptionToThrow = BridgeInternal.createCosmosException(HttpConstants.StatusCodes.SERVICE_UNAVAILABLE, exception); } } else { @@ -151,7 +151,7 @@ public Mono shouldRetry(Exception exception) { logger.warn("Received second InvalidPartitionException after backoff/retry. Will fail the request. {}", exception.toString()); return Mono.just(ShouldRetryResult - .error(BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.SERVICE_UNAVAILABLE, exception))); + .error(BridgeInternal.createCosmosException(HttpConstants.StatusCodes.SERVICE_UNAVAILABLE, exception))); } if (this.request != null) { @@ -161,7 +161,7 @@ public Mono shouldRetry(Exception exception) { logger.error("Received unexpected invalid collection exception, request should be non-null.", exception); return Mono.just(ShouldRetryResult - .error(BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.INTERNAL_SERVER_ERROR, exception))); + .error(BridgeInternal.createCosmosException(HttpConstants.StatusCodes.INTERNAL_SERVER_ERROR, exception))); } forceRefreshAddressCache = false; } else if (exception instanceof PartitionKeyRangeIsSplittingException) { diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/HttpClientUtils.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/HttpClientUtils.java index ef013dca27402..da356d6df777f 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/HttpClientUtils.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/HttpClientUtils.java @@ -4,14 +4,13 @@ package com.azure.cosmos.implementation.directconnectivity; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.implementation.apachecommons.lang.StringUtils; -import com.azure.cosmos.models.CosmosError; +import com.azure.cosmos.CosmosException; +import com.azure.cosmos.implementation.CosmosError; import com.azure.cosmos.implementation.HttpConstants; import com.azure.cosmos.implementation.RxDocumentServiceResponse; +import com.azure.cosmos.implementation.apachecommons.lang.StringUtils; import com.azure.cosmos.implementation.http.HttpRequest; import com.azure.cosmos.implementation.http.HttpResponse; -import com.azure.cosmos.models.ModelBridgeInternal; import reactor.core.publisher.Mono; public class HttpClientUtils { @@ -32,14 +31,14 @@ static Mono parseResponseAsync(Mono htt }); } - private static Mono createDocumentClientException(HttpResponse httpResponse) { + private static Mono createDocumentClientException(HttpResponse httpResponse) { Mono readStream = httpResponse.bodyAsString().switchIfEmpty(Mono.just(StringUtils.EMPTY)); return readStream.map(body -> { - CosmosError cosmosError = ModelBridgeInternal.createCosmosError(body); + CosmosError cosmosError = new CosmosError(body); // TODO: we should set resource address in the Document Client Exception - return BridgeInternal.createCosmosClientException(httpResponse.statusCode(), cosmosError, + return BridgeInternal.createCosmosException(httpResponse.statusCode(), cosmosError, httpResponse.headers().toMap()); }); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/HttpTransportClient.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/HttpTransportClient.java index 60cf7e3b909d6..b66c234423173 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/HttpTransportClient.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/HttpTransportClient.java @@ -6,7 +6,7 @@ import com.azure.cosmos.implementation.BadRequestException; import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.implementation.ConflictException; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.ConnectionPolicy; import com.azure.cosmos.implementation.ForbiddenException; import com.azure.cosmos.implementation.GoneException; @@ -724,7 +724,7 @@ private Mono createErrorResponseFromHttpResponse(String resourceA responsePartitionKeyRangeId = Lists.firstOrDefault(partitionKeyRangeIdValues, null); } - CosmosClientException exception; + CosmosException exception; switch (statusCode) { case HttpConstants.StatusCodes.UNAUTHORIZED: diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/QuorumReader.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/QuorumReader.java index 0c1df639fc4a8..36bdf6f9a3bb6 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/QuorumReader.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/QuorumReader.java @@ -5,7 +5,7 @@ import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.GoneException; import com.azure.cosmos.implementation.InternalServerErrorException; import com.azure.cosmos.implementation.Configs; @@ -141,7 +141,7 @@ public Mono readStrongAsync( case QuorumMet: try { return Flux.just(secondaryQuorumReadResult.getResponse()); - } catch (CosmosClientException e) { + } catch (CosmosException e) { return Flux.error(e); } @@ -209,7 +209,7 @@ public Mono readStrongAsync( logger.debug("QuorumNotSelected: ReadPrimary successful"); try { return Flux.just(response.getResponse()); - } catch (CosmosClientException e) { + } catch (CosmosException e) { return Flux.error(e); } } else if (response.shouldRetryOnSecondary) { @@ -720,7 +720,7 @@ protected ReadResult(RequestChargeTracker requestChargeTracker, StoreResult resp this.response = response; } - public StoreResponse getResponse() throws CosmosClientException { + public StoreResponse getResponse() { if (!this.isValidResult()) { logger.error("getResponse called for invalid result"); throw new InternalServerErrorException(RMResources.InternalServerError); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/RequestHelper.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/RequestHelper.java index e66e07a090522..810f50578a312 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/RequestHelper.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/RequestHelper.java @@ -4,9 +4,8 @@ package com.azure.cosmos.implementation.directconnectivity; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.implementation.BadRequestException; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.implementation.BadRequestException; import com.azure.cosmos.implementation.HttpConstants; import com.azure.cosmos.implementation.RMResources; import com.azure.cosmos.implementation.RxDocumentServiceRequest; @@ -14,7 +13,7 @@ public class RequestHelper { public static ConsistencyLevel getConsistencyLevelToUse(GatewayServiceConfigurationReader serviceConfigReader, - RxDocumentServiceRequest request) throws CosmosClientException { + RxDocumentServiceRequest request) { ConsistencyLevel consistencyLevelToUse = serviceConfigReader.getDefaultConsistencyLevel(); String requestConsistencyLevelHeaderValue = request.getHeaders().get(HttpConstants.HttpHeaders.CONSISTENCY_LEVEL); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreClient.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreClient.java index 4f12a9654ee3b..b9c7275a287cf 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreClient.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreClient.java @@ -5,7 +5,7 @@ import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.InternalServerErrorException; import com.azure.cosmos.implementation.BackoffRetryUtility; import com.azure.cosmos.implementation.Configs; @@ -89,7 +89,7 @@ public Mono processMessageAsync(RxDocumentServiceRequ storeResponse = storeResponse.doOnError(e -> { try { Throwable unwrappedException = reactor.core.Exceptions.unwrap(e); - CosmosClientException exception = Utils.as(unwrappedException, CosmosClientException.class); + CosmosException exception = Utils.as(unwrappedException, CosmosException.class); if (exception == null) { return; @@ -115,7 +115,7 @@ public Mono processMessageAsync(RxDocumentServiceRequ }); } - private void handleUnsuccessfulStoreResponse(RxDocumentServiceRequest request, CosmosClientException exception) { + private void handleUnsuccessfulStoreResponse(RxDocumentServiceRequest request, CosmosException exception) { this.updateResponseHeader(request, exception.getResponseHeaders()); if ((!ReplicatedResourceClient.isMasterResource(request.getResourceType())) && (Exceptions.isStatusCode(exception, HttpConstants.StatusCodes.PRECONDITION_FAILED) || Exceptions.isStatusCode(exception, HttpConstants.StatusCodes.CONFLICT) || diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreReader.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreReader.java index 5d279cbedf679..b2dcf16676495 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreReader.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreReader.java @@ -5,7 +5,7 @@ import com.azure.cosmos.implementation.BadRequestException; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.GoneException; import com.azure.cosmos.implementation.InternalServerErrorException; import com.azure.cosmos.implementation.PartitionIsMigratingException; @@ -291,7 +291,7 @@ private ReadReplicaResult createReadReplicaResult(List responseResu int replicaCountToRead, int resolvedAddressCount, boolean hasGoneException, - RxDocumentServiceRequest entity) throws CosmosClientException { + RxDocumentServiceRequest entity) { if (responseResult.size() < replicaCountToRead) { if (logger.isDebugEnabled()) { logger.debug("Could not get quorum number of responses. " + @@ -528,14 +528,14 @@ private Mono readPrimaryInternalAsync( true, storeResponse != null ? storeResponseObsAndUri.getRight() : null); return Mono.just(storeResult); - } catch (CosmosClientException e) { + } catch (CosmosException e) { return Mono.error(e); } } ); - } catch (CosmosClientException e) { + } catch (CosmosException e) { // RxJava1 doesn't allow throwing checked exception from Observable:map return Mono.error(e); } @@ -557,7 +557,7 @@ private Mono readPrimaryInternalAsync( true, null); return Mono.just(storeResult); - } catch (CosmosClientException e) { + } catch (CosmosException e) { // RxJava1 doesn't allow throwing checked exception from Observable operators return Mono.error(e); } @@ -581,7 +581,7 @@ private Mono readPrimaryInternalAsync( private Pair, Uri> readFromStoreAsync( Uri physicalAddress, - RxDocumentServiceRequest request) throws CosmosClientException { + RxDocumentServiceRequest request) { if (request.requestContext.timeoutHelper.isElapsed()) { throw new GoneException(); @@ -660,7 +660,7 @@ StoreResult createStoreResult(StoreResponse storeResponse, Exception responseException, boolean requiresValidLsn, boolean useLocalLSNBasedHeaders, - Uri storePhysicalAddress) throws CosmosClientException { + Uri storePhysicalAddress) { if (responseException == null) { String headerValue = null; @@ -734,78 +734,78 @@ StoreResult createStoreResult(StoreResponse storeResponse, /* getSessionToken: */ sessionToken); } else { Throwable unwrappedResponseExceptions = Exceptions.unwrap(responseException); - CosmosClientException cosmosClientException = Utils.as(unwrappedResponseExceptions, CosmosClientException.class); - if (cosmosClientException != null) { - StoreReader.verifyCanContinueOnException(cosmosClientException); + CosmosException cosmosException = Utils.as(unwrappedResponseExceptions, CosmosException.class); + if (cosmosException != null) { + StoreReader.verifyCanContinueOnException(cosmosException); long quorumAckedLSN = -1; int currentReplicaSetSize = -1; int currentWriteQuorum = -1; long globalCommittedLSN = -1; int numberOfReadRegions = -1; - String headerValue = cosmosClientException.getResponseHeaders().get(useLocalLSNBasedHeaders ? WFConstants.BackendHeaders.QUORUM_ACKED_LOCAL_LSN : WFConstants.BackendHeaders.QUORUM_ACKED_LSN); + String headerValue = cosmosException.getResponseHeaders().get(useLocalLSNBasedHeaders ? WFConstants.BackendHeaders.QUORUM_ACKED_LOCAL_LSN : WFConstants.BackendHeaders.QUORUM_ACKED_LSN); if (!Strings.isNullOrEmpty(headerValue)) { quorumAckedLSN = Long.parseLong(headerValue); } - headerValue = cosmosClientException.getResponseHeaders().get(WFConstants.BackendHeaders.CURRENT_REPLICA_SET_SIZE); + headerValue = cosmosException.getResponseHeaders().get(WFConstants.BackendHeaders.CURRENT_REPLICA_SET_SIZE); if (!Strings.isNullOrEmpty(headerValue)) { currentReplicaSetSize = Integer.parseInt(headerValue); } - headerValue = cosmosClientException.getResponseHeaders().get(WFConstants.BackendHeaders.CURRENT_WRITE_QUORUM); + headerValue = cosmosException.getResponseHeaders().get(WFConstants.BackendHeaders.CURRENT_WRITE_QUORUM); if (!Strings.isNullOrEmpty(headerValue)) { currentReplicaSetSize = Integer.parseInt(headerValue); } double requestCharge = 0; - headerValue = cosmosClientException.getResponseHeaders().get(HttpConstants.HttpHeaders.REQUEST_CHARGE); + headerValue = cosmosException.getResponseHeaders().get(HttpConstants.HttpHeaders.REQUEST_CHARGE); if (!Strings.isNullOrEmpty(headerValue)) { requestCharge = Double.parseDouble(headerValue); } - headerValue = cosmosClientException.getResponseHeaders().get(WFConstants.BackendHeaders.NUMBER_OF_READ_REGIONS); + headerValue = cosmosException.getResponseHeaders().get(WFConstants.BackendHeaders.NUMBER_OF_READ_REGIONS); if (!Strings.isNullOrEmpty(headerValue)) { numberOfReadRegions = Integer.parseInt(headerValue); } - headerValue = cosmosClientException.getResponseHeaders().get(WFConstants.BackendHeaders.GLOBAL_COMMITTED_LSN); + headerValue = cosmosException.getResponseHeaders().get(WFConstants.BackendHeaders.GLOBAL_COMMITTED_LSN); if (!Strings.isNullOrEmpty(headerValue)) { globalCommittedLSN = Integer.parseInt(headerValue); } long lsn = -1; if (useLocalLSNBasedHeaders) { - headerValue = cosmosClientException.getResponseHeaders().get(WFConstants.BackendHeaders.LOCAL_LSN); + headerValue = cosmosException.getResponseHeaders().get(WFConstants.BackendHeaders.LOCAL_LSN); if (!Strings.isNullOrEmpty(headerValue)) { lsn = Long.parseLong(headerValue); } } else { - lsn = BridgeInternal.getLSN(cosmosClientException); + lsn = BridgeInternal.getLSN(cosmosException); } ISessionToken sessionToken = null; // SESSION token response header is introduced from getVersion HttpConstants.Versions.v2018_06_18 onwards. // Previously it was only a request header - headerValue = cosmosClientException.getResponseHeaders().get(HttpConstants.HttpHeaders.SESSION_TOKEN); + headerValue = cosmosException.getResponseHeaders().get(HttpConstants.HttpHeaders.SESSION_TOKEN); if (!Strings.isNullOrEmpty(headerValue)) { sessionToken = SessionTokenHelper.parse(headerValue); } return new StoreResult( /* storeResponse: */ (StoreResponse) null, - /* exception: */ cosmosClientException, - /* partitionKeyRangeId: */BridgeInternal.getPartitionKeyRangeId(cosmosClientException), + /* exception: */ cosmosException, + /* partitionKeyRangeId: */BridgeInternal.getPartitionKeyRangeId(cosmosException), /* lsn: */ lsn, /* quorumAckedLsn: */ quorumAckedLSN, /* getRequestCharge: */ requestCharge, /* currentReplicaSetSize: */ currentReplicaSetSize, /* currentWriteQuorum: */ currentWriteQuorum, /* isValid: */!requiresValidLsn - || ((cosmosClientException.getStatusCode() != HttpConstants.StatusCodes.GONE || isSubStatusCode(cosmosClientException, HttpConstants.SubStatusCodes.NAME_CACHE_IS_STALE)) + || ((cosmosException.getStatusCode() != HttpConstants.StatusCodes.GONE || isSubStatusCode(cosmosException, HttpConstants.SubStatusCodes.NAME_CACHE_IS_STALE)) && lsn >= 0), // TODO: verify where exception.RequestURI is supposed to be set in .Net - /* storePhysicalAddress: */ storePhysicalAddress == null ? BridgeInternal.getRequestUri(cosmosClientException) : storePhysicalAddress, + /* storePhysicalAddress: */ storePhysicalAddress == null ? BridgeInternal.getRequestUri(cosmosException) : storePhysicalAddress, /* globalCommittedLSN: */ globalCommittedLSN, /* numberOfReadRegions: */ numberOfReadRegions, /* itemLSN: */ -1, @@ -848,7 +848,7 @@ private static int generateNextRandom(int maxValue) { return ThreadLocalRandom.current().nextInt(maxValue); } - static void verifyCanContinueOnException(CosmosClientException ex) throws CosmosClientException { + static void verifyCanContinueOnException(CosmosException ex) { if (ex instanceof PartitionKeyRangeGoneException) { throw ex; } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreResult.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreResult.java index 6196fa7780fde..0c7bd9ff8b9e7 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreResult.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/StoreResult.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation.directconnectivity; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.InternalServerErrorException; import com.azure.cosmos.implementation.Exceptions; import com.azure.cosmos.implementation.HttpConstants; @@ -24,7 +24,7 @@ public class StoreResult { private final static Logger logger = LoggerFactory.getLogger(StoreResult.class); private final StoreResponse storeResponse; - private final CosmosClientException exception; + private final CosmosException exception; final public long lsn; final public String partitionKeyRangeId; @@ -44,7 +44,7 @@ public class StoreResult { public StoreResult( StoreResponse storeResponse, - CosmosClientException exception, + CosmosException exception, String partitionKeyRangeId, long lsn, long quorumAckedLsn, @@ -77,7 +77,7 @@ public StoreResult( this.sessionToken = sessionToken; } - public CosmosClientException getException() throws InternalServerErrorException { + public CosmosException getException() throws InternalServerErrorException { if (this.exception == null) { String message = "Exception should be available but found none"; assert false : message; @@ -88,11 +88,11 @@ public CosmosClientException getException() throws InternalServerErrorException return exception; } - public StoreResponse toResponse() throws CosmosClientException { + public StoreResponse toResponse() { return toResponse(null); } - public StoreResponse toResponse(RequestChargeTracker requestChargeTracker) throws CosmosClientException { + public StoreResponse toResponse(RequestChargeTracker requestChargeTracker) { if (!this.isValid) { if (this.exception == null) { logger.error("Exception not set for invalid response"); @@ -113,9 +113,9 @@ public StoreResponse toResponse(RequestChargeTracker requestChargeTracker) throw return this.storeResponse; } - private static void setRequestCharge(StoreResponse response, CosmosClientException cosmosClientException, double totalRequestCharge) { - if (cosmosClientException != null) { - cosmosClientException.getResponseHeaders().put(HttpConstants.HttpHeaders.REQUEST_CHARGE, + private static void setRequestCharge(StoreResponse response, CosmosException cosmosException, double totalRequestCharge) { + if (cosmosException != null) { + cosmosException.getResponseHeaders().put(HttpConstants.HttpHeaders.REQUEST_CHARGE, Double.toString(totalRequestCharge)); } // Set total charge as final charge for the response. diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdContextException.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdContextException.java index 14b38b87c738c..a6b5163cba4ff 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdContextException.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdContextException.java @@ -3,9 +3,8 @@ package com.azure.cosmos.implementation.directconnectivity.rntbd; +import com.azure.cosmos.implementation.CosmosError; import com.azure.cosmos.implementation.directconnectivity.TransportException; -import com.azure.cosmos.models.CosmosError; -import com.azure.cosmos.models.ModelBridgeInternal; import com.fasterxml.jackson.databind.node.ObjectNode; import io.netty.handler.codec.http.HttpResponseStatus; @@ -21,7 +20,7 @@ public final class RntbdContextException extends TransportException { super(status + ": " + details, null); - this.cosmosError = ModelBridgeInternal.createCosmosError(details); + this.cosmosError = new CosmosError(details); this.responseHeaders = responseHeaders; this.status = status; } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdRequestManager.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdRequestManager.java index 685276600761f..eab12a2d7e4bd 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdRequestManager.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdRequestManager.java @@ -4,9 +4,10 @@ package com.azure.cosmos.implementation.directconnectivity.rntbd; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.BadRequestException; import com.azure.cosmos.implementation.ConflictException; +import com.azure.cosmos.implementation.CosmosError; import com.azure.cosmos.implementation.ForbiddenException; import com.azure.cosmos.implementation.GoneException; import com.azure.cosmos.implementation.InternalServerErrorException; @@ -25,8 +26,6 @@ import com.azure.cosmos.implementation.ServiceUnavailableException; import com.azure.cosmos.implementation.UnauthorizedException; import com.azure.cosmos.implementation.directconnectivity.StoreResponse; -import com.azure.cosmos.models.CosmosError; -import com.azure.cosmos.models.ModelBridgeInternal; import io.netty.buffer.ByteBuf; import io.netty.channel.Channel; import io.netty.channel.ChannelException; @@ -714,9 +713,9 @@ private void messageReceived(final ChannelHandlerContext context, final RntbdRes } else { - // Map response to a CosmosClientException + // Map response to a CosmosException - final CosmosClientException cause; + final CosmosException cause; // ..Fetch required header values @@ -726,7 +725,7 @@ private void messageReceived(final ChannelHandlerContext context, final RntbdRes // ..Create Error instance final CosmosError error = response.hasPayload() - ? ModelBridgeInternal.createCosmosError(RntbdObjectMapper.readTree(response)) + ? new CosmosError(RntbdObjectMapper.readTree(response)) : new CosmosError(Integer.toString(statusCode), status.reasonPhrase(), status.codeClass().name()); // ..Map RNTBD response headers to HTTP response headers @@ -735,7 +734,7 @@ private void messageReceived(final ChannelHandlerContext context, final RntbdRes this.rntbdContext().orElseThrow(IllegalStateException::new), activityId ); - // ..Create CosmosClientException based on status and sub-status codes + // ..Create CosmosException based on status and sub-status codes switch (status.code()) { @@ -819,7 +818,7 @@ private void messageReceived(final ChannelHandlerContext context, final RntbdRes break; default: - cause = BridgeInternal.createCosmosClientException(status.code(), error, responseHeaders); + cause = BridgeInternal.createCosmosException(status.code(), error, responseHeaders); break; } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/DistinctDocumentQueryExecutionContext.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/DistinctDocumentQueryExecutionContext.java index 77f67aa3708df..2faf63f5c6614 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/DistinctDocumentQueryExecutionContext.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/DistinctDocumentQueryExecutionContext.java @@ -3,7 +3,7 @@ package com.azure.cosmos.implementation.query; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.BadRequestException; import com.azure.cosmos.implementation.HttpConstants; import com.azure.cosmos.implementation.Utils; @@ -56,7 +56,7 @@ public static Flux> cre } else { distinctContinuationToken = outDistinctcontinuationtoken.v; if (distinctQueryType != DistinctQueryType.ORDERED && distinctContinuationToken.getLastHash() != null) { - CosmosClientException dce = new BadRequestException("DistinctContinuationToken is malformed." + + CosmosException dce = new BadRequestException("DistinctContinuationToken is malformed." + " DistinctContinuationToken can not" + " have a 'lastHash', when the query" + " type is not ordered (ex SELECT " + diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/DocumentProducer.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/DocumentProducer.java index 5240c2c54981f..3663cf5c0c06d 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/DocumentProducer.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/DocumentProducer.java @@ -3,7 +3,7 @@ package com.azure.cosmos.implementation.query; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.FeedOptions; import com.azure.cosmos.models.FeedResponse; import com.azure.cosmos.models.ModelBridgeInternal; @@ -178,7 +178,7 @@ public Flux produceAsync() { private Flux splitProof(Flux sourceFeedResponseObservable) { return sourceFeedResponseObservable.onErrorResume( t -> { - CosmosClientException dce = Utils.as(t, CosmosClientException.class); + CosmosException dce = Utils.as(t, CosmosException.class); if (dce == null || !isSplit(dce)) { logger.error("Unexpected failure", t); return Flux.error(t); @@ -246,7 +246,7 @@ private Mono>> getReplacementRanges(Ra return client.getPartitionKeyRangeCache().tryGetOverlappingRangesAsync(null, collectionRid, range, true, feedOptions.getProperties()); } - private boolean isSplit(CosmosClientException e) { + private boolean isSplit(CosmosException e) { return Exceptions.isPartitionSplit(e); } } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/OrderByDocumentQueryExecutionContext.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/OrderByDocumentQueryExecutionContext.java index d5557cd404e93..7862f3670e7ae 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/OrderByDocumentQueryExecutionContext.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/OrderByDocumentQueryExecutionContext.java @@ -3,7 +3,7 @@ package com.azure.cosmos.implementation.query; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.apachecommons.lang.NotImplementedException; import com.azure.cosmos.models.FeedOptions; import com.azure.cosmos.models.FeedResponse; @@ -111,7 +111,7 @@ public static Flux> cre feedOptions.getRequestContinuation()); return Flux.just(context); - } catch (CosmosClientException dce) { + } catch (CosmosException dce) { return Flux.error(dce); } } @@ -121,7 +121,7 @@ private void initialize( List sortOrders, Collection orderByExpressions, int initialPageSize, - String continuationToken) throws CosmosClientException { + String continuationToken) throws CosmosException { if (continuationToken == null) { // First iteration so use null continuation tokens and "true" filters Map partitionKeyRangeToContinuationToken = new HashMap(); @@ -144,7 +144,7 @@ private void initialize( outOrderByContinuationToken)) { String message = String.format("INVALID JSON in continuation token %s for OrderBy~Context", continuationToken); - throw BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.BADREQUEST, + throw BridgeInternal.createCosmosException(HttpConstants.StatusCodes.BADREQUEST, message); } @@ -156,7 +156,7 @@ private void initialize( if (compositeContinuationToken.getRange().isEmpty()) { String message = String.format("INVALID RANGE in the continuation token %s for OrderBy~Context.", continuationToken); - throw BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.BADREQUEST, + throw BridgeInternal.createCosmosException(HttpConstants.StatusCodes.BADREQUEST, message); } @@ -233,7 +233,7 @@ private ImmutablePair getFiltersForPartitions( OrderByContinuationToken orderByContinuationToken, List partitionKeyRanges, List sortOrders, - Collection orderByExpressions) throws CosmosClientException { + Collection orderByExpressions) { // Find the partition key range we left off on int startIndex = this.findTargetRangeAndExtractContinuationTokens(partitionKeyRanges, orderByContinuationToken.getCompositeContinuationToken().getRange()); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/ParallelDocumentQueryExecutionContext.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/ParallelDocumentQueryExecutionContext.java index 21869ffdfe42b..56bac1f5e38ca 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/ParallelDocumentQueryExecutionContext.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/ParallelDocumentQueryExecutionContext.java @@ -3,7 +3,7 @@ package com.azure.cosmos.implementation.query; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.FeedOptions; import com.azure.cosmos.models.FeedResponse; import com.azure.cosmos.implementation.Resource; @@ -91,7 +91,7 @@ public static Flux> cre initialPageSize, feedOptions.getRequestContinuation()); return Flux.just(context); - } catch (CosmosClientException dce) { + } catch (CosmosException dce) { return Flux.error(dce); } } @@ -130,7 +130,7 @@ private void initialize( String collectionRid, List targetRanges, int initialPageSize, - String continuationToken) throws CosmosClientException { + String continuationToken) { // Generate the corresponding continuation token map. Map partitionKeyRangeToContinuationTokenMap = new HashMap(); if (continuationToken == null) { @@ -156,7 +156,7 @@ private void initialize( outCompositeContinuationToken)) { String message = String.format("INVALID JSON in continuation token %s for Parallel~Context", continuationToken); - throw BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.BADREQUEST, + throw BridgeInternal.createCosmosException(HttpConstants.StatusCodes.BADREQUEST, message); } @@ -187,7 +187,7 @@ private void initialize( private List getPartitionKeyRangesForContinuation( CompositeContinuationToken compositeContinuationToken, - List partitionKeyRanges) throws CosmosClientException { + List partitionKeyRanges) { // Find the partition key range we left off on int startIndex = this.findTargetRangeAndExtractContinuationTokens(partitionKeyRanges, compositeContinuationToken.getRange()); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/ParallelDocumentQueryExecutionContextBase.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/ParallelDocumentQueryExecutionContextBase.java index 26400038dff76..6d7a79acf00a6 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/ParallelDocumentQueryExecutionContextBase.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/ParallelDocumentQueryExecutionContextBase.java @@ -3,20 +3,19 @@ package com.azure.cosmos.implementation.query; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.models.FeedOptions; -import com.azure.cosmos.models.FeedResponse; -import com.azure.cosmos.models.PartitionKey; -import com.azure.cosmos.implementation.Resource; -import com.azure.cosmos.models.SqlQuerySpec; import com.azure.cosmos.implementation.DocumentClientRetryPolicy; import com.azure.cosmos.implementation.HttpConstants; import com.azure.cosmos.implementation.PartitionKeyRange; +import com.azure.cosmos.implementation.Resource; import com.azure.cosmos.implementation.ResourceType; import com.azure.cosmos.implementation.RxDocumentServiceRequest; import com.azure.cosmos.implementation.Strings; import com.azure.cosmos.implementation.routing.PartitionKeyInternal; import com.azure.cosmos.implementation.routing.Range; +import com.azure.cosmos.models.FeedOptions; +import com.azure.cosmos.models.FeedResponse; +import com.azure.cosmos.models.PartitionKey; +import com.azure.cosmos.models.SqlQuerySpec; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import reactor.core.publisher.Flux; @@ -102,7 +101,7 @@ protected void initialize(String collectionRid, } protected int findTargetRangeAndExtractContinuationTokens( - List partitionKeyRanges, Range range) throws CosmosClientException { + List partitionKeyRanges, Range range) { if (partitionKeyRanges == null) { throw new IllegalArgumentException("partitionKeyRanges can not be null."); } @@ -127,7 +126,7 @@ protected int findTargetRangeAndExtractContinuationTokens( } if (minIndex == partitionKeyRanges.size()) { - throw BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.BADREQUEST, + throw BridgeInternal.createCosmosException(HttpConstants.StatusCodes.BADREQUEST, String.format("Could not find partition key range for continuation token: {0}", needle)); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/SkipDocumentQueryExecutionContext.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/SkipDocumentQueryExecutionContext.java index 35cbd842be89a..0c4e559d17de7 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/SkipDocumentQueryExecutionContext.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/SkipDocumentQueryExecutionContext.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation.query; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.FeedResponse; import com.azure.cosmos.implementation.Resource; import com.azure.cosmos.implementation.HttpConstants; @@ -40,8 +40,8 @@ public static Flux> cre if (!OffsetContinuationToken.tryParse(continuationToken, outOffsetContinuationToken)) { String message = String.format("Invalid JSON in continuation token %s for Skip~Context", continuationToken); - CosmosClientException dce = - BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.BADREQUEST, + CosmosException dce = + BridgeInternal.createCosmosException(HttpConstants.StatusCodes.BADREQUEST, message); return Flux.error(dce); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/TopDocumentQueryExecutionContext.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/TopDocumentQueryExecutionContext.java index a55c3282c99c2..878ddbcf397c3 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/TopDocumentQueryExecutionContext.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/TopDocumentQueryExecutionContext.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation.query; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.FeedResponse; import com.azure.cosmos.implementation.Resource; import com.azure.cosmos.implementation.HttpConstants; @@ -41,7 +41,7 @@ public static Flux> cre if (!TakeContinuationToken.tryParse(topContinuationToken, outTakeContinuationToken)) { String message = String.format("INVALID JSON in continuation token %s for Top~Context", topContinuationToken); - CosmosClientException dce = BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.BADREQUEST, + CosmosException dce = BridgeInternal.createCosmosException(HttpConstants.StatusCodes.BADREQUEST, message); return Flux.error(dce); } @@ -53,7 +53,7 @@ public static Flux> cre String message = String.format( "top count in continuation token: %d can not be greater than the top count in the query: %d.", takeContinuationToken.getTakeCount(), topCount); - CosmosClientException dce = BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.BADREQUEST, message); + CosmosException dce = BridgeInternal.createCosmosException(HttpConstants.StatusCodes.BADREQUEST, message); return Flux.error(dce); } diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosContainerProperties.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosContainerProperties.java index 31b5e55455852..7d72ef7c8975f 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosContainerProperties.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosContainerProperties.java @@ -78,7 +78,6 @@ public IndexingPolicy getIndexingPolicy() { * * @param indexingPolicy {@link IndexingPolicy} the indexing policy * @return the CosmosContainerProperties. - * @throws IllegalArgumentException the cosmos client exception */ public CosmosContainerProperties setIndexingPolicy(IndexingPolicy indexingPolicy) { this.documentCollection.setIndexingPolicy(indexingPolicy); @@ -99,7 +98,6 @@ public UniqueKeyPolicy getUniqueKeyPolicy() { * * @param uniqueKeyPolicy the unique key policy * @return the CosmosContainerProperties. - * @throws IllegalArgumentException the cosmos client exception */ public CosmosContainerProperties setUniqueKeyPolicy(UniqueKeyPolicy uniqueKeyPolicy) { this.documentCollection.setUniqueKeyPolicy(uniqueKeyPolicy); @@ -120,7 +118,6 @@ public PartitionKeyDefinition getPartitionKeyDefinition() { * * @param partitionKeyDefinition the partition key definition. * @return the CosmosContainerProperties. - * @throws IllegalArgumentException the cosmos client exception */ public CosmosContainerProperties setPartitionKeyDefinition(PartitionKeyDefinition partitionKeyDefinition) { this.documentCollection.setPartitionKey(partitionKeyDefinition); @@ -143,7 +140,6 @@ public ConflictResolutionPolicy getConflictResolutionPolicy() { * * @param value ConflictResolutionPolicy to be used. * @return the CosmosContainerProperties. - * @throws IllegalArgumentException the cosmos client exception */ public CosmosContainerProperties setConflictResolutionPolicy(ConflictResolutionPolicy value) { this.documentCollection.setConflictResolutionPolicy(value); diff --git a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ModelBridgeInternal.java b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ModelBridgeInternal.java index fc2cd34bce7a6..e61da8ba2c3a1 100644 --- a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ModelBridgeInternal.java +++ b/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/ModelBridgeInternal.java @@ -482,17 +482,6 @@ public static Object getValue(JsonNode value) { return JsonSerializable.getValue(value); } - @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static CosmosError createCosmosError(ObjectNode objectNode) { - return new CosmosError(objectNode); - } - - @Warning(value = INTERNAL_USE_ONLY_WARNING) - public static CosmosError createCosmosError(String jsonString) { - return new CosmosError(jsonString); - } - - @Warning(value = INTERNAL_USE_ONLY_WARNING) public static JsonSerializable instantiateJsonSerializable(ObjectNode objectNode, Class klassType) { try { @@ -638,8 +627,6 @@ public static void populatePropertyBag(T t) { ((UniqueKeyPolicy) t).populatePropertyBag(); } else if (t instanceof Index) { ((Index) t).populatePropertyBag(); - } else if (t instanceof CosmosError) { - ((CosmosError) t).populatePropertyBag(); } else { throw new IllegalArgumentException("populatePropertyBag method does not exists in class " + t.getClass()); } @@ -647,7 +634,9 @@ public static void populatePropertyBag(T t) { @Warning(value = INTERNAL_USE_ONLY_WARNING) public static JsonSerializable getJsonSerializable(T t) { - if (t instanceof CompositePath) { + if (t instanceof JsonSerializable) { + return (JsonSerializable) t; + } if (t instanceof CompositePath) { return ((CompositePath) t).getJsonSerializable(); } else if (t instanceof ConflictResolutionPolicy) { return ((ConflictResolutionPolicy) t).getJsonSerializable(); @@ -673,8 +662,6 @@ public static JsonSerializable getJsonSerializable(T t) { return ((UniqueKeyPolicy) t).getJsonSerializable(); } else if (t instanceof Index) { return ((Index) t).getJsonSerializable(); - } else if (t instanceof CosmosError) { - return ((CosmosError) t).getJsonSerializable(); } else { throw new IllegalArgumentException("getJsonSerializable method does not exists in class " + t.getClass()); } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosContainerTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosContainerTest.java index 03e271409920d..e64efdf86c9fb 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosContainerTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosContainerTest.java @@ -12,7 +12,6 @@ import com.azure.cosmos.models.FeedOptions; import com.azure.cosmos.models.IndexingMode; import com.azure.cosmos.models.IndexingPolicy; -import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.models.PartitionKeyDefinition; import com.azure.cosmos.models.SqlQuerySpec; import com.azure.cosmos.rx.TestSuiteBase; @@ -116,8 +115,8 @@ public void createContainer_alreadyExists() throws Exception { try { createdDatabase.createContainer(containerProperties); } catch (Exception e) { - assertThat(e).isInstanceOf(CosmosClientException.class); - assertThat(((CosmosClientException) e).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.CONFLICT); + assertThat(e).isInstanceOf(CosmosException.class); + assertThat(((CosmosException) e).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.CONFLICT); } } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDatabaseContentResponseOnWriteTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDatabaseContentResponseOnWriteTest.java index cb6dd85f1a1c6..5bfc10b8d78de 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDatabaseContentResponseOnWriteTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDatabaseContentResponseOnWriteTest.java @@ -9,7 +9,6 @@ import com.azure.cosmos.models.CosmosDatabaseProperties; import com.azure.cosmos.models.CosmosDatabaseRequestOptions; import com.azure.cosmos.models.CosmosDatabaseResponse; -import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.rx.TestSuiteBase; import org.testng.annotations.AfterClass; import org.testng.annotations.BeforeClass; @@ -51,7 +50,7 @@ public void afterClass() { } @Test(groups = {"emulator"}, timeOut = TIMEOUT) - public void createDatabase_withContentResponseOnWriteDisabled() throws CosmosClientException { + public void createDatabase_withContentResponseOnWriteDisabled() { CosmosDatabaseProperties databaseDefinition = new CosmosDatabaseProperties(CosmosDatabaseForTest.generateId()); databases.add(databaseDefinition.getId()); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDatabaseTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDatabaseTest.java index bdb40706899f4..f74a13840355c 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDatabaseTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDatabaseTest.java @@ -10,7 +10,6 @@ import com.azure.cosmos.models.CosmosDatabaseRequestOptions; import com.azure.cosmos.models.CosmosDatabaseResponse; import com.azure.cosmos.models.FeedOptions; -import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.models.SqlQuerySpec; import com.azure.cosmos.rx.TestSuiteBase; import com.azure.cosmos.implementation.HttpConstants; @@ -53,7 +52,7 @@ public void afterClass() { @Test(groups = {"emulator"}, timeOut = TIMEOUT) - public void createDatabase_withPropertiesAndOptions() throws CosmosClientException { + public void createDatabase_withPropertiesAndOptions() { CosmosDatabaseProperties databaseDefinition = new CosmosDatabaseProperties(CosmosDatabaseForTest.generateId()); databases.add(databaseDefinition.getId()); @@ -85,8 +84,8 @@ public void createDatabase_alreadyExists() throws Exception { try { client.createDatabase(databaseProperties); } catch (Exception e) { - assertThat(e).isInstanceOf(CosmosClientException.class); - assertThat(((CosmosClientException) e).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.CONFLICT); + assertThat(e).isInstanceOf(CosmosException.class); + assertThat(((CosmosException) e).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.CONFLICT); } } @@ -107,7 +106,7 @@ public void createDatabase_withPropertiesThroughputAndOptions() throws Exception try { CosmosDatabaseResponse createResponse = client.createDatabase(databaseProperties, throughput, requestOptions); validateDatabaseResponse(databaseDefinition, createResponse); - } catch (CosmosClientException ex) { + } catch (CosmosException ex) { assertThat(ex.getStatusCode()).isEqualTo(HttpConstants.StatusCodes.FORBIDDEN); } } @@ -121,8 +120,8 @@ public void createDatabase_withPropertiesAndThroughput() throws Exception { CosmosDatabaseResponse createResponse = client.createDatabase(databaseProperties, throughput); validateDatabaseResponse(databaseDefinition, createResponse); } catch (Exception ex) { - if (ex instanceof CosmosClientException) { - assertThat(((CosmosClientException) ex).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.FORBIDDEN); + if (ex instanceof CosmosException) { + assertThat(((CosmosException) ex).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.FORBIDDEN); } else { throw ex; } @@ -137,8 +136,8 @@ public void createDatabase_withIdAndThroughput() throws Exception { CosmosDatabaseResponse createResponse = client.createDatabase(databaseDefinition.getId(), throughput); validateDatabaseResponse(databaseDefinition, createResponse); } catch (Exception ex) { - if (ex instanceof CosmosClientException) { - assertThat(((CosmosClientException) ex).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.FORBIDDEN); + if (ex instanceof CosmosException) { + assertThat(((CosmosException) ex).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.FORBIDDEN); } else { throw ex; } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDiagnosticsTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDiagnosticsTest.java index ce38bd4b2c1b3..458fe67417e3c 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDiagnosticsTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosDiagnosticsTest.java @@ -58,7 +58,7 @@ public void beforeClass() throws Exception { } @AfterClass(groups = {"simple"}, timeOut = SHUTDOWN_TIMEOUT, alwaysRun = true) - public void afterClass() throws CosmosClientException { + public void afterClass() { assertThat(this.gatewayClient).isNotNull(); this.gatewayClient.close(); if (this.directClient != null) { @@ -67,7 +67,7 @@ public void afterClass() throws CosmosClientException { } @Test(groups = {"simple"}) - public void gatewayDiagnostics() throws CosmosClientException { + public void gatewayDiagnostics() { CosmosItemProperties cosmosItemProperties = getCosmosItemProperties(); CosmosItemResponse createResponse = this.container.createItem(cosmosItemProperties); String diagnostics = createResponse.getDiagnostics().toString(); @@ -81,7 +81,7 @@ public void gatewayDiagnostics() throws CosmosClientException { } @Test(groups = {"simple"}) - public void gatewayDiagnosticsOnException() throws CosmosClientException { + public void gatewayDiagnosticsOnException() { CosmosItemProperties cosmosItemProperties = getCosmosItemProperties(); CosmosItemResponse createResponse = null; CosmosClient client = null; @@ -101,7 +101,7 @@ public void gatewayDiagnosticsOnException() throws CosmosClientException { new PartitionKey("wrongPartitionKey"), CosmosItemProperties.class); fail("request should fail as partition key is wrong"); - } catch (CosmosClientException exception) { + } catch (CosmosException exception) { String diagnostics = exception.getDiagnostics().toString(); assertThat(exception.getStatusCode()).isEqualTo(HttpConstants.StatusCodes.NOTFOUND); assertThat(diagnostics).contains("\"connectionMode\":\"GATEWAY\""); @@ -118,7 +118,7 @@ public void gatewayDiagnosticsOnException() throws CosmosClientException { } @Test(groups = {"simple"}) - public void systemDiagnosticsForSystemStateInformation() throws CosmosClientException { + public void systemDiagnosticsForSystemStateInformation() { CosmosItemProperties cosmosItemProperties = getCosmosItemProperties(); CosmosItemResponse createResponse = this.container.createItem(cosmosItemProperties); String diagnostics = createResponse.getDiagnostics().toString(); @@ -131,7 +131,7 @@ public void systemDiagnosticsForSystemStateInformation() throws CosmosClientExce } @Test(groups = {"simple"}) - public void directDiagnostics() throws CosmosClientException { + public void directDiagnostics() { CosmosContainer cosmosContainer = directClient.getDatabase(cosmosAsyncContainer.getDatabase().getId()).getContainer(cosmosAsyncContainer.getId()); CosmosItemProperties cosmosItemProperties = getCosmosItemProperties(); CosmosItemResponse createResponse = cosmosContainer.createItem(cosmosItemProperties); @@ -150,7 +150,7 @@ public void directDiagnostics() throws CosmosClientException { // TODO: (naveen) - Check the priority @Test(groups = {"simple"}, priority = 1, enabled = false) - public void directDiagnosticsOnException() throws CosmosClientException { + public void directDiagnosticsOnException() { CosmosContainer cosmosContainer = directClient.getDatabase(cosmosAsyncContainer.getDatabase().getId()).getContainer(cosmosAsyncContainer.getId()); CosmosItemProperties cosmosItemProperties = getCosmosItemProperties(); CosmosItemResponse createResponse = null; @@ -171,7 +171,7 @@ public void directDiagnosticsOnException() throws CosmosClientException { new PartitionKey("wrongPartitionKey"), CosmosItemProperties.class); fail("request should fail as partition key is wrong"); - } catch (CosmosClientException exception) { + } catch (CosmosException exception) { String diagnostics = exception.getDiagnostics().toString(); assertThat(exception.getStatusCode()).isEqualTo(HttpConstants.StatusCodes.NOTFOUND); assertThat(diagnostics).contains("\"connectionMode\":\"DIRECT\""); @@ -218,7 +218,7 @@ public void supplementalResponseStatisticsList() throws Exception { } @Test(groups = {"simple"}) - public void serializationOnVariousScenarios() throws CosmosClientException { + public void serializationOnVariousScenarios() { //checking database serialization CosmosDatabaseResponse cosmosDatabase = gatewayClient.getDatabase(cosmosAsyncContainer.getDatabase().getId()).read(); String diagnostics = cosmosDatabase.getDiagnostics().toString(); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosClientExceptionTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosExceptionTest.java similarity index 83% rename from sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosClientExceptionTest.java rename to sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosExceptionTest.java index cda9827de74b6..60135d5d79127 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosClientExceptionTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosExceptionTest.java @@ -23,7 +23,7 @@ import com.azure.cosmos.implementation.ServiceUnavailableException; import com.azure.cosmos.implementation.UnauthorizedException; import com.azure.cosmos.implementation.http.HttpHeaders; -import com.azure.cosmos.models.CosmosError; +import com.azure.cosmos.implementation.CosmosError; import com.azure.cosmos.implementation.guava25.collect.ImmutableMap; import org.testng.annotations.DataProvider; import org.testng.annotations.Test; @@ -51,46 +51,46 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.testng.Assert.assertEquals; -public class CosmosClientExceptionTest { +public class CosmosExceptionTest { @Test(groups = { "unit" }) public void headerNotNull1() { - CosmosClientException dce = BridgeInternal.createCosmosClientException(0); + CosmosException dce = BridgeInternal.createCosmosException(0); assertThat(dce.getResponseHeaders()).isNotNull(); assertThat(dce.getResponseHeaders()).isEmpty(); } @Test(groups = { "unit" }) public void headerNotNull2() { - CosmosClientException dce = BridgeInternal.createCosmosClientException(0, "dummy"); + CosmosException dce = BridgeInternal.createCosmosException(0, "dummy"); assertThat(dce.getResponseHeaders()).isNotNull(); assertThat(dce.getResponseHeaders()).isEmpty(); } @Test(groups = { "unit" }) public void headerNotNull3() { - CosmosClientException dce = BridgeInternal.createCosmosClientException(0, new RuntimeException()); + CosmosException dce = BridgeInternal.createCosmosException(0, new RuntimeException()); assertThat(dce.getResponseHeaders()).isNotNull(); assertThat(dce.getResponseHeaders()).isEmpty(); } @Test(groups = { "unit" }) public void headerNotNull4() { - CosmosClientException dce = BridgeInternal.createCosmosClientException(0, (CosmosError) null, (Map) null); + CosmosException dce = BridgeInternal.createCosmosException(0, (CosmosError) null, (Map) null); assertThat(dce.getResponseHeaders()).isNotNull(); assertThat(dce.getResponseHeaders()).isEmpty(); } @Test(groups = { "unit" }) public void headerNotNull5() { - CosmosClientException dce = BridgeInternal.createCosmosClientException((String) null, 0, (CosmosError) null, (Map) null); + CosmosException dce = BridgeInternal.createCosmosException((String) null, 0, (CosmosError) null, (Map) null); assertThat(dce.getResponseHeaders()).isNotNull(); assertThat(dce.getResponseHeaders()).isEmpty(); } @Test(groups = { "unit" }) public void headerNotNull6() { - CosmosClientException dce = BridgeInternal.createCosmosClientException((String) null, (Exception) null, (Map) null, 0, (String) null); + CosmosException dce = BridgeInternal.createCosmosException((String) null, (Exception) null, (Map) null, 0, (String) null); assertThat(dce.getResponseHeaders()).isNotNull(); assertThat(dce.getResponseHeaders()).isEmpty(); } @@ -98,17 +98,17 @@ public void headerNotNull6() { @Test(groups = { "unit" }) public void headerNotNull7() { ImmutableMap respHeaders = ImmutableMap.of("key", "getValue"); - CosmosClientException dce = BridgeInternal.createCosmosClientException((String) null, (Exception) null, respHeaders, 0, (String) null); + CosmosException dce = BridgeInternal.createCosmosException((String) null, (Exception) null, respHeaders, 0, (String) null); assertThat(dce.getResponseHeaders()).isNotNull(); assertThat(dce.getResponseHeaders()).contains(respHeaders.entrySet().iterator().next()); } @Test(groups = { "unit" }, dataProvider = "subTypes") - public void statusCodeIsCorrect(Class type, int expectedStatusCode) { + public void statusCodeIsCorrect(Class type, int expectedStatusCode) { try { - Constructor constructor = type.getDeclaredConstructor(String.class, HttpHeaders.class, String.class); + Constructor constructor = type.getDeclaredConstructor(String.class, HttpHeaders.class, String.class); constructor.setAccessible(true); - final CosmosClientException instance = constructor.newInstance("some-message", null, "some-uri"); + final CosmosException instance = constructor.newInstance("some-message", null, "some-uri"); assertEquals(instance.getStatusCode(), expectedStatusCode); } catch (IllegalAccessException | InstantiationException | NoSuchMethodException | InvocationTargetException error) { String message = lenientFormat("could not create instance of %s due to %s", type, error); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosItemTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosItemTest.java index 941e0535affb5..203b344082fe3 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosItemTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosItemTest.java @@ -79,8 +79,8 @@ public void createItem_alreadyExists() throws Exception { try { container.createItem(properties, new CosmosItemRequestOptions()); } catch (Exception e) { - assertThat(e).isInstanceOf(CosmosClientException.class); - assertThat(((CosmosClientException) e).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.CONFLICT); + assertThat(e).isInstanceOf(CosmosException.class); + assertThat(((CosmosException) e).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.CONFLICT); } } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosSyncStoredProcTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosSyncStoredProcTest.java index b4eca129daec5..25f3d4bb243eb 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosSyncStoredProcTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosSyncStoredProcTest.java @@ -8,7 +8,6 @@ import com.azure.cosmos.models.CosmosStoredProcedureRequestOptions; import com.azure.cosmos.models.CosmosStoredProcedureResponse; import com.azure.cosmos.models.FeedOptions; -import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.models.PartitionKey; import com.azure.cosmos.models.SqlQuerySpec; import com.azure.cosmos.rx.TestSuiteBase; @@ -78,8 +77,8 @@ public void createSproc_alreadyExists() throws Exception { try { container.getScripts().createStoredProcedure(storedProcedureDef); } catch (Exception e) { - assertThat(e).isInstanceOf(CosmosClientException.class); - assertThat(((CosmosClientException) e).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.CONFLICT); + assertThat(e).isInstanceOf(CosmosException.class); + assertThat(((CosmosException) e).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.CONFLICT); } } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/MultipleCosmosClientsWithTransportClientSharingTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/MultipleCosmosClientsWithTransportClientSharingTest.java index 0cf67fa3c15ae..233353bcbd283 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/MultipleCosmosClientsWithTransportClientSharingTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/MultipleCosmosClientsWithTransportClientSharingTest.java @@ -95,8 +95,8 @@ public void createItem_alreadyExists() { try { container1.createItem(properties, new CosmosItemRequestOptions()); } catch (Exception e) { - assertThat(e).isInstanceOf(CosmosClientException.class); - assertThat(((CosmosClientException) e).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.CONFLICT); + assertThat(e).isInstanceOf(CosmosException.class); + assertThat(((CosmosException) e).getStatusCode()).isEqualTo(HttpConstants.StatusCodes.CONFLICT); } } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/RetryContextOnDiagnosticTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/RetryContextOnDiagnosticTest.java index 921d3784679a6..c482e3e7d9c14 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/RetryContextOnDiagnosticTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/RetryContextOnDiagnosticTest.java @@ -52,7 +52,7 @@ public void backoffRetryUtilityExecuteRetry() throws Exception { Callable> callbackMethod = Mockito.mock(Callable.class); serviceRequest = RxDocumentServiceRequest.create(OperationType.Read, ResourceType.Document); retryPolicy = new TestRetryPolicy(); - CosmosClientException exception = new CosmosClientException(410, exceptionText); + CosmosException exception = new CosmosException(410, exceptionText); Mockito.when(callbackMethod.call()).thenThrow(exception, exception, exception, exception, exception) .thenReturn(Mono.just(new StoreResponse(200, new ArrayList<>(), getUTF8BytesOrNull(responseText)))); Mono monoResponse = BackoffRetryUtility.executeRetry(callbackMethod, retryPolicy); @@ -69,7 +69,7 @@ public void backoffRetryUtilityExecuteRetryWithFailure() throws Exception { Callable> callbackMethod = Mockito.mock(Callable.class); serviceRequest = RxDocumentServiceRequest.create(OperationType.Read, ResourceType.Document); retryPolicy = new TestRetryPolicy(); - CosmosClientException exception = new CosmosClientException(410, exceptionText); + CosmosException exception = new CosmosException(410, exceptionText); Mockito.when(callbackMethod.call()).thenThrow(exception); ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor(); executor.schedule(() -> { @@ -89,8 +89,8 @@ public void backoffRetryUtilityExecuteAsync() { Function, Mono> parameterizedCallbackMethod = Mockito.mock(Function.class); serviceRequest = RxDocumentServiceRequest.create(OperationType.Read, ResourceType.Document); retryPolicy = new TestRetryPolicy(); - CosmosClientException exception = new CosmosClientException(410, exceptionText); - Mono exceptionMono = Mono.error(exception); + CosmosException exception = new CosmosException(410, exceptionText); + Mono exceptionMono = Mono.error(exception); Mockito.when(parameterizedCallbackMethod.apply(Matchers.any(Quadruple.class))).thenReturn(exceptionMono, exceptionMono, exceptionMono, exceptionMono, exceptionMono) .thenReturn(Mono.just(new StoreResponse(200, new ArrayList<>(), getUTF8BytesOrNull(responseText)))); Mono monoResponse = BackoffRetryUtility.executeAsync(parameterizedCallbackMethod, retryPolicy, inBackoffAlternateCallbackMethod, Duration.ofSeconds(5), serviceRequest); @@ -109,8 +109,8 @@ public void backoffRetryUtilityExecuteAsyncWithFailure() { Function, Mono> parameterizedCallbackMethod = Mockito.mock(Function.class); serviceRequest = RxDocumentServiceRequest.create(OperationType.Read, ResourceType.Document); retryPolicy = new TestRetryPolicy(); - CosmosClientException exception = new CosmosClientException(410, exceptionText); - Mono exceptionMono = Mono.error(exception); + CosmosException exception = new CosmosException(410, exceptionText); + Mono exceptionMono = Mono.error(exception); Mockito.when(parameterizedCallbackMethod.apply(Matchers.any(Quadruple.class))).thenReturn(exceptionMono); ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor(); executor.schedule(() -> { diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/ConsistencyTests2.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/ConsistencyTests2.java index 71b046ba6f3c9..a4599b9912f83 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/ConsistencyTests2.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/ConsistencyTests2.java @@ -4,9 +4,8 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.ConnectionMode; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.DirectConnectionConfig; import com.azure.cosmos.GatewayConnectionConfig; import com.azure.cosmos.models.FeedOptions; @@ -246,7 +245,7 @@ public void validateSessionTokenAsync() { logger.info("SESSION Token = {}, LSN = {}", sessionToken.convertToString(), lsn); assertThat(lsn).isEqualTo(sessionToken.getLSN()); } catch (Exception ex) { - CosmosClientException clientException = (CosmosClientException) ex.getCause(); + CosmosException clientException = (CosmosException) ex.getCause(); if (clientException.getStatusCode() != 0) { if (clientException.getStatusCode() == HttpConstants.StatusCodes.REQUEST_TIMEOUT) { // ignore diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/FailureValidator.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/FailureValidator.java index 365d09e900eae..47d84842b99ae 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/FailureValidator.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/FailureValidator.java @@ -3,14 +3,12 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.models.CosmosError; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.directconnectivity.WFConstants; import com.azure.cosmos.models.ModelBridgeInternal; import java.util.ArrayList; import java.util.List; -import java.util.Map; import static org.assertj.core.api.Assertions.assertThat; @@ -41,8 +39,8 @@ public Builder statusCode(int statusCode) { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - assertThat(((CosmosClientException) t).getStatusCode()).isEqualTo(statusCode); + assertThat(t).isInstanceOf(CosmosException.class); + assertThat(((CosmosException) t).getStatusCode()).isEqualTo(statusCode); } }); return this; @@ -53,8 +51,8 @@ public Builder lsnGreaterThan(long quorumAckedLSN) { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - assertThat(BridgeInternal.getLSN((CosmosClientException) t) > quorumAckedLSN).isTrue(); + assertThat(t).isInstanceOf(CosmosException.class); + assertThat(BridgeInternal.getLSN((CosmosException) t) > quorumAckedLSN).isTrue(); } }); return this; @@ -65,8 +63,8 @@ public Builder lsnGreaterThanEqualsTo(long quorumAckedLSN) @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - assertThat(BridgeInternal.getLSN((CosmosClientException) t) >= quorumAckedLSN).isTrue(); + assertThat(t).isInstanceOf(CosmosException.class); + assertThat(BridgeInternal.getLSN((CosmosException) t) >= quorumAckedLSN).isTrue(); } }); return this; @@ -77,11 +75,11 @@ public Builder exceptionQuorumAckedLSNInNotNull() { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - CosmosClientException cosmosClientException = (CosmosClientException) t; + assertThat(t).isInstanceOf(CosmosException.class); + CosmosException cosmosException = (CosmosException) t; long exceptionQuorumAckedLSN = -1; - if (cosmosClientException.getResponseHeaders().get(WFConstants.BackendHeaders.QUORUM_ACKED_LSN) != null) { - exceptionQuorumAckedLSN = Long.parseLong(cosmosClientException.getResponseHeaders().get(WFConstants.BackendHeaders.QUORUM_ACKED_LSN)); + if (cosmosException.getResponseHeaders().get(WFConstants.BackendHeaders.QUORUM_ACKED_LSN) != null) { + exceptionQuorumAckedLSN = Long.parseLong(cosmosException.getResponseHeaders().get(WFConstants.BackendHeaders.QUORUM_ACKED_LSN)); } assertThat(exceptionQuorumAckedLSN).isNotEqualTo(-1); @@ -106,8 +104,8 @@ public Builder notNullActivityId() { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - assertThat(((CosmosClientException) t).getActivityId()).isNotNull(); + assertThat(t).isInstanceOf(CosmosException.class); + assertThat(((CosmosException) t).getActivityId()).isNotNull(); } }); return this; @@ -118,9 +116,9 @@ public Builder error(CosmosError cosmosError) { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - assertThat(ModelBridgeInternal.toJsonFromJsonSerializable(ModelBridgeInternal.getJsonSerializable(((CosmosClientException) t).getError()))) - .isEqualTo(ModelBridgeInternal.toJsonFromJsonSerializable(ModelBridgeInternal.getJsonSerializable(cosmosError))); + assertThat(t).isInstanceOf(CosmosException.class); + assertThat(ModelBridgeInternal.toJsonFromJsonSerializable(BridgeInternal.getCosmosError((CosmosException) t))) + .isEqualTo(ModelBridgeInternal.toJsonFromJsonSerializable(cosmosError)); } }); return this; @@ -131,8 +129,8 @@ public Builder subStatusCode(Integer substatusCode) { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - assertThat(((CosmosClientException) t).getSubStatusCode()).isEqualTo(substatusCode); + assertThat(t).isInstanceOf(CosmosException.class); + assertThat(((CosmosException) t).getSubStatusCode()).isEqualTo(substatusCode); } }); return this; @@ -143,8 +141,8 @@ public Builder unknownSubStatusCode() { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - assertThat(((CosmosClientException) t).getSubStatusCode()).isEqualTo(HttpConstants.SubStatusCodes.UNKNOWN); + assertThat(t).isInstanceOf(CosmosException.class); + assertThat(((CosmosException) t).getSubStatusCode()).isEqualTo(HttpConstants.SubStatusCodes.UNKNOWN); } }); return this; @@ -155,8 +153,8 @@ public Builder responseHeader(String key, String value) { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - assertThat(((CosmosClientException) t).getResponseHeaders().get(key)).isEqualTo(value); + assertThat(t).isInstanceOf(CosmosException.class); + assertThat(((CosmosException) t).getResponseHeaders().get(key)).isEqualTo(value); } }); return this; @@ -167,8 +165,8 @@ public Builder lsn(long lsn) { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - CosmosClientException ex = (CosmosClientException) t; + assertThat(t).isInstanceOf(CosmosException.class); + CosmosException ex = (CosmosException) t; assertThat(BridgeInternal.getLSN(ex)).isEqualTo(lsn); } }); @@ -180,8 +178,8 @@ public Builder partitionKeyRangeId(String pkrid) { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - CosmosClientException ex = (CosmosClientException) t; + assertThat(t).isInstanceOf(CosmosException.class); + CosmosException ex = (CosmosException) t; assertThat(BridgeInternal.getPartitionKeyRangeId(ex)).isEqualTo(pkrid); } }); @@ -193,8 +191,8 @@ public Builder resourceAddress(String resourceAddress) { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - CosmosClientException ex = (CosmosClientException) t; + assertThat(t).isInstanceOf(CosmosException.class); + CosmosException ex = (CosmosException) t; assertThat(BridgeInternal.getResourceAddress(ex)).isEqualTo(resourceAddress); } }); @@ -228,8 +226,8 @@ public Builder resourceNotFound() { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - CosmosClientException ex = (CosmosClientException) t; + assertThat(t).isInstanceOf(CosmosException.class); + CosmosException ex = (CosmosException) t; assertThat(ex.getStatusCode()).isEqualTo(404); } @@ -256,8 +254,8 @@ public Builder resourceAlreadyExists() { @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - CosmosClientException ex = (CosmosClientException) t; + assertThat(t).isInstanceOf(CosmosException.class); + CosmosException ex = (CosmosException) t; assertThat(ex.getStatusCode()).isEqualTo(409); } @@ -295,8 +293,8 @@ public Builder documentClientExceptionHeaderRequestContain @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - CosmosClientException ex = (CosmosClientException) t; + assertThat(t).isInstanceOf(CosmosException.class); + CosmosException ex = (CosmosException) t; assertThat(BridgeInternal.getRequestHeaders(ex)).containsEntry(key, value); } }); @@ -308,8 +306,8 @@ public Builder documentClientExceptionToStringExcludesHead @Override public void validate(Throwable t) { assertThat(t).isNotNull(); - assertThat(t).isInstanceOf(CosmosClientException.class); - CosmosClientException ex = (CosmosClientException) t; + assertThat(t).isInstanceOf(CosmosException.class); + CosmosException ex = (CosmosException) t; String exceptionToString = ex.toString(); assertThat(exceptionToString).doesNotContain(header); } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryAnalyzer.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryAnalyzer.java index 8d20340de3a74..490989fe93601 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryAnalyzer.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryAnalyzer.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.testng.ITestResult; @@ -36,13 +36,13 @@ public boolean retryMethod(ITestResult result) { private int getTimeToWaitInSeconds(ITestResult result) { Throwable throwable = result.getThrowable(); - CosmosClientException cosmosClientException = extractCosmosClientExceptionIfAny(throwable); + CosmosException cosmosException = extractCosmosExceptionIfAny(throwable); - if (cosmosClientException == null) { + if (cosmosException == null) { return waitBetweenRetriesInSeconds; } - Duration retryAfterDuration = cosmosClientException.getRetryAfterDuration(); + Duration retryAfterDuration = cosmosException.getRetryAfterDuration(); if (retryAfterDuration.toMillis() <= 0) { return waitBetweenRetriesInSeconds; } @@ -50,15 +50,15 @@ private int getTimeToWaitInSeconds(ITestResult result) { return Math.max(Math.toIntExact(retryAfterDuration.getSeconds()), waitBetweenRetriesInSeconds); } - private CosmosClientException extractCosmosClientExceptionIfAny(Throwable t) { + private CosmosException extractCosmosExceptionIfAny(Throwable t) { if (t == null) { return null; } - while( t != null && !(t instanceof CosmosClientException)) { + while( t != null && !(t instanceof CosmosException)) { t = t.getCause(); } - return (CosmosClientException) t; + return (CosmosException) t; } } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryCreateDocumentTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryCreateDocumentTest.java index daecd41f4d8ae..ddd30decf1b11 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryCreateDocumentTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryCreateDocumentTest.java @@ -4,7 +4,6 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.BridgeInternal; -import com.azure.cosmos.models.CosmosError; import com.azure.cosmos.implementation.guava25.collect.ImmutableMap; import org.mockito.Mockito; import org.mockito.stubbing.Answer; @@ -59,7 +58,7 @@ public void retryDocumentCreate() throws Exception { HttpConstants.HttpHeaders.SUB_STATUS, Integer.toString(HttpConstants.SubStatusCodes.PARTITION_KEY_MISMATCH)); - return Mono.error(BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.BADREQUEST, new CosmosError() , header)); + return Mono.error(BridgeInternal.createCosmosException(HttpConstants.StatusCodes.BADREQUEST, new CosmosError() , header)); } else { return client.getOrigGatewayStoreModel().processMessage(req); } @@ -90,7 +89,7 @@ public void createDocument_noRetryOnNonRetriableFailure() throws Exception { HttpConstants.HttpHeaders.SUB_STATUS, Integer.toString(2)); - return Mono.error(BridgeInternal.createCosmosClientException(1, new CosmosError() , header)); + return Mono.error(BridgeInternal.createCosmosException(1, new CosmosError() , header)); } }).when(client.getSpyGatewayStoreModel()).processMessage(anyObject()); @@ -126,7 +125,7 @@ public void createDocument_failImmediatelyOnNonRetriable() throws Exception { HttpConstants.HttpHeaders.SUB_STATUS, Integer.toString(2)); - return Mono.error(BridgeInternal.createCosmosClientException(1, new CosmosError() , header)); + return Mono.error(BridgeInternal.createCosmosException(1, new CosmosError() , header)); } else { return client.getOrigGatewayStoreModel().processMessage(req); } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryThrottleTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryThrottleTest.java index 59e399aca1362..b5ce134ec4ae9 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryThrottleTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RetryThrottleTest.java @@ -101,7 +101,7 @@ public void retryDocumentCreate() throws Exception { } int currentAttempt = count.getAndIncrement(); if (currentAttempt == 0) { - return Mono.error(BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.TOO_MANY_REQUESTS)); + return Mono.error(BridgeInternal.createCosmosException(HttpConstants.StatusCodes.TOO_MANY_REQUESTS)); } else { return client.getOrigGatewayStoreModel().processMessage(req); } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RxGatewayStoreModelTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RxGatewayStoreModelTest.java index 35de8692688ab..24a97c40f6e1e 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RxGatewayStoreModelTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/RxGatewayStoreModelTest.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.http.HttpClient; import com.azure.cosmos.implementation.http.HttpRequest; import io.netty.handler.timeout.ReadTimeoutException; @@ -50,7 +50,7 @@ public void readTimeout() throws Exception { Mono resp = storeModel.processMessage(dsr); validateFailure(resp, FailureValidator.builder() - .instanceOf(CosmosClientException.class) + .instanceOf(CosmosException.class) .causeInstanceOf(ReadTimeoutException.class) .documentClientExceptionHeaderRequestContainsEntry("key", "value") .statusCode(0).build()); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/TestSuiteBase.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/TestSuiteBase.java index 90e48b72de185..adb50537b21ec 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/TestSuiteBase.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/TestSuiteBase.java @@ -2,14 +2,12 @@ // Licensed under the MIT License. package com.azure.cosmos.implementation; -import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.DirectConnectionConfig; import com.azure.cosmos.GatewayConnectionConfig; import com.azure.cosmos.models.CompositePath; import com.azure.cosmos.models.CompositePathSortOrder; -import com.azure.cosmos.ConnectionMode; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.DataType; import com.azure.cosmos.DocumentClientTest; import com.azure.cosmos.models.FeedOptions; @@ -48,7 +46,6 @@ import java.time.Duration; import java.util.ArrayList; -import java.util.Collection; import java.util.List; import java.util.UUID; import java.util.concurrent.TimeUnit; @@ -522,7 +519,7 @@ public static void safeDeleteDocument(AsyncDocumentClient client, String documen try { client.deleteDocument(documentLink, options).single().block(); } catch (Exception e) { - CosmosClientException dce = Utils.as(e, CosmosClientException.class); + CosmosException dce = Utils.as(e, CosmosException.class); if (dce == null || dce.getStatusCode() != 404) { throw e; } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyReaderTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyReaderTest.java index 34f7dcc0d3d43..5c9420fdbce02 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyReaderTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ConsistencyReaderTest.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation.directconnectivity; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.NotFoundException; import com.azure.cosmos.implementation.RequestRateTooLargeException; import com.azure.cosmos.implementation.Configs; @@ -58,7 +58,7 @@ public Object[][] deduceReadModeArgProvider() { @Test(groups = "unit", dataProvider = "deduceReadModeArgProvider") public void deduceReadMode(ConsistencyLevel accountConsistencyLevel, ConsistencyLevel requestConsistency, ReadMode expectedReadMode, - ConsistencyLevel expectedConsistencyToUse, boolean expectedToUseSession) throws CosmosClientException { + ConsistencyLevel expectedConsistencyToUse, boolean expectedToUseSession) { AddressSelector addressSelector = Mockito.mock(AddressSelector.class); ISessionContainer sessionContainer = Mockito.mock(ISessionContainer.class); TransportClient transportClient = Mockito.mock(TransportClient.class); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/GatewayServiceConfigurationReaderTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/GatewayServiceConfigurationReaderTest.java index 4a35d9789bdb7..87fe90668c186 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/GatewayServiceConfigurationReaderTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/GatewayServiceConfigurationReaderTest.java @@ -95,7 +95,7 @@ public void configurationPropertyReads() throws Exception { assertThat(configurationReader.getUserReplicationPolicy().getMaxReplicaSetSize()).isEqualTo(4); //Testing scenario of scheduled cache refresh with error - Mockito.when(databaseAccountManagerInternal.getDatabaseAccountFromEndpoint(Matchers.any())).thenReturn(Flux.error(BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.FORBIDDEN))); + Mockito.when(databaseAccountManagerInternal.getDatabaseAccountFromEndpoint(Matchers.any())).thenReturn(Flux.error(BridgeInternal.createCosmosException(HttpConstants.StatusCodes.FORBIDDEN))); Thread.sleep(2000); assertThat(configurationReader.getDefaultConsistencyLevel()).isEqualTo(ConsistencyLevel.SESSION); assertThat((boolean) configurationReader.getQueryEngineConfiguration().get("enableSpatialIndexing")).isTrue(); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/GoneAndRetryWithRetryPolicyTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/GoneAndRetryWithRetryPolicyTest.java index 882af8fb393c8..895a6d5fc8653 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/GoneAndRetryWithRetryPolicyTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/GoneAndRetryWithRetryPolicyTest.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation.directconnectivity; import com.azure.cosmos.implementation.BadRequestException; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.GoneException; import com.azure.cosmos.implementation.InvalidPartitionException; import com.azure.cosmos.implementation.PartitionIsMigratingException; @@ -100,7 +100,7 @@ public void shouldRetryWithInvalidPartitionException() { // It will retry max till 3 attempts shouldRetryResult = goneAndRetryWithRetryPolicy.shouldRetry(new InvalidPartitionException()).block(); assertThat(shouldRetryResult.shouldRetry).isFalse(); - CosmosClientException clientException = (CosmosClientException) shouldRetryResult.exception; + CosmosException clientException = (CosmosException) shouldRetryResult.exception; assertThat(clientException.getStatusCode()).isEqualTo(HttpConstants.StatusCodes.SERVICE_UNAVAILABLE); } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/MultiStoreResultValidator.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/MultiStoreResultValidator.java index ef3b1bca0f72a..9fdafe23c33b7 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/MultiStoreResultValidator.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/MultiStoreResultValidator.java @@ -3,7 +3,7 @@ package com.azure.cosmos.implementation.directconnectivity; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.FailureValidator; import com.azure.cosmos.implementation.guava25.base.Predicates; import org.apache.commons.lang3.mutable.MutableObject; @@ -67,7 +67,7 @@ public void validate(List storeResults) { for(StoreResult srr: storeResults) { try { storeResponseValidator.validate(srr.toResponse()); - } catch (CosmosClientException e) { + } catch (CosmosException e) { fail(e.getMessage()); } } @@ -129,7 +129,7 @@ public void validate(List storeResults) { for(StoreResult srr: storeResults) { try { failureValidator.validate(srr.getException()); - } catch (CosmosClientException e) { + } catch (CosmosException e) { fail(e.getMessage()); } } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ReplicatedResourceClientPartitionSplitTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ReplicatedResourceClientPartitionSplitTest.java index b9edcbeaca113..b517676f4005d 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ReplicatedResourceClientPartitionSplitTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ReplicatedResourceClientPartitionSplitTest.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation.directconnectivity; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.GoneException; import com.azure.cosmos.implementation.PartitionKeyRangeIsSplittingException; import com.azure.cosmos.implementation.Configs; @@ -140,7 +140,7 @@ public void partitionSplit_RefreshCache_Read(ConsistencyLevel consistencyLevel, addressSelectorWrapper.verifyNumberOfForceCacheRefreshGreaterThanOrEqualTo(1); } else { - FailureValidator validator = FailureValidator.builder().instanceOf(CosmosClientException.class) + FailureValidator validator = FailureValidator.builder().instanceOf(CosmosException.class) .statusCode(503).build(); validateFailure(storeResponseObs, validator, TIMEOUT); } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ReplicatedResourceClientTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ReplicatedResourceClientTest.java index c8c5123fb9096..039dd31cf65a6 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ReplicatedResourceClientTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/ReplicatedResourceClientTest.java @@ -3,7 +3,7 @@ package com.azure.cosmos.implementation.directconnectivity; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.GoneException; import com.azure.cosmos.implementation.Configs; import com.azure.cosmos.implementation.FailureValidator; @@ -48,7 +48,7 @@ public void invokeAsyncWithGoneException() { Configs configs = new Configs(); ReplicatedResourceClient resourceClient = new ReplicatedResourceClient(configs, new AddressSelector(addressResolver, Protocol.HTTPS), null, transportClient, serviceConfigReader, authorizationTokenProvider, enableReadRequestsFallback, false); - FailureValidator validator = FailureValidator.builder().instanceOf(CosmosClientException.class).build(); + FailureValidator validator = FailureValidator.builder().instanceOf(CosmosException.class).build(); RxDocumentServiceRequest request = Mockito.spy(RxDocumentServiceRequest.create(OperationType.Create, ResourceType.Document)); Mockito.when(addressResolver.resolveAsync(Matchers.any(), Matchers.anyBoolean())) diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/RntbdTransportClientTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/RntbdTransportClientTest.java index 3bb50ce9203d1..b893de6f84475 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/RntbdTransportClientTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/RntbdTransportClientTest.java @@ -5,7 +5,7 @@ import com.azure.cosmos.implementation.BadRequestException; import com.azure.cosmos.implementation.ConflictException; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.CosmosKeyCredential; import com.azure.cosmos.implementation.ConnectionPolicy; import com.azure.cosmos.implementation.ForbiddenException; @@ -675,7 +675,7 @@ public void verifyGoneResponseMapsToGoneException() throws Exception { public void verifyNetworkFailure( final FailureValidator.Builder builder, final RxDocumentServiceRequest request, - final CosmosClientException exception + final CosmosException exception ) { // TODO: DANOBLE: Implement RntbdTransportClientTest.verifyNetworkFailure // Links: diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/StoreReaderTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/StoreReaderTest.java index f085bfdaca747..2aebed5b514a2 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/StoreReaderTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/StoreReaderTest.java @@ -4,7 +4,7 @@ package com.azure.cosmos.implementation.directconnectivity; import com.azure.cosmos.ConsistencyLevel; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.GoneException; import com.azure.cosmos.implementation.NotFoundException; import com.azure.cosmos.implementation.PartitionIsMigratingException; @@ -103,11 +103,11 @@ public Object[][] verifyCanContinueOnExceptionArgProvider() { } @Test(groups = "unit", dataProvider = "verifyCanContinueOnExceptionArgProvider") - public void verifyCanContinueOnException(CosmosClientException dce, Boolean shouldVerify) { - CosmosClientException capturedFailure = null; + public void verifyCanContinueOnException(CosmosException dce, Boolean shouldVerify) { + CosmosException capturedFailure = null; try { StoreReader.verifyCanContinueOnException(dce); - } catch (CosmosClientException e) { + } catch (CosmosException e) { capturedFailure = e; } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/StoreResultValidator.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/StoreResultValidator.java index b9c4b3e8ddc25..4e819ea24308a 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/StoreResultValidator.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/directconnectivity/StoreResultValidator.java @@ -3,7 +3,7 @@ package com.azure.cosmos.implementation.directconnectivity; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.FailureValidator; import java.net.URI; @@ -45,7 +45,7 @@ public Builder withStoreResponse(StoreResponseValidator storeResponseValidator) public void validate(StoreResult storeResult) { try { storeResponseValidator.validate(storeResult.toResponse()); - }catch (CosmosClientException e) { + }catch (CosmosException e) { fail(e.getMessage()); } } @@ -60,7 +60,7 @@ public Builder withException(FailureValidator failureValidator) { public void validate(StoreResult storeResult) { try { failureValidator.validate(storeResult.getException()); - }catch (CosmosClientException e) { + }catch (CosmosException e) { fail(e.getMessage()); } } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/query/DocumentProducerTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/query/DocumentProducerTest.java index e420a2cdb6ed9..6a8dc6a8b5a1d 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/query/DocumentProducerTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/implementation/query/DocumentProducerTest.java @@ -4,8 +4,8 @@ import com.azure.cosmos.BridgeInternal; import com.azure.cosmos.implementation.ConnectionPolicy; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.models.CosmosError; +import com.azure.cosmos.CosmosException; +import com.azure.cosmos.implementation.CosmosError; import com.azure.cosmos.models.FeedResponse; import com.azure.cosmos.implementation.Document; import com.azure.cosmos.implementation.GlobalEndpointManager; @@ -437,8 +437,8 @@ public void retriesExhausted() { subscriber.assertValueCount(responsesBeforeThrottle.size()); } - private CosmosClientException mockThrottlingException(Duration retriesAfterDuration) { - CosmosClientException throttleException = mock(CosmosClientException.class); + private CosmosException mockThrottlingException(Duration retriesAfterDuration) { + CosmosException throttleException = mock(CosmosException.class); doReturn(429).when(throttleException).getStatusCode(); doReturn(new StackTraceElement[0]).when(throttleException).getStackTrace(); doReturn(retriesAfterDuration).when(throttleException).getRetryAfterDuration(); @@ -718,11 +718,11 @@ public CapturedInvocation(RxDocumentServiceRequest request, PartitionAnswer.Resp } } - private static CosmosClientException partitionKeyRangeGoneException() { + private static CosmosException partitionKeyRangeGoneException() { Map headers = new HashMap<>(); headers.put(HttpConstants.HttpHeaders.SUB_STATUS, Integer.toString(HttpConstants.SubStatusCodes.PARTITION_KEY_RANGE_GONE)); - return BridgeInternal.createCosmosClientException(HttpConstants.StatusCodes.GONE, new CosmosError(), headers); + return BridgeInternal.createCosmosException(HttpConstants.StatusCodes.GONE, new CosmosError(), headers); } protected void capture(String partitionId, CapturedInvocation captureInvocation) { diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/AggregateQueryTests.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/AggregateQueryTests.java index decbcbda007ae..d860aa7dcd406 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/AggregateQueryTests.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/AggregateQueryTests.java @@ -6,7 +6,7 @@ import com.azure.cosmos.CosmosAsyncClient; import com.azure.cosmos.CosmosAsyncContainer; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.util.CosmosPagedFlux; import com.azure.cosmos.implementation.CosmosItemProperties; import com.azure.cosmos.models.FeedOptions; @@ -71,7 +71,7 @@ public AggregateQueryTests(CosmosClientBuilder clientBuilder) { public void queryDocumentsWithAggregates(boolean qmEnabled) throws Exception { FeedOptions options = new FeedOptions(); - + options.setPopulateQueryMetrics(qmEnabled); options.setMaxDegreeOfParallelism(2); @@ -196,7 +196,7 @@ public void before_AggregateQueryTests() throws Throwable { truncateCollection(createdCollection); } catch (Throwable throwable) { throwable = Exceptions.unwrap(throwable); - if (!(throwable instanceof CosmosClientException)) { + if (!(throwable instanceof CosmosException)) { throw new AssertionError(lenientFormat("stopping test due to collection %s truncation failure: ", createdCollection, throwable)); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/DocumentCrudTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/DocumentCrudTest.java index d3ad282eb0d15..81724f9cdd782 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/DocumentCrudTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/DocumentCrudTest.java @@ -8,7 +8,7 @@ import com.azure.cosmos.implementation.HttpConstants; import com.azure.cosmos.models.CosmosAsyncItemResponse; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.CosmosItemRequestOptions; import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.models.PartitionKey; @@ -209,7 +209,7 @@ public void readDocument_DoesntExist(String documentId) throws InterruptedExcept options, CosmosItemProperties.class); FailureValidator validator = new FailureValidator.Builder() - .instanceOf(CosmosClientException.class) + .instanceOf(CosmosException.class) .statusCode(404) .documentClientExceptionToStringExcludesHeader(HttpConstants.HttpHeaders.AUTHORIZATION) .build(); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/MultiMasterConflictResolutionTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/MultiMasterConflictResolutionTest.java index 6f25b8b1f2e82..4f2bbdd0b94d7 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/MultiMasterConflictResolutionTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/MultiMasterConflictResolutionTest.java @@ -9,7 +9,7 @@ import com.azure.cosmos.models.CosmosAsyncContainerResponse; import com.azure.cosmos.CosmosAsyncDatabase; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.CosmosContainerProperties; import com.azure.cosmos.models.CosmosContainerRequestOptions; import com.azure.cosmos.CosmosDatabaseForTest; @@ -77,7 +77,7 @@ public void conflictResolutionPolicyCRUD() { } catch (Exception e) { // when (e.StatusCode == HttpStatusCode.BadRequest) - CosmosClientException dce = Utils.as(e, CosmosClientException.class); + CosmosException dce = Utils.as(e, CosmosException.class); if (dce != null && dce.getStatusCode() == 400) { assertThat(dce.getMessage()).contains("Invalid path '\\/a\\/b' for last writer wins conflict resolution"); } else { @@ -94,7 +94,7 @@ public void conflictResolutionPolicyCRUD() { fail("Expected exception on invalid path."); } catch (Exception e) { // when (e.StatusCode == HttpStatusCode.BadRequest) - CosmosClientException dce = Utils.as(e, CosmosClientException.class); + CosmosException dce = Utils.as(e, CosmosException.class); if (dce != null && dce.getStatusCode() == 400) { assertThat(dce.getMessage()).contains("Invalid path 'someText' for last writer wins conflict resolution"); } else { @@ -147,7 +147,7 @@ public void invalidConflictResolutionPolicy_LastWriterWinsWithStoredProc() throw new CosmosContainerRequestOptions()); FailureValidator validator = new FailureValidator.Builder() - .instanceOf(CosmosClientException.class) + .instanceOf(CosmosException.class) .statusCode(400) .errorMessageContains("LastWriterWins conflict resolution mode should not have conflict resolution procedure set.") .build(); @@ -169,7 +169,7 @@ public void invalidConflictResolutionPolicy_CustomWithPath() throws Exception { new CosmosContainerRequestOptions()); FailureValidator validator = new FailureValidator.Builder() - .instanceOf(CosmosClientException.class) + .instanceOf(CosmosException.class) .statusCode(400) .errorMessageContains("Custom conflict resolution mode should not have conflict resolution path set.") .build(); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/MultiOrderByQueryTests.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/MultiOrderByQueryTests.java index dd4aede186268..2d78831fe350d 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/MultiOrderByQueryTests.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/MultiOrderByQueryTests.java @@ -9,7 +9,7 @@ import com.azure.cosmos.CosmosAsyncClient; import com.azure.cosmos.CosmosAsyncContainer; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.CosmosContainerProperties; import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.util.CosmosPagedFlux; @@ -190,9 +190,9 @@ private CosmosItemProperties generateMultiOrderByDocument() { } @Test(groups = { "simple" }, timeOut = TIMEOUT) - public void queryDocumentsWithMultiOrder() throws CosmosClientException, InterruptedException { + public void queryDocumentsWithMultiOrder() throws InterruptedException { FeedOptions feedOptions = new FeedOptions(); - + boolean[] booleanValues = new boolean[] {true, false}; CosmosContainerProperties containerSettings = documentCollection.read().block().getProperties(); @@ -247,7 +247,7 @@ public void queryDocumentsWithMultiOrder() throws CosmosClientException, Interru "ORDER BY " + orderByItemStringBuilder.toString(); List expectedOrderedList = top(sort(filter(this.documents, hasFilter), compositeIndex, invert), hasTop, topCount) ; - + CosmosPagedFlux queryObservable = documentCollection.queryItems(query, feedOptions, CosmosItemProperties.class); FeedResponseListValidator validator = new FeedResponseListValidator diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/OrderbyDocumentQueryTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/OrderbyDocumentQueryTest.java index 35ad0f978e778..da7bbec66a2b6 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/OrderbyDocumentQueryTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/OrderbyDocumentQueryTest.java @@ -8,7 +8,7 @@ import com.azure.cosmos.CosmosAsyncDatabase; import com.azure.cosmos.CosmosBridgeInternal; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.util.CosmosPagedFlux; import com.azure.cosmos.implementation.CosmosItemProperties; @@ -366,8 +366,7 @@ public void queryDocumentsWithInvalidOrderByContinuationTokensString(String sort this.assertInvalidContinuationToken(query, new int[] { 1, 5, 10, 100 }, expectedResourceIds); } - public CosmosItemProperties createDocument(CosmosAsyncContainer cosmosContainer, Map keyValueProps) - throws CosmosClientException { + public CosmosItemProperties createDocument(CosmosAsyncContainer cosmosContainer, Map keyValueProps) { CosmosItemProperties docDefinition = getDocumentDefinition(keyValueProps); return BridgeInternal.getProperties(cosmosContainer.createItem(docDefinition).block()); } @@ -454,7 +453,7 @@ private void assertInvalidContinuationToken(String query, int[] pageSize, List> testSubscriber = new TestSubscriber<>(); queryObservable.byPage(orderByContinuationToken.toString(),1).subscribe(testSubscriber); testSubscriber.awaitTerminalEvent(TIMEOUT, TimeUnit.MILLISECONDS); - testSubscriber.assertError(CosmosClientException.class); + testSubscriber.assertError(CosmosException.class); } while (requestContinuation != null); } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/ParallelDocumentQueryTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/ParallelDocumentQueryTest.java index 4a6b9b8302e19..6e6fff64223b6 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/ParallelDocumentQueryTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/ParallelDocumentQueryTest.java @@ -9,7 +9,7 @@ import com.azure.cosmos.CosmosAsyncDatabase; import com.azure.cosmos.CosmosBridgeInternal; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.util.CosmosPagedFlux; import com.azure.cosmos.implementation.ItemOperations; @@ -186,7 +186,7 @@ public void invalidQuerySyntax() { CosmosPagedFlux queryObservable = createdCollection.queryItems(query, options, CosmosItemProperties.class); FailureValidator validator = new FailureValidator.Builder() - .instanceOf(CosmosClientException.class) + .instanceOf(CosmosException.class) .statusCode(400) .notNullActivityId() .build(); @@ -489,12 +489,12 @@ public void invalidQuerySytax() throws Exception { CosmosPagedFlux queryObservable = createdCollection.queryItems(query, options, CosmosItemProperties.class); - FailureValidator validator = new FailureValidator.Builder().instanceOf(CosmosClientException.class) + FailureValidator validator = new FailureValidator.Builder().instanceOf(CosmosException.class) .statusCode(400).notNullActivityId().build(); validateQueryFailure(queryObservable.byPage(), validator); } - public CosmosItemProperties createDocument(CosmosAsyncContainer cosmosContainer, int cnt) throws CosmosClientException { + public CosmosItemProperties createDocument(CosmosAsyncContainer cosmosContainer, int cnt) { CosmosItemProperties docDefinition = getDocumentDefinition(cnt); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/PermissionQueryTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/PermissionQueryTest.java index 1f9172044da62..8a667c6469b53 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/PermissionQueryTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/PermissionQueryTest.java @@ -6,14 +6,13 @@ import com.azure.cosmos.CosmosAsyncDatabase; import com.azure.cosmos.CosmosAsyncUser; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.DatabaseForTest; import com.azure.cosmos.implementation.FailureValidator; import com.azure.cosmos.implementation.FeedResponseListValidator; import com.azure.cosmos.implementation.FeedResponseValidator; import com.azure.cosmos.models.CosmosPermissionProperties; import com.azure.cosmos.models.CosmosUserProperties; -import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.models.PermissionMode; import com.azure.cosmos.util.CosmosPagedFlux; import org.testng.annotations.AfterClass; @@ -113,7 +112,7 @@ public void invalidQuerySytax() throws Exception { CosmosPagedFlux queryObservable = createdUser.queryPermissions(query); FailureValidator validator = new FailureValidator.Builder() - .instanceOf(CosmosClientException.class) + .instanceOf(CosmosException.class) .statusCode(400) .notNullActivityId() .build(); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/ReadFeedExceptionHandlingTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/ReadFeedExceptionHandlingTest.java index 2fa9ff8b01c0e..0692f858f765b 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/ReadFeedExceptionHandlingTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/ReadFeedExceptionHandlingTest.java @@ -43,7 +43,7 @@ public void readFeedException() throws Exception { frps.add(BridgeInternal.createFeedResponse(dbs, null)); Flux> response = Flux.merge(Flux.fromIterable(frps)) - .mergeWith(Flux.error(BridgeInternal.createCosmosClientException(0))) + .mergeWith(Flux.error(BridgeInternal.createCosmosException(0))) .mergeWith(Flux.fromIterable(frps)); final CosmosAsyncClientWrapper mockedClientWrapper = Mockito.spy(new CosmosAsyncClientWrapper(client)); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/SinglePartitionDocumentQueryTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/SinglePartitionDocumentQueryTest.java index a27aa706af817..8083015e7f2d7 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/SinglePartitionDocumentQueryTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/SinglePartitionDocumentQueryTest.java @@ -6,7 +6,7 @@ import com.azure.cosmos.CosmosAsyncClient; import com.azure.cosmos.CosmosAsyncContainer; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.guava25.collect.Lists; import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.util.CosmosPagedFlux; @@ -249,7 +249,7 @@ public void invalidQuerySytax() throws Exception { CosmosPagedFlux queryObservable = createdCollection.queryItems(query, options, CosmosItemProperties.class); FailureValidator validator = new FailureValidator.Builder() - .instanceOf(CosmosClientException.class) + .instanceOf(CosmosException.class) .statusCode(400) .notNullActivityId() .build(); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/StoredProcedureQueryTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/StoredProcedureQueryTest.java index 0d4c0a2231e0b..59cb84463469f 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/StoredProcedureQueryTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/StoredProcedureQueryTest.java @@ -5,8 +5,7 @@ import com.azure.cosmos.CosmosAsyncClient; import com.azure.cosmos.CosmosAsyncContainer; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.models.ModelBridgeInternal; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.util.CosmosPagedFlux; import com.azure.cosmos.models.CosmosStoredProcedureProperties; import com.azure.cosmos.models.FeedOptions; @@ -114,7 +113,7 @@ public void invalidQuerySytax() throws Exception { CosmosPagedFlux queryObservable = createdCollection.getScripts() .queryStoredProcedures(query, options); - FailureValidator validator = new FailureValidator.Builder().instanceOf(CosmosClientException.class) + FailureValidator validator = new FailureValidator.Builder().instanceOf(CosmosException.class) .statusCode(400).notNullActivityId().build(); validateQueryFailure(queryObservable.byPage(), validator); } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/TestSuiteBase.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/TestSuiteBase.java index 8ef4dbf429362..24f3f531afa00 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/TestSuiteBase.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/TestSuiteBase.java @@ -12,7 +12,7 @@ import com.azure.cosmos.CosmosBridgeInternal; import com.azure.cosmos.CosmosClient; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.CosmosDatabase; import com.azure.cosmos.CosmosDatabaseForTest; import com.azure.cosmos.CosmosKeyCredential; @@ -74,7 +74,6 @@ import java.time.Duration; import java.util.ArrayList; -import java.util.Collection; import java.util.Collections; import java.util.List; import java.util.UUID; @@ -591,7 +590,7 @@ public static void safeDeleteDocument(CosmosAsyncContainer cosmosContainer, Stri try { cosmosContainer.deleteItem(documentId, new PartitionKey(partitionKey)).block(); } catch (Exception e) { - CosmosClientException dce = Utils.as(e, CosmosClientException.class); + CosmosException dce = Utils.as(e, CosmosException.class); if (dce == null || dce.getStatusCode() != 404) { throw e; } @@ -631,7 +630,7 @@ static protected CosmosDatabase createSyncDatabase(CosmosClient client, String d CosmosDatabaseProperties databaseSettings = new CosmosDatabaseProperties(databaseId); try { return client.createDatabase(databaseSettings).getDatabase(); - } catch (CosmosClientException e) { + } catch (CosmosException e) { e.printStackTrace(); } return null; diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/TriggerQueryTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/TriggerQueryTest.java index 5ab2a076d7e8b..38f52d03c70ab 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/TriggerQueryTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/TriggerQueryTest.java @@ -5,13 +5,12 @@ import com.azure.cosmos.CosmosAsyncClient; import com.azure.cosmos.CosmosAsyncContainer; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.implementation.FailureValidator; import com.azure.cosmos.implementation.FeedResponseListValidator; import com.azure.cosmos.implementation.FeedResponseValidator; import com.azure.cosmos.models.CosmosTriggerProperties; import com.azure.cosmos.models.FeedOptions; -import com.azure.cosmos.models.ModelBridgeInternal; import com.azure.cosmos.models.TriggerOperation; import com.azure.cosmos.models.TriggerType; import com.azure.cosmos.util.CosmosPagedFlux; @@ -121,7 +120,7 @@ public void invalidQuerySytax() throws Exception { CosmosPagedFlux queryObservable = createdCollection.getScripts().queryTriggers(query, options); FailureValidator validator = new FailureValidator.Builder() - .instanceOf(CosmosClientException.class) + .instanceOf(CosmosException.class) .statusCode(400) .notNullActivityId() .build(); diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/UniqueIndexTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/UniqueIndexTest.java index d39e7d3af6e95..f42407a3ef99b 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/UniqueIndexTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/UniqueIndexTest.java @@ -8,7 +8,7 @@ import com.azure.cosmos.CosmosAsyncContainer; import com.azure.cosmos.CosmosAsyncDatabase; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.DirectConnectionConfig; import com.azure.cosmos.models.CosmosContainerProperties; import com.azure.cosmos.CosmosDatabaseForTest; @@ -204,8 +204,8 @@ public void uniqueKeySerializationDeserialization() { ImmutableList.of(ImmutableList.of("/name", "/description"))); } - private CosmosClientException getDocumentClientException(RuntimeException e) { - CosmosClientException dce = Utils.as(e, CosmosClientException.class); + private CosmosException getDocumentClientException(RuntimeException e) { + CosmosException dce = Utils.as(e, CosmosException.class); assertThat(dce).isNotNull(); return dce; } diff --git a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/UserDefinedFunctionQueryTest.java b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/UserDefinedFunctionQueryTest.java index 097978fc5dab0..ead18c7738b07 100644 --- a/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/UserDefinedFunctionQueryTest.java +++ b/sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/rx/UserDefinedFunctionQueryTest.java @@ -5,8 +5,7 @@ import com.azure.cosmos.CosmosAsyncClient; import com.azure.cosmos.CosmosAsyncContainer; import com.azure.cosmos.CosmosClientBuilder; -import com.azure.cosmos.CosmosClientException; -import com.azure.cosmos.models.ModelBridgeInternal; +import com.azure.cosmos.CosmosException; import com.azure.cosmos.util.CosmosPagedFlux; import com.azure.cosmos.models.CosmosUserDefinedFunctionProperties; import com.azure.cosmos.models.FeedOptions; @@ -122,7 +121,7 @@ public void invalidQuerySytax() throws Exception { CosmosPagedFlux queryObservable = createdCollection.getScripts().queryUserDefinedFunctions(query, options); FailureValidator validator = new FailureValidator.Builder() - .instanceOf(CosmosClientException.class) + .instanceOf(CosmosException.class) .statusCode(400) .notNullActivityId() .build();