Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-3: [feat. request]: Operational Data -- Rewards Cycle Time & Harvest Time on Setts #129

Closed
benefacto opened this issue May 3, 2021 — with Board Genius Sync · 3 comments
Assignees

Comments

Copy link
Contributor

benefacto commented May 3, 2021

Description

Request from @BenLeibig
"It would also be nice if you could include information around:

Rewards Cycle Time
Harvest Time on setts (harvest is for all setts per chain I think)

These are other operational data our community cares about. Maybe this doesn't fit well into changes in the API, but if you can easily build in metrics points/health checks that would be nice.

Cycles should occur every 2 hours but is sometimes late, more than 4-6 hours is bad/go red.
BSC harvests should occur ever 2 hours
ETH harvests should occur every 24 hours
These numbers should be dynamic.

This is a suggestion not a requirement."

UI implementation still TBD -- @benefacto

Request Metrics

Metric Rating
Priority TBD
Effort TBD
Risk TBD

Options: low, medium, high

Documentation (optional)

Add any supporting documentation, proposed API responses, interaction diagrams etc.

Resources (optional)

Add any new or updated resource requirements for the system

@benefacto
Copy link
Contributor Author

benefacto commented May 3, 2021

@cedricwaxwing Probably needs UI design for the Setts page

@cedricwaxwing
Copy link

I've done a little noodling on this, and we're in a bit of a tricky spot for the design. I've created the most condensed version possible in this quick local edit:
image

But, as you can see, it appears our rows can't really handle any additional information. We may want to consider putting a pin in this initiative until we hash out a better solution for displaying the Sett Vaults. For reference, here's a rough sketch/prototype of what I have been playing around with:

https://www.figma.com/proto/wu9txl08Z5iK0EIHolxOju/Redesign-playground?page-id=49%3A132&node-id=61%3A4&viewport=-29%2C511%2C1&scaling=min-zoom

@Tritium-VLK Tritium-VLK changed the title [feat. request]: Operational Data -- Rewards Cycle Time & Harvest Time on Setts API-3: [feat. request]: Operational Data -- Rewards Cycle Time & Harvest Time on Setts Jun 4, 2021
@okjintao
Copy link
Contributor

rescope: add last harvest to vault response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants