You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Great plugin, I enjoy using it. However, I installed a fresh copy directly from npm (npm install --save vue-notifyjs) and it fetched version 0.1.7. I was getting warnings in my browsers console that stated the key should not be a complex but a primitive type like string or integer.
Looking in the source code of the module in my node_modules/vue-notifyjs/dist I could find the culprit rather easy:
I've manually changed key: notification to key: index and the error was gone. Now the funky bits click in: I forked your repo on GitHub and tried to create a pull request. But then I saw that your source code already contains a fix: You use the timestamp value of the notification to create a unique key. Very nice, but why is this not included on the NPM repo? I have never published anything on NPM so I can only assume that maybe you've uploaded the wrong version?
The text was updated successfully, but these errors were encountered:
Great plugin, I enjoy using it. However, I installed a fresh copy directly from npm (
npm install --save vue-notifyjs
) and it fetched version0.1.7
. I was getting warnings in my browsers console that stated the key should not be a complex but a primitive type like string or integer.Looking in the source code of the module in my
node_modules/vue-notifyjs/dist
I could find the culprit rather easy:I've manually changed
key: notification
tokey: index
and the error was gone. Now the funky bits click in: I forked your repo on GitHub and tried to create a pull request. But then I saw that your source code already contains a fix: You use the timestamp value of the notification to create a unique key. Very nice, but why is this not included on the NPM repo? I have never published anything on NPM so I can only assume that maybe you've uploaded the wrong version?The text was updated successfully, but these errors were encountered: