This repository has been archived by the owner on Nov 28, 2019. It is now read-only.
Fix progress reporting & initialblockdownload #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should be easy to test via Does this need port to elements? |
stevenroose
force-pushed
the
progress
branch
from
874e602
to
1546538
Compare
|
@instagibbs Updated PR to use |
|
I'd really like a functional test for this since it's touching a number of internals I haven't touched before |
stevenroose
force-pushed
the
progress
branch
7 times, most recently
from
28c1fe7
to
bf8569a
Compare
|
utACK, waiting on travis |
stevenroose
force-pushed
the
progress
branch
2 times, most recently
from
0148fae
to
ee1d706
Compare
stevenroose
added a commit
that referenced
this pull request
Dec 7, 2018
This was referenced Dec 11, 2018
shesek
added a commit
to shesek/electrs
that referenced
this pull request
Jan 25, 2019
shesek
added a commit
to shesek/electrs
that referenced
this pull request
Jan 26, 2019
stevenroose
added a commit
to stevenroose/elements
that referenced
this pull request
Mar 20, 2019
Reimplementation of Blockstream/liquid#6
stevenroose
added a commit
to stevenroose/elements
that referenced
this pull request
Mar 20, 2019
Reimplementation of Blockstream/liquid#6
stevenroose
added a commit
to stevenroose/elements
that referenced
this pull request
Mar 21, 2019
Reimplementation of Blockstream/liquid#6
stevenroose
added a commit
to stevenroose/elements
that referenced
this pull request
Mar 21, 2019
Reimplementation of Blockstream/liquid#6
instagibbs
added a commit
to ElementsProject/elements
that referenced
this pull request
Mar 21, 2019
5b8c79a Fix progress reporting issue (Steven Roose) Pull request description: Based on #515 Reimplementation of Blockstream/liquid#6 Tree-SHA512: 292be614802d0ca74bc9a19080bce46812bc4d5c386ed01f87e74898830946276359100d404868dda8fd4b4087699a9be804370a8ad387c7d92f4a3f5572d0b0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #9
Both the debug log and
getblockchaininfowere showingprogress=1always.This PR replaces Core's chain statistics-based estimation with simple block-based estimation because are dealing with fixed-interval blocks.
Also implements the
initialblockdownloadvalue ingetblockchaininfobased on the same heuristic.