Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MuSig BIP Draft TODOs #169

Closed
11 of 12 tasks
jonasnick opened this issue Mar 2, 2022 · 1 comment
Closed
11 of 12 tasks

MuSig BIP Draft TODOs #169

jonasnick opened this issue Mar 2, 2022 · 1 comment

Comments

@jonasnick
Copy link
Contributor

jonasnick commented Mar 2, 2022

  • Add tweaking (Add ordinary and x-only tweaking to spec and simplify implementation #167).
  • Add reference code (musig-spec: Add naive Python reference implementation #166).
  • Try to avoid O(n²) algorithm for finding of second unique key
  • Add more test vectors (in particular, test vectors that result in failure).
  • Add proper design and motivation section.
    • Mention that sorting the keys is optional and why.
  • Improve nonce derivation.
    • As specified right now, if the output of the RNG used as the secret nonce ever repeats, the secret key leaks immediately. It is possible to (slightly) reduce the possibility of nonce reuse by deriving the secret nonce from the RNG output, aggregate public key and message.
    • Mention "counter mode" nonce derivation, i.e. deriving from secret key and non-repeating counter.
    • Add BIP 340-like sidechannel resistance.
    • Explain deterministic nonce derivation 2-of-2 nonce example.
  • Post BIP draft to bitcoin-dev mailing list.
@jonasnick
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant