Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework how Newton code is included. #1333

Open
1uc opened this issue Jul 8, 2024 · 1 comment
Open

Rework how Newton code is included. #1333

1uc opened this issue Jul 8, 2024 · 1 comment

Comments

@1uc
Copy link
Collaborator

1uc commented Jul 8, 2024

We now unconditionally add 450 lines of boiler plate related to Newton to every generated file. It makes files needlessly hard to read. We should only include the code when needed.

It also needs to be improved to print all includes at the top.
@1uc
Copy link
Collaborator Author

1uc commented Jul 8, 2024

One could also have a flag in NMODL to produce the files. Which could be use by nrnivmodl to dump them in a location the compiler can pick them up again.

@1uc 1uc changed the title Fix generated code. Reworks how Newton code is included. Aug 22, 2024
@1uc 1uc changed the title Reworks how Newton code is included. Rework how Newton code is included. Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1uc