Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to upgrade certain gulp-combine-mq package because of Node 10 #209

Open
ssdatar opened this issue Jun 5, 2018 · 2 comments
Open

Need to upgrade certain gulp-combine-mq package because of Node 10 #209

ssdatar opened this issue Jun 5, 2018 · 2 comments
Labels

Comments

@ssdatar
Copy link
Contributor

ssdatar commented Jun 5, 2018

If you upgrade to Node v10, a certain dependency natives 1.1.0 causes the gulp server task to crash. Natives is a dependency of gulp-combine-mq. This is the error message.

gulp[66141]: ../src/node_contextify.cc:629:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed.
 1: node::Abort() [/usr/local/bin/node]
 2: node::MakeCallback(v8::Isolate*, v8::Local<v8::Object>, char const*, int, v8::Local<v8::Value>*, node::async_context) [/usr/local/bin/node]
 3: node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/bin/node]
 4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/usr/local/bin/node]
 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/bin/node]
 6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node]
 7: 0x31c0e228427d
 8: 0x31c0e228f755
 9: 0x31c0e230bc20
10: 0x31c0e22944f7
11: 0x31c0e22944f7
12: 0x31c0e22944f7
Abort trap: 6

And this is the dependency graph if you run yarn why natives.

[1/4] 🤔  Why do we have the module "natives"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "natives@1.1.0"
info Reasons this module exists
   - "gulp-combine-mq#graceful-fs" depends on it
   - Hoisted from "gulp-combine-mq#graceful-fs#natives"
   - Hoisted from "gulp#vinyl-fs#graceful-fs#natives"
info Disk size without dependencies: "12KB"
info Disk size with unique dependencies: "12KB"
info Disk size with transitive dependencies: "12KB"
info Number of shared dependencies: 0
@ssdatar
Copy link
Contributor Author

ssdatar commented Jun 5, 2018

Node 9 will soon go into maintenance, so we definitely need to upgrade this and a whole lot of our other tasks, which are old based on node v9 or below

@ssdatar
Copy link
Contributor Author

ssdatar commented Jun 5, 2018

Related issue gulpjs/gulp#2162

@ssdatar ssdatar added the bug label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant