Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression detection follow-ons #202

Open
2 tasks
woodruffw opened this issue Feb 14, 2024 · 2 comments
Open
2 tasks

Regression detection follow-ons #202

woodruffw opened this issue Feb 14, 2024 · 2 comments
Assignees

Comments

@woodruffw
Copy link
Collaborator

Once #201 is merged, some things:

  • Leaving a new comment each time is pretty noisy, we could modify a single comment instead.
  • We should gate a PR on no-regressions || (regressions && regressions-triaged) labels. I tried this with a basic workflow in Detect testcase regressions #201, but it's limited by the fact that workflows can't trigger other workflows.
@woodruffw woodruffw self-assigned this Feb 14, 2024
@alex
Copy link
Collaborator

alex commented Feb 14, 2024

Suggestion: Comment on all failures, and only comment on passes if it's going from fail -> pass.

@woodruffw
Copy link
Collaborator Author

Suggestion: Comment on all failures, and only comment on passes if it's going from fail -> pass.

Thanks, done with 88f27df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants