Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan matcher flag to prevent pose/tf publishing on pose jumps? #48

Open
corot opened this issue Apr 19, 2016 · 3 comments
Open

scan matcher flag to prevent pose/tf publishing on pose jumps? #48

corot opened this issue Apr 19, 2016 · 3 comments

Comments

@corot
Copy link
Contributor

corot commented Apr 19, 2016

I'm using laser scan matcher combined with odometry using robot_localization. In general works ok, but sometimes it does pose jumps without showing any error. This is different from issue #20: I don't experience that errors anymore. But jumps are by definition erroneous, as visual odometry must be continuous. So I propose to add a couple of parameters, for example min_jump_dist and min_jump_angle and ignore any pose update bigger than those values. Or alternatively, set a very big covariance proportional to the jump.

They can default to 0, meaning disable the feature.

What do you think? Make sense the idea?

@1plus-1
Copy link

1plus-1 commented Feb 5, 2020

Lately I meet the similar issue. And I found the solution from #58. EwingKang had a fix in this fork: https://github.com/EwingKang/scan_tools. It fixes my issue.

@130s
Copy link
Collaborator

130s commented Jul 14, 2022

@malban Do you think your #79 addresses this as well?

@malban
Copy link

malban commented Jul 15, 2022

Not sure. #79 fixes one major source of jumps in the current code, caused by incorrect predictions, which could have been the root cause of what this issue was addressing. But jumps might also be caused by other things related to the sensor data and actual scan match failure.

Hard to know without more data or feedback from the reporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants