Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"back" button doesn't work in Search #970

Closed
1 of 4 tasks
msm-cert opened this issue Aug 19, 2024 · 1 comment · Fixed by #975
Closed
1 of 4 tasks

"back" button doesn't work in Search #970

msm-cert opened this issue Aug 19, 2024 · 1 comment · Fixed by #975
Labels
type:bug Something isn't working zone:frontend MWDB frontend tasks

Comments

@msm-cert
Copy link
Member

Environment information

  • MWDB version (from /about):
  • Installation method:
    • mwdb.cert.pl service
    • From PyPi (pip install mwdb-core)
    • From docker-compose
    • Other (please explain)
  • Plugins installed:

Behaviour the bug (what happened?)

This is related to karton
go to a sample URL (example file shared directly, but any should worl)
[click] search artifacts in karton
[click] "back" in the browser

Expected behaviour

The back button should work

Reproduction Steps

as above

@psrok1 psrok1 changed the title "back" button doesn't work in the karton plugin "back" button doesn't work in Search Aug 19, 2024
@psrok1
Copy link
Member

psrok1 commented Aug 19, 2024

When we navigate to https://mwdb.cert.pl/search?q=<query>, we're immediately redirected to https://mwdb.cert.pl/search?q=<query>&count=0 using pushState instead of replaceState. It causes a loop because when we want to go back, we're going back to the URI without count=0 which immediately redirects us back to the URI with count=0, so we can't go back to the previous webpage.

This bug applies in general to the RecentView components.

@psrok1 psrok1 added type:bug Something isn't working zone:frontend MWDB frontend tasks labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working zone:frontend MWDB frontend tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants