Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Fortran FRE tools with Python ones #68

Open
ashjbarnes opened this issue Sep 6, 2023 · 4 comments
Open

Replace Fortran FRE tools with Python ones #68

ashjbarnes opened this issue Sep 6, 2023 · 4 comments

Comments

@ashjbarnes
Copy link
Collaborator

A barrier for new users on a new machine is the package's reliance on having a compiled set of GFDL's FRE tools. There are Python tools that exist which could help with mosaic generation here but I'm not sure about the processor mask.

Ideally we should add this package as a dependency and move away from FRE tools. This package also includes some great grid generation tools which we should include as options in our package

@navidcy
Copy link
Contributor

navidcy commented Sep 6, 2023

Being depended on FRE tools also limits are CI-testing capabilities. Unless there is a way to run FRE tools somehow that I don't know. @angus-g?

@ashjbarnes
Copy link
Collaborator Author

Yeah for sure it's really annoying! Seems like we're only missing the check mask FRE tool which generates the processor mask. Others appear to be present in the grid tools repo

@ashjbarnes ashjbarnes mentioned this issue Sep 6, 2023
@angus-g
Copy link
Collaborator

angus-g commented Sep 6, 2023

Being depended on FRE tools also limits are CI-testing capabilities. Unless there is a way to run FRE tools somehow that I don't know. @angus-g?

It's pretty easy to build them if we want to test things as they are, or make sure any Python implementations are equivalent. Let me know if you want that set up.

@angus-g angus-g changed the title Replace FORTRAN FMS tools with Python ones Replace Fortran FMS tools with Python ones Sep 6, 2023
@angus-g angus-g changed the title Replace Fortran FMS tools with Python ones Replace Fortran FRE tools with Python ones Sep 6, 2023
@ashjbarnes
Copy link
Collaborator Author

True - whatever you think is best Angus! Is it easy enough to include the compiling of Fortran scripts in the regular conda / pip installation process? Since the python implementation is missing the check-mask maybe it makes sense to stick with Fortran for now and include it in the installation pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants