From 98662dcff437d52291f712ba2e4c1f7daba57193 Mon Sep 17 00:00:00 2001 From: Cadiboo <37298044+Cadiboo@users.noreply.github.com> Date: Sun, 25 Nov 2018 19:43:44 +1100 Subject: [PATCH] small changes --- .../java/cadiboo/nocubes/EventSubscriber.java | 17 ++++++++++------- .../cadiboo/nocubes/renderer/MarchingCubes.java | 6 +++--- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/src/main/java/cadiboo/nocubes/EventSubscriber.java b/src/main/java/cadiboo/nocubes/EventSubscriber.java index 32f44141..ad3f66a0 100644 --- a/src/main/java/cadiboo/nocubes/EventSubscriber.java +++ b/src/main/java/cadiboo/nocubes/EventSubscriber.java @@ -4,8 +4,7 @@ import cadiboo.renderchunkrebuildchunkhooks.event.RebuildChunkBlockEvent; import cadiboo.renderchunkrebuildchunkhooks.event.RebuildChunkBlockRenderInLayerEvent; import cadiboo.renderchunkrebuildchunkhooks.event.RebuildChunkBlockRenderInTypeEvent; -import net.minecraft.block.material.Material; -import net.minecraft.util.BlockRenderLayer; +import cadiboo.renderchunkrebuildchunkhooks.event.RebuildChunkPostEvent; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.common.eventhandler.Event; import net.minecraftforge.fml.common.eventhandler.EventPriority; @@ -38,15 +37,19 @@ public static void onRebuildChunkBlockRenderInLayerEvent(final RebuildChunkBlock @SubscribeEvent(priority = EventPriority.HIGH, receiveCanceled = false) public static void onRebuildChunkBlockRenderInTypeEvent(final RebuildChunkBlockRenderInTypeEvent event) { -// if(event.getBlockState().getMaterial()== Material.AIR) { - event.setResult(Event.Result.DENY); -// } + // if(event.getBlockState().getMaterial()== Material.AIR) { + event.setResult(Event.Result.DENY); + // } } - private static BlockRenderLayer airRenderLayerHook() { + @SubscribeEvent(priority = EventPriority.HIGH, receiveCanceled = false) + public static void onRebuildChunkPostEventEvent(final RebuildChunkPostEvent event) { - return BlockRenderLayer.CUTOUT; + // No. not a good idea + // if (new Random().nextInt(16 + 1) == 0) { + // new Thread(System::gc, "NoCubes Garbage Collecter").start(); + // } } diff --git a/src/main/java/cadiboo/nocubes/renderer/MarchingCubes.java b/src/main/java/cadiboo/nocubes/renderer/MarchingCubes.java index 711fef39..abdb062f 100755 --- a/src/main/java/cadiboo/nocubes/renderer/MarchingCubes.java +++ b/src/main/java/cadiboo/nocubes/renderer/MarchingCubes.java @@ -12,7 +12,6 @@ import net.minecraft.util.math.MathHelper; import net.minecraft.world.ChunkCache; import net.minecraft.world.IBlockAccess; -import org.apache.logging.log4j.LogManager; public class MarchingCubes { @@ -399,11 +398,10 @@ public static boolean renderBlock(IBlockState state, final BlockPos pos, final C final IBlockState textureColorState = state; final BlockPos textureColorPos = new BlockPos(fastx, fasty, fastz); - //TODO it should _never_ be air if (state.getBlock() == Blocks.AIR) { return false; -// LogManager.getLogger().info(state); + // LogManager.getLogger().info(state); } final TextureAtlasSprite sprite = ModUtil.getSprite(textureColorState, textureColorPos, blockRendererDispatcher); @@ -541,6 +539,8 @@ public static boolean renderBlock(IBlockState state, final BlockPos pos, final C vertexList[11] = vertexInterpolation(isolevel, pointList[3], pointList[7], pointValue[3], pointValue[7]); } + //TODO don't render triangle if it is completely horzontal or vetical + for (int triangleIndex = 0; TRIANGLE_TABLE[cubeIndex][triangleIndex] != - 1; triangleIndex += 3) { // tessellator.setBrightness(state.getMixedBrightnessForBlock(cache, x, y + 1, z));