-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smooth trees issue #75
Comments
Sorry for the late response, can you post your client & server config and a screenshot please? |
hewllo? |
Hey, sorry, been a while. Your client config will be in ".minecraft/config/nocubes-client.toml" and your server config will be in ".minecraft/saves/world_name/serverconfig/nocubes-server.toml". Please also share your |
hello? |
Hey, really, really sorry that I've taken so long to help you with this. You should just be able to change That option was added at someone else's request because it looked cool with their texture pack/shader. It's taken so long to respond because:
I should have opened with this, but I'm a little bit more responsive on discord. Feel free to ping me on the nocubes server in #support or pm me @Cadiboo#8887. |
Could you please send your client config and logs again? The fact that you aren’t getting the same issue with your terrain means that it’s got to be caused by that config setting being true or a bug in the mod. You change the value in client config to true when the game isn’t open and it should work when you next open the game. If it doesn’t work when you next open the game, there should be something like “correcting incorrect config value renderSmoothAndVanillaLeaves” that should show the issue. If that doesn’t work, please upload your client and server configs here and I’ll debug the issue on my own computer. |
Yeah, the extra foliage coming out from the sides of the leaves isn't in NoCubes, IIRC that's why the option to display both smooth and vanilla trees was added. NoCubes takes the texture from the side of the block and renders it bent, I'd have to write my own code to add that extra foliage (the way I've done with the short grass). This wouldn't be extremely hard, but I haven't done it yet. Trees have never really looked that good/real in NoCubes and fixing this would involve a lot of work and planning. |
Hey, I’m working on updating the mod to 1.16 currently. I’ve decided to rewrite the mod from the ground up. I’m also planning on backporting the rewrite 1.12.2. Since I’m doing this I have the opportunity to implement support for fancy leaves right into nocubes without the pain of having to rewrite large amounts of code. If you could describe what you would like the leafiness of the trees to look like I‘ll work on implementing it :). The purple things have been fixed in 1.16 already. |
Yes thank you but I don’t want to play Minecraft in 1.16. I’m stuck on 1.12 because some of my fav mods haven’t updated beyond 1.12 and my favorite texture pack is at 1.12. In order to make the trees realistic, I use the foliage mod in conjunction with your mod . In spite of the foliage mod, the trees don’t look leafy while using your mod. If you notice in those pics from June 20 the trees were blocky and leafy — this was before I took your advice on how to un-blockify the leaves. And they’re leafy because of the foliage mod. Now, after your advice, the leaves are no longer blocky but smooth; but smooth and not leafy like how I wanted them to be |
I'm not asking you to.
I understand this, 1.12.2 was my favourite version as well, that's why I said "I’m also planning on backporting the rewrite 1.12.2."
Yeah, it's not possible for stuff like this to "just work" with the way NoCubes is written in 1.12.2. One of my goals in the rewrite is to make stuff more compatible. Another goal is to make stuff look and run better.
You can change (back) your config, I've even created a config GUI for NoCubes.
By "the foliage mod" do you mean BetterFoliage? If so, BetterFoliage changes how leaves look in a performance degrading way that also cannot be compatible with NoCubes. I've previously talked with the author and they've told me that they intend to fix this in the future. |
You done? |
With what? |
what i wanted you to do |
I asked you what you wanted done
And you replied
So if you want me to implement leaves on trees as part of NoCubes then I’m still waiting for you to tell me what you’d like that to look like. You also said
And I said that you could have
I also asked if by “the Foliage mod” you meant BetterFoliage. I asked this because BetterFoliage changes everything in a way that cannot be compatible with NoCubes (they intercept blocks mod-rendering and add extra details right into the raw buffer data that will be rendered to your screen). |
it's better foliage also i dont understand what your point is. you dont know what i want? all i want are the trees to not be blocky. i want them to look like realistic trees so i used your mod and better foliage but it didsnt come out looking. and when i dont use the foliage mod but only yours the trees look too smooth and not like real trees and i tried to counteract this by using better foliage but that didnt work. |
This can’t be done in the mod currently. I’ll look into a solution. This looks promising and I should be able to do it without too much trouble by rendering the part of the model that isn’t the cube’s sides for each leaf block after I’ve smoothed the tree. |
Despite the smooth option being toggled on, the trees still arent smooth; theyre blocky
The text was updated successfully, but these errors were encountered: