Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapbox GL Custom WebGL Layers API integration #700

Closed
rochoa opened this issue Jul 13, 2018 · 5 comments
Closed

Mapbox GL Custom WebGL Layers API integration #700

rochoa opened this issue Jul 13, 2018 · 5 comments
Assignees

Comments

@rochoa
Copy link
Contributor

rochoa commented Jul 13, 2018

Depending on the status of mapbox/mapbox-gl-js#6456, we should evaluate if we migrate from our current approach.

@rochoa rochoa modified the milestone: Public Jul 13, 2018
@Jesus89 Jesus89 self-assigned this Aug 20, 2018
@Jesus89
Copy link
Member

Jesus89 commented Aug 20, 2018

Steps:

NOTE: latest stable MGL version is v0.48.0. We should consider using this version to anticipate possible integration issues, fix possible breaking changes and be more aligned.

cc @rochoa

@rochoa
Copy link
Contributor Author

rochoa commented Aug 20, 2018

Yes, let's use 0.48 or master (if needed).

@Jesus89
Copy link
Member

Jesus89 commented Aug 20, 2018

The branch custom-layers comes from v0.47.0+. Today there are 40 commits between v0.48.0 and master. So the found regression issue is in both.

Between v0.48.0 + custom-layers VS master + custom-layers I prefer to use the stable version v0.48.0 to avoid using and releasing unstable changes for now.

cc @davidmanzanares

@davidmanzanares
Copy link

The performance regression has been mostly fixed by the last merge, see mapbox/mapbox-gl-js#7132

@Jesus89
Copy link
Member

Jesus89 commented Aug 24, 2018

Closed by #886

@Jesus89 Jesus89 closed this as completed Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants