Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror GitHub interpretation in default acceptable conclusions #249

Closed
MattiSG opened this issue Jul 11, 2024 · 0 comments · Fixed by #250
Closed

Mirror GitHub interpretation in default acceptable conclusions #249

MattiSG opened this issue Jul 11, 2024 · 0 comments · Fixed by #250
Assignees

Comments

@MattiSG
Copy link
Contributor

MattiSG commented Jul 11, 2024

Hi and thanks for the push-protected action!

This action is meant to enable pushing to protected branches by creating a temporary branch, running automated checks on it, and merging if GitHub would accept it.
Yet, it differs from GitHub validation by being more strict on its default acceptance criteria. Indeed, GitHub considers skipped checks as successful:

A job that is skipped will report its status as "Success". It will not prevent a pull request from merging, even if it is a required check.

I thus find it confusing that push-protected refuses to merge a branch that would have been accepted by GitHub checks.

I suggest changing the default acceptable_conclusions from success to success,skipped 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants