You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This action is meant to enable pushing to protected branches by creating a temporary branch, running automated checks on it, and merging if GitHub would accept it.
Yet, it differs from GitHub validation by being more strict on its default acceptance criteria. Indeed, GitHub considers skipped checks as successful:
A job that is skipped will report its status as "Success". It will not prevent a pull request from merging, even if it is a required check.
I thus find it confusing that push-protected refuses to merge a branch that would have been accepted by GitHub checks.
I suggest changing the default acceptable_conclusions from success to success,skipped 🙂
The text was updated successfully, but these errors were encountered:
Hi and thanks for the
push-protected
action!This action is meant to enable pushing to protected branches by creating a temporary branch, running automated checks on it, and merging if GitHub would accept it.
Yet, it differs from GitHub validation by being more strict on its default acceptance criteria. Indeed, GitHub considers skipped checks as successful:
I thus find it confusing that
push-protected
refuses to merge a branch that would have been accepted by GitHub checks.I suggest changing the default
acceptable_conclusions
fromsuccess
tosuccess,skipped
🙂The text was updated successfully, but these errors were encountered: