You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The previous version of the tools contained a mechanism for some operations that caused the tileset.json to be written in zipped form when it was zipped in the input, and to be written in non-zipped form when it was not zipped in the input. (See, for example, the previous combineTilesets function).
The current state of the tools tried to emulate this behavior, by keeping track of whether the input tileset.json was zipped. This causes a bug where the tileset.json will not be zipped, even when running gzip.
To solve this: The zippedness of the input should not matter. The tools should always be able to read zipped input, but write the output in un-zipped form, unless zipping was the actual operation that should be performed. This can either be via the gzip command, or via a gzip pipeline stage.
(The (legacy) tilesOnly flag for the gzip operation has to be taken into account here, but that has already been generalized, and should be easy to handle)
The text was updated successfully, but these errors were encountered:
I'll reopen this as a reminder that the legacy behavior of if (inputWasZipped) writeZipped(output) else write(output)
is still applied in the TilesetUpgrader.
The upgrade functionality is addressed, in a far broader sense, in #5 , and this will also affect this aspect of the behavior.
The previous version of the tools contained a mechanism for some operations that caused the
tileset.json
to be written in zipped form when it was zipped in the input, and to be written in non-zipped form when it was not zipped in the input. (See, for example, the previouscombineTilesets
function).The current state of the tools tried to emulate this behavior, by keeping track of whether the input
tileset.json
was zipped. This causes a bug where thetileset.json
will not be zipped, even when runninggzip
.To solve this: The zippedness of the input should not matter. The tools should always be able to read zipped input, but write the output in un-zipped form, unless zipping was the actual operation that should be performed. This can either be via the
gzip
command, or via agzip
pipeline stage.(The (legacy)
tilesOnly
flag for thegzip
operation has to be taken into account here, but that has already been generalized, and should be easy to handle)The text was updated successfully, but these errors were encountered: