You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
on the CPU, we've implemented noData and default for metadata properties (see for example MetadataTableProperty.prototype.get). However, this change has not been propagated to the MetadataStage (which mainly impacts the custom shader portion of ModelExperimental), especially since it does not work exactly the same.
Some initial thoughs:
if the property has a noData sentinel, the shader should not do anything automatically, but the user should have access to this information. perhaps an additional struct field fsInput.metadata.property_noData that stores the sentinel (though what should it be if there's no sentinel?)
However, if there is a default value, it would be nice if such a value replaced the noData value so no extra work is required by the user.
One unfortunate detail is there's no defaultValue() function in GLSL. The closest we have is czm_branchFreeTernary().
This might require further discussion before we get to this. Also it would be best to handle #10248#9572 first so this can be addressed holistically.
on the CPU, we've implemented
noData
anddefault
for metadata properties (see for exampleMetadataTableProperty.prototype.get
). However, this change has not been propagated to theMetadataStage
(which mainly impacts the custom shader portion of ModelExperimental), especially since it does not work exactly the same.Some initial thoughs:
noData
sentinel, the shader should not do anything automatically, but the user should have access to this information. perhaps an additional struct fieldfsInput.metadata.property_noData
that stores the sentinel (though what should it be if there's no sentinel?)default
value, it would be nice if such a value replaced thenoData
value so no extra work is required by the user.One unfortunate detail is there's no
defaultValue()
function in GLSL. The closest we have isczm_branchFreeTernary()
.This might require further discussion before we get to this. Also it would be best to handle #10248 #9572 first so this can be addressed holistically.
CC @lilleyse @IanLilleyT
The text was updated successfully, but these errors were encountered: