Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues to investigate at the Winter Bug Bash. Feb 8-10, 2017 #4897

Closed
8 of 25 tasks
pjcozzi opened this issue Jan 23, 2017 · 24 comments
Closed
8 of 25 tasks

Issues to investigate at the Winter Bug Bash. Feb 8-10, 2017 #4897

pjcozzi opened this issue Jan 23, 2017 · 24 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 23, 2017

Please add a comment with your request (with links to their issues) for bug fixes and small features.

Need ideas? Review issues labeled 'priority'.

See the Winter Bug Bash blog post for more info.

@lftgly
Copy link

lftgly commented Jan 23, 2017

Patrick- How long would it take to finish and merge Andre Nunes work on GPX and or shapefile support? Less than 3 days?
THANKS for considering this:

FYI, I'm almost done with GPX support, all the geometric features are working and just need to be made "pretty". There's some issues with time dynamic Tracks but nothing I can't fix in a couple of days. I'm improving test coverage right now and implementing some missing (non visual) features.

I'd appreciate any example .gpx files you can provide for me to test this further, also feel free to fork my repository and check out the gpx branch to test it yourself.

Patrick Cozzi, you mentioned Demos somewhere, could you please be more specific on what kind of Demos would be appreciated? Would I need to host a cesium app to showcase these Demos?
Thanks,
André Nunes

@emackey
Copy link
Contributor

emackey commented Jan 23, 2017

I see "VR Fixes" in your issue description. Will there be VR headset(s) at the bug bash?

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 23, 2017

@lftgly we'll see what kind of shape the GPX is in; I suspect it is more than three days work. If you have time, you are welcome to evaluate it as well, or - even better - try to finish it. Shapefiles are probably too much for this event.

@emackey we should be able to bring @bagnell's Oculus.

@krheinwald
Copy link

krheinwald commented Jan 26, 2017

#4619 Polyline crashes in rotatable 2D
#4084 Scene.pickPosition support for 2D and CV

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 26, 2017

Thanks for the input, @krheinwald! I updated the list. #4084 is especially a good call!

@jbo023
Copy link
Contributor

jbo023 commented Jan 26, 2017

#4894 Terrain loading errror
#4368 Pick Position problems
#4673 3d tiles unloading

Also if you are working on VR, i do have a HTC Vice at Home and could so some testing if necessary

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Feb 3, 2017

if you are working on VR, i do have a HTC Vice at Home and could so some testing if necessary

Thanks for the offer, we'll let you know!

@juburr
Copy link
Contributor

juburr commented Feb 3, 2017

We would love to see more visual improvements -- we get asked about this a lot! The three label/text tasks are probably our most desired fixes right now. After that, possibly #3279, or anything that can improve the graphics quality without hammering performance.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Feb 3, 2017

Thanks @jburr-nc! I added #3279 to the list above, but the scope is likely to large.

@wintersieck
Copy link

We would also love to see those three visual improvement tasks taken care of. Blurry billboards (#4235) are a constant issue for us. Thanks!

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Feb 3, 2017

@AJWinter #4235 is on the list!

@mramato
Copy link
Contributor

mramato commented Feb 4, 2017

@jburr-nc if imagery quality is a large concern for you, I recommend disabling fxaa and setting maximumScreenSpaceError to 1.33. fxaa is make the image much more crisp (And actually improve GPU performance) and the cost of some jagginess in geometry. Setting maximumScreenSpaceError will make Cesium request more map tiles and terrain, but will better map to what you see at zoom levels in traditional 2D maps.

viewer.scene.fxaa = false;
viewer.scene.globe.maximumScreenSpaceError = 4/3;

@laurensdijkstra
Copy link

We are seeing a reduced level of Terrain detail when zoomed in and a stream of errors like An error occurred in "CesiumTerrainProvider": Failed to obtain terrain tile X: 8449 Y: 1682 Level: 13.

Does this have anything to do with recent updates to the way maximum detail level of Terain can be queried? Could not find an issue regarding this on Github so that's why I'm posting here directly.

@freder
Copy link

freder commented Feb 6, 2017

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Feb 6, 2017

Thanks @freder! For picking in 3d-tiles, what is the precise case? Is it #4368?

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Feb 6, 2017

@laurensdijkstra perhaps ask on the forum; this could be a temporary network issue.

@freder
Copy link

freder commented Feb 6, 2017

@pjcozzi it has to do with model instancing — https://groups.google.com/d/msg/cesium-dev/sUcx0GLI4Qc/SlU96ZkdCQAJ

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Feb 6, 2017

Gotcha, thanks!

@jhalbroo
Copy link

jhalbroo commented Feb 8, 2017

I'd also like to advocate for #3279 . This has been noticed whenever I give a demo of Cesium and a different map viewer (e.g. Google, Open Layers) is shown alongside. I reported the issue here, which was duped to 3279.

@mramato
Copy link
Contributor

mramato commented Feb 8, 2017

@jhalbroo See #4897 (comment) above on tuning Cesium for maximum image quality. Let me know how tweaking those settings work out for you.

The maximumScreenSpaceError default might be changed in the future, but we need to look at it's overall performance/memory/bandwidth impact.

I believe improvements to fxaa are going to require WebGL2, so they are outside the scope of the bash (though I'm not actually at the bash this time so perhaps @bagnell can chime in with more info).

@bagnell
Copy link
Contributor

bagnell commented Feb 8, 2017

@jhalbroo @mramato Anti-aliasing will be improved with WebGL 2, but that is not the issue. The problem is that parts of the scene do not need to be anti-aliased (imagery, labels, ...) and others do (lines, geometry, ...). Right now, FXAA is run on the entire scene. If it is enabled, it will degrade the visual quality of parts of the scene that do not need it. If it is not, it will degrade the parts that do.

@jhalbroo
Copy link

jhalbroo commented Feb 8, 2017

Thanks @mramato! I tried out the work-around and it enhanced the image quality. I compared it to Open Layers showing the same basemap and they look comparable now. I'll have to assess the quality when I add vector layers, but this looks promising.

@hpinkos
Copy link
Contributor

hpinkos commented Oct 17, 2017

@pjcozzi can we close this?

@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!msg/cesium-dev/sUcx0GLI4Qc/SlU96ZkdCQAJ
https://groups.google.com/d/msg/cesium-dev/sUcx0GLI4Qc/SlU96ZkdCQAJ](https
https://groups.google.com/forum/?hl=en#!topic/cesium-dev/QTSlECbZmG8

If this issue affects any of these threads, please post a comment like the following:

The issue at #4897 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

I am a bot who helps you make Cesium awesome! Thanks again.

@pjcozzi pjcozzi closed this as completed Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests