Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelExperimental - Support rendering in 2D and Columbus View modes #9934

Closed
ptrgags opened this issue Nov 17, 2021 · 4 comments · Fixed by #10419
Closed

ModelExperimental - Support rendering in 2D and Columbus View modes #9934

ptrgags opened this issue Nov 17, 2021 · 4 comments · Fixed by #10419

Comments

@ptrgags
Copy link
Contributor

ptrgags commented Nov 17, 2021

Making a note to keep track of this, ModelExperimental does not yet make draw commands for 2D and Columbus View modes.

Without this, the model ends up out of view or renders incorrectly:

image

@lilleyse
Copy link
Contributor

lilleyse commented Apr 27, 2022

It would be great to fix some of the long running projection issues:

#5112
#5955

We'll need to keep the positions in memory and generate a new vertex buffer containing the projected positions. This would be similar to how indices are handled in #10332. For further optimization ModelExperimental should only do this if frameState.scene3DOnly is false, similar to what other primitives do.

@lilleyse
Copy link
Contributor

@j9liu can this be closed now that #10384 is merged?

@j9liu
Copy link
Contributor

j9liu commented May 31, 2022

I wanted to keep this open until the individual model projection was merged, if that's okay?

@lilleyse
Copy link
Contributor

@j9liu yes that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants