More IE 11 fixes #1843
Merged
More IE 11 fixes #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11. If the shader program for the color command had uniforms optimized out that were not also optimized out in the pick command, the uniform map for the pick command did not contain the uniforms.
|
Works as advertised. (Tested on IE stable). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1616.
Fixes
INVALID_OPERATION: getUniform (Occurs when Geometry is used: link)and brings us down to four test failures in DC1 (IE dev channel). The model tests below pass when ran alone.Will take another look on Friday.