Shadow map fixes #4615
Merged
Shadow map fixes #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wow, good catch! This looks good to merge after #4614. |
mramato
reviewed
Nov 7, 2016
| @@ -187,7 +187,7 @@ define([ | |||
| // In IE11 polygon offset is not functional. | |||
| // TODO : Also disabled for Chrome (ANGLE) temporarily. Re-enable once https://github.com/AnalyticalGraphicsInc/cesium/issues/4560 is resolved. | |||
| var polygonOffsetSupported = true; | |||
| if (FeatureDetection.isInternetExplorer() || (FeatureDetection.isChrome() && FeatureDetection.isWindows())) { | |||
| if (FeatureDetection.isInternetExplorer() || FeatureDetection.isEdge() || ((FeatureDetection.isChrome() || FeatureDetection.isFirefox()) && FeatureDetection.isWindows() && !context.depthTexture)) { | |||
There was a problem hiding this comment.
Please update the TODO comment to reflect the full scope of this check, since it's now out of date.
|
Fixed TODO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #4614 first
Related to #4560
I changed
160581375.0to16581375.0. There was a typo in the original blog post: http://aras-p.info/blog/2009/07/30/encoding-floats-to-rgba-the-final/#comment-553113170. This affected a couple areas, but I didn't notice any change in behavior after.Now
polygonOffsetis enabled unless the user is on IE, on Edge, or using ANGLE without depth texture support.