Safer model attribute checking #5004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yeah I didn't have any problems, our old b3dm datasets work again with this new patch. Thanks |
|
Thanks for the quick test, @jbo023! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4975 I rearranged the model attribute checking code with the assumption that glTF programs would list the same attributes as the technique. However this broke some existing models like #4673 (comment) and others.
This reverts the old functionality and adds the precreated attributes as a separate section.
@jbo023 would you like to test this with the original tileset?
EDIT : that tileset is working again now with these changes