Remove obsolete buffer limit check #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just hoping to simplify incorporating this change since @OksanaTunik is not yet in the contributor list. Would it be possible to get a review thanks @mramato or @lilleyse ?
Previously there was a hard-coded limit of 192MB for the buffer length, preventing the library from processing larger files. The comment in the code mentioned the nodejs/node#4266 which was resolved in 2016 for Node 0.12 (which has reached its EOL long-long ago).
There is sort of a workaround for this limitation by using the separate and separateTextures options, but they are not
always a suitable solution.
This change address #59 .