Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your Maven Artifact Ids are "common" and "v1_6" - should be more distinct #173

Open
in-fke opened this issue Jan 19, 2022 · 2 comments · May be fixed by #175
Open

Your Maven Artifact Ids are "common" and "v1_6" - should be more distinct #173

in-fke opened this issue Jan 19, 2022 · 2 comments · May be fixed by #175

Comments

@in-fke
Copy link
Contributor

in-fke commented Jan 19, 2022

Imagine the Jars being packaged into a .war, their names would be:

WEB-INF/lib/common-1.0.jar
WEB-INF/lib/v1_6-1.0.1.jar

= not very distinct with regard to other jar files.
Maybe artifactIds like "oca-ocpp-common" and "oca-ocpp-v1_6" would make more sense?

@TVolden
Copy link
Member

TVolden commented Feb 26, 2022

Hi @in-fke,

Sorry for the slow reply.

You make an excellent point. I will look into to rename artifacts, once I have the time.

Thanks.

Sincerely,
Thomas

@TVolden TVolden linked a pull request Feb 26, 2022 that will close this issue
@splatch
Copy link

splatch commented Apr 14, 2022

Imagine the Jars being packaged into a .war, their names would be:

For maven-war-plugin and also other WAR archive creators elsewhere you usually can specify artifact naming pattern. What you see is an $artifactId-$version.$packaging (in maven terms) but nothing holds you from changing it into $groupId.$artifactId-$version.$packaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants