Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud HTTP health check of LoadBalancer keep UNHEALTHY #181

Open
danielcaro opened this issue Mar 1, 2022 · 5 comments
Open

Cloud HTTP health check of LoadBalancer keep UNHEALTHY #181

danielcaro opened this issue Mar 1, 2022 · 5 comments

Comments

@danielcaro
Copy link
Contributor

danielcaro commented Mar 1, 2022

Problem:

When the service is deployed to GKE or any K8s behind load balancer with health check, the validator will try fetch HTTP response or TCP (https://cloud.google.com/load-balancing/docs/health-check-concepts#criteria-protocol-ssl-tcp) , but the Java Websocket implementations make fail the health check, and the service keep UNHEALTHY .

Solution:

Implement a Draft_HttpHealthCheck using the suggestion proposed by @SerVB at TooTallNate/Java-WebSocket#1077 becauseJava_Websocket owner said that will not provide a draft to support http health check.

PS:
If you like I can send a PR with my approach solution, that already works well :D .

@TVolden
Copy link
Member

TVolden commented Mar 2, 2022

Hi @danielcaro

Yes please set up a PR, I'll gladly review your code and merge it if it passes the automated tests.

Sincerely,
Thomas

@danielcaro
Copy link
Contributor Author

Hi, I found some problems now, I gonna test the solution at production first. Then I'll sent the PR.

@danielcaro
Copy link
Contributor Author

The solution was tested on production, but I would like to hear your advice.

#189

@TVolden
Copy link
Member

TVolden commented May 15, 2022

Okay, the PR is merged. Please check if it works as intended and close the issue :)

@fabiangr
Copy link

Hi @TVolden , hi @danielcaro ,

I would like to use your library within a Spring Boot Project and use Spring's implementation for health checks etc (Actuator). As far as I understand it, the current implementation answers 200 OK on every possible HTTP route I could call. Is there a way to deactivate this behaviour or limit it to certain routes to be able to use my own implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants