Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chia rs 0.10.0 #18135

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Bump chia rs 0.10.0 #18135

merged 6 commits into from
Jun 12, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jun 10, 2024

This PR is best reviewed one commit at a time.

Purpose:

Update chia_rs to the latest version, 0.10.0.

In this version, there were two major changes to the API:

The ConsensusConstants class, in addition to AGG_SIG_ME_ADDITIONAL_DATA, contains the constants for all other AGG_SIG_* conditions as well. i.e. this is the suffix we append to the condition message before signing or verifying the signature.

These fields are now used by the condition parser (in rust) to validate that AGG_SIG_UNSAFE messages do not end with any of these reserved suffixes. Doing so is a consensus violation. This check is currently performed in pkm_pairs(), and this patch removes it, and updates the tests to be end-to-end, to cover the rust condition parser.

The second major change is that NO_RELATIVE_CONDITIONS_ON_EPHEMERAL was removed, and always on. This was a soft-fork that has activated and is now part of the consensus rules.

Current Behavior:

The agg sig additional data is checked in pkm_pairs(), in python.

relative conditions are explicitly disallowed.

New Behavior:

The agg sig additional data is checked in the condition parser, in chia_rs.

relative conditions are implicitly disallowed by being always-on in the new chia_rs version.

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jun 10, 2024
@arvidn arvidn marked this pull request as ready for review June 10, 2024 10:58
@arvidn arvidn requested a review from a team as a code owner June 10, 2024 10:58
@arvidn arvidn requested a review from AmineKhaldi June 10, 2024 10:58
Copy link

coveralls-official bot commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9446953459

Details

  • 74 of 87 (85.06%) changed or added relevant lines in 7 files are covered.
  • 56 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.06%) to 90.843%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/consensus/constants.py 2 15 13.33%
Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 72.57%
chia/farmer/farmer.py 1 72.23%
chia/daemon/client.py 1 73.33%
chia/introducer/introducer.py 1 78.26%
chia/data_layer/data_layer.py 2 85.56%
chia/server/ws_connection.py 2 88.69%
chia/rpc/rpc_server.py 3 88.04%
chia/server/server.py 4 81.46%
chia/introducer/introducer_api.py 5 78.26%
chia/wallet/wallet_node.py 6 88.65%
Totals Coverage Status
Change from base Build 9432246969: -0.06%
Covered Lines: 99989
Relevant Lines: 110002

💛 - Coveralls

@arvidn arvidn force-pushed the bump-chia-rs-0.10.0 branch 2 times, most recently from f1f63aa to b9f6059 Compare June 10, 2024 13:41
Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>
Copy link

coveralls-official bot commented Jun 10, 2024

Pull Request Test Coverage Report for Build 9450002434

Details

  • 93 of 93 (100.0%) changed or added relevant lines in 7 files are covered.
  • 19 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.01%) to 90.91%

Files with Coverage Reduction New Missed Lines %
chia/rpc/rpc_server.py 1 89.04%
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/introducer/introducer.py 1 78.26%
chia/server/ws_connection.py 2 88.69%
chia/_tests/core/util/test_lockfile.py 4 88.26%
chia/server/server.py 4 81.46%
chia/wallet/wallet_node.py 6 88.65%
Totals Coverage Status
Change from base Build 9432246969: 0.01%
Covered Lines: 100059
Relevant Lines: 110008

💛 - Coveralls

@cmmarslender cmmarslender merged commit 66a8554 into main Jun 12, 2024
366 checks passed
@cmmarslender cmmarslender deleted the bump-chia-rs-0.10.0 branch June 12, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants