Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-738] Add a better clawback auto claim test and fix related issue #18141

Merged
merged 15 commits into from
Jul 12, 2024

Conversation

Quexington
Copy link
Contributor

This PR adds test coverage for a line in wallet state manager's auto_claim_coins function. The line itself wasn't problematic, but the new test exposed a problematic race that this PR should also solve.

@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 10, 2024
@Quexington Quexington changed the title Add a better clawback auto claim test and fix related issue [CHIA-738] Add a better clawback auto claim test and fix related issue Jun 10, 2024
@Quexington Quexington marked this pull request as ready for review June 13, 2024 14:36
@Quexington Quexington requested a review from a team as a code owner June 13, 2024 14:36
@Quexington Quexington marked this pull request as draft June 13, 2024 14:36
Base automatically changed from quex.fix_cat_pending_change to main July 11, 2024 18:23
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 11, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 11, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 11, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 11, 2024
@Quexington Quexington marked this pull request as ready for review July 11, 2024 19:23
@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Jul 12, 2024
@Starttoaster Starttoaster merged commit 064d34f into main Jul 12, 2024
372 checks passed
@Starttoaster Starttoaster deleted the quex.auto_claim_better_test branch July 12, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants