Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-690] Add offer expiration to CLI #18193

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Jun 17, 2024

We didn't have a way to display this information previously which basically meant users had to use the GUI in order to manager expiring offers effectively.

Example:

Record with id: 0101010101010101010101010101010101010101010101010101010101010101
---------------
Created at: 1970-05-23 14:21:18
Confirmed at: Not confirmed
Accepted at: N/A
Status: PENDING_ACCEPT
Summary:
  OFFERED:
  REQUESTED:
Pending Outbound Balances:
Included Fees: 0 XCH, 0 mojos
Timelock information:
  - Not valid until 1969-12-31 17:00 Pacific Daylight Time
  - Not valid until height 0
  - Expires at 1969-12-31 17:01 Pacific Daylight Time (+/- 10 min)
  - Expires at height 100 (wait ~10 blocks after to be reorg safe)
---------------

@Quexington Quexington added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Jun 17, 2024
@Quexington Quexington marked this pull request as ready for review June 17, 2024 15:20
@Quexington Quexington requested a review from a team as a code owner June 17, 2024 15:20
@Quexington Quexington changed the title Add offer expiration to CLI [CHIA-690] Add offer expiration to CLI Jun 17, 2024
@Quexington Quexington requested a review from emlowe June 18, 2024 15:14
@Chia-Network Chia-Network deleted a comment from coveralls-official bot Jun 20, 2024
Copy link

coveralls-official bot commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9603903845

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 20 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • 517 unchanged lines in 31 files lost coverage.
  • Overall coverage increased (+0.005%) to 90.875%

Files with Coverage Reduction New Missed Lines %
chia/_tests/wallet/test_notifications.py 1 99.33%
chia/server/node_discovery.py 1 80.85%
chia/full_node/full_node.py 1 86.17%
chia/_tests/util/time_out_assert.py 1 98.88%
chia/daemon/client.py 1 73.94%
chia/introducer/introducer.py 1 78.26%
chia/cmds/keys_funcs.py 1 90.74%
chia/_tests/core/util/test_file_keyring_synchronization.py 1 97.1%
chia/_tests/plot_sync/test_receiver.py 1 99.68%
chia/simulator/block_tools.py 2 91.34%
Totals Coverage Status
Change from base Build 9524346852: 0.005%
Covered Lines: 100224
Relevant Lines: 110226

💛 - Coveralls

Copy link

coveralls-official bot commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9621873705

Details

  • 20 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • 37 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.002%) to 90.876%

Files with Coverage Reduction New Missed Lines %
chia/data_layer/data_store.py 1 94.37%
chia/_tests/core/full_node/test_transactions.py 1 99.11%
chia/server/server.py 1 81.46%
chia/daemon/server.py 1 83.22%
chia/data_layer/data_layer.py 2 85.32%
chia/data_layer/data_layer_wallet.py 2 91.93%
chia/rpc/rpc_server.py 3 87.71%
chia/full_node/full_node.py 4 85.8%
chia/_tests/core/util/test_lockfile.py 22 77.73%
Totals Coverage Status
Change from base Build 9619484401: -0.002%
Covered Lines: 100233
Relevant Lines: 110233

💛 - Coveralls

@Starttoaster
Copy link
Contributor

Closing and re-opening to update CI

@Starttoaster Starttoaster reopened this Jun 24, 2024
@Starttoaster Starttoaster merged commit 6ed262e into main Jun 24, 2024
1038 of 1044 checks passed
@Starttoaster Starttoaster deleted the quex.offer_expiration_cli branch June 24, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants